explanatory error message on delete attempt of default system offering (apache#8883)

DaanHoogland · gp-santos · web-flow · commit eead2710f818 · 2024-04-25T16:45:42.000+02:00
Co-authored-by: Gabriel Pordeus Santos &lt;gabrielpordeus@gmail.com&gt;
diff --git a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -4204,7 +4204,7 @@ public boolean deleteServiceOffering(final DeleteServiceOfferingCmd cmd) {
         }
 
         if (offering.getDefaultUse()) {
-            throw new InvalidParameterValueException("Default service offerings cannot be deleted");
+            throw new InvalidParameterValueException(String.format("The system service offering [%s] is marked for default use and cannot be deleted", offering.getDisplayText()));
         }
 
         final User user = _userDao.findById(userId);

Original file line number	Diff line number	Diff line change
`@@ -4204,7 +4204,7 @@ public boolean deleteServiceOffering(final DeleteServiceOfferingCmd cmd) {`
`4204`	`4204`	`}`
`4205`	`4205`
`4206`	`4206`	`if (offering.getDefaultUse()) {`
`4207`		`- throw new InvalidParameterValueException("Default service offerings cannot be deleted");`
	`4207`	`+ throw new InvalidParameterValueException(String.format("The system service offering [%s] is marked for default use and cannot be deleted", offering.getDisplayText()));`
`4208`	`4208`	`}`
`4209`	`4209`
`4210`	`4210`	`final User user = _userDao.findById(userId);`