Skip to content

Commit ced1630

Browse files
committed
Fixed conditions on multiple test runs to match newer Python versions
Also allow for matrix to continue on failure so we can see all the error all at once and resolve them instead of doing it one at a time.
1 parent 622d64e commit ced1630

1 file changed

Lines changed: 13 additions & 15 deletions

File tree

.github/workflows/CI.yml

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ jobs:
66
build:
77

88
runs-on: ubuntu-latest
9+
continue-on-error: true
910
strategy:
1011
matrix:
1112
python-version: [3.8, 3.11, 3.12, pypy-3.9]
@@ -35,7 +36,7 @@ jobs:
3536
python -m pip install --upgrade pip
3637
pip install -r requirements-dev.txt
3738
- name: Install dependencies for pypy
38-
if: matrix.python-version == 'pypy-3.7'
39+
if: matrix.python-version == 'pypy-3.9'
3940
run: |
4041
python -m pip install --upgrade pip
4142
pip install -r requirements.txt
@@ -51,24 +52,21 @@ jobs:
5152
echo "WEBDRIVERPATH=$($SELENIUM_MANAGER_EXE --browser chrome --debug | awk '/INFO[[:space:]]Driver path:/ {print $NF;exit}')" >> "$GITHUB_ENV"
5253
echo "$WEBDRIVERPATH"
5354
- name: Generate stub file for ${{ matrix.python-version }}
54-
if: matrix.python-version != 'pypy-3.7'
55+
if: matrix.python-version != 'pypy-3.9'
5556
run: |
5657
invoke gen-stub
57-
- name: Debugging
58-
if: matrix.python-version != 'pypy-3.7'
59-
run: |
60-
which python
6158
6259
- name: Run tests with headless Chrome and with PyPy
63-
if: matrix.python-version == 'pypy-3.7'
60+
if: matrix.python-version == 'pypy-3.9'
6461
run: |
6562
xvfb-run --auto-servernum python atest/run.py --nounit --zip headlesschrome
6663
67-
- name: Run tests with normal Chrome and with Python 3.7
68-
if: matrix.python-version == '3.7'
64+
- name: Run tests with normal Chrome if CPython
65+
if: matrix.python-version != 'pypy-3.9'
6966
run: |
7067
xvfb-run --auto-servernum python atest/run.py --zip chrome
7168
69+
# Recognize for the moment this will NOT run as we aren't using Python 3.9
7270
- name: Run tests with headless Firefox with Python 3.9 and RF 4.1.3
7371
if: matrix.python-version == '3.9' && matrix.rf-version == '4.1.3'
7472
run: |
@@ -79,12 +77,12 @@ jobs:
7977
run: |
8078
xvfb-run --auto-servernum python atest/run.py --zip firefox
8179
82-
- name: Run tests with Selenium Grid
83-
if: matrix.python-version == '3.8' && matrix.rf-version == '3.2.2' && matrix.python-version != 'pypy-3.7'
84-
run: |
85-
wget --no-verbose --output-document=./selenium-server-standalone.jar http://selenium-release.storage.googleapis.com/3.141/selenium-server-standalone-3.141.59.jar
86-
sudo chmod u+x ./selenium-server-standalone.jar
87-
xvfb-run --auto-servernum python atest/run.py --zip headlesschrome --grid True
80+
# - name: Run tests with Selenium Grid
81+
# if: matrix.python-version == '3.11' && matrix.rf-version == '3.2.2' && matrix.python-version != 'pypy-3.7'
82+
# run: |
83+
# wget --no-verbose --output-document=./selenium-server-standalone.jar http://selenium-release.storage.googleapis.com/3.141/selenium-server-standalone-3.141.59.jar
84+
# sudo chmod u+x ./selenium-server-standalone.jar
85+
# xvfb-run --auto-servernum python atest/run.py --zip headlesschrome --grid True
8886

8987
- uses: actions/upload-artifact@v1
9088
if: success() || failure()

0 commit comments

Comments
 (0)