From 20c9424e9c83fb5356a2378a799c075862e22cf2 Mon Sep 17 00:00:00 2001 From: thomaspanf Date: Thu, 10 Sep 2026 17:24:31 -0700 Subject: [PATCH] Fix executeUpgradeHandler ID parsing and error response --- rocketpool/api/upgrade/execute-upgrade.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rocketpool/api/upgrade/execute-upgrade.go b/rocketpool/api/upgrade/execute-upgrade.go index 04efc0f5f..7ee10822d 100644 --- a/rocketpool/api/upgrade/execute-upgrade.go +++ b/rocketpool/api/upgrade/execute-upgrade.go @@ -127,9 +127,9 @@ func executeUpgrade(c *cli.Command, upgradeProposalId uint64, t *snroute.Transac } func canExecuteUpgradeHandler(ctx snroute.Context) { - id, err := cliutils.ValidatePositiveUint("upgrade proposal ID", ctx.Request.URL.Query().Get("id")) + id, err := cliutils.ValidatePositiveUint("upgrade proposal ID", ctx.Request.FormValue("id")) if err != nil { - response.WriteResponse(ctx.Writer, nil, err) + response.WriteErrorResponse(ctx.Writer, err) return } resp, err := canExecuteUpgrade(ctx.Command(), id) @@ -137,9 +137,9 @@ func canExecuteUpgradeHandler(ctx snroute.Context) { } func executeUpgradeHandler(ctx snroute.WriteContext) { - id, err := strconv.ParseUint(ctx.Request.URL.Query().Get("id"), 10, 64) + id, err := strconv.ParseUint(ctx.Request.FormValue("id"), 10, 64) if err != nil { - response.WriteResponse(ctx.Writer, nil, err) + response.WriteErrorResponse(ctx.Writer, err) return } opts, err := ctx.Transactor()