refactor: pharmacy controller migrate to service layer

Author: rohitbytecode

src/controllers/nurse.controller.js

@@ -1,5 +1,3 @@
-import User from "../models/User.js";
-import bcrypt from "bcrypt";
 import nurseService from "../services/nurse.service.js";
 
 const createNurse = async (req, res) => {

src/controllers/pharmacy.controller.js

@@ -1,86 +1,52 @@
-import User from '../models/User.js';
-import bcrypt from 'bcrypt';
+import pharmacyService from "../services/pharmacy.service.js";
 
-const createPharmacist = async (req,res) => {
+const createPharmacist = async (req, res) => {
     try {
-        const password = req.body.password || 'pharmacist@123';
-        const hashedPassword = await bcrypt.hash(password, 10);
-
-        const pharmacist = new User({
-            ...req.body,
-            password: hashedPassword,
-            role: 'pharmacist'
-        });
-
-        await pharmacist.save();
+        const pharmacist = await pharmacyService.createPharmacist(req.body);
         res.status(201).json(pharmacist);
     } catch (err) {
         res.status(400).json({ message: err.message });
     }
 };
 
-const changePassword = async (req,res) => {
+const changePassword = async (req, res) => {
     try {
-        const pharmacist = await User.findById(req.user.id);
-        const { oldPassword, newPassword } = req.body;
-
-        const isMatch = await bcrypt.compare(oldPassword, pharmacist.password);
-        if (!isMatch) return res.status(400).json({ message: 'Old password is incorrect' });
-
-        pharmacist.password = await bcrypt.hash(newPassword, 10);
-        await pharmacist.save();
-
-        res.status(200).json({ message: 'Password updated successfully' });
+        const { oldPassword, newPassword }= req.body;
+        const result = await pharmacyService.changePassword(
+            req.user.id,
+            oldPassword,
+            newPassword
+        );
+        res.status(200).json(result);
     } catch (err) {
-        res.status(500).json({ message: err.message });
+        res.status(400).json({ message: err.message });
     }
 };
 
-const getPharmacists = async (req,res) => {
+const getPharmacists = async (req, res) => {
     try {
-        const pharmacist = await User.find({ role: 'pharmacist' });
-        res.json(pharmacist);
+        const pharmacists = await pharmacyService.getPharmacists();
+        res.json(pharmacists);
     } catch (err) {
         res.status(500).json({ message: err.message });
     }
 };
 
-const updatePharmacist = async (req,res) => {
+const updatePharmacist = async (req, res) => {
     try {
         const { id } = req.params;
-
-        if (req.body.password) {
-            req.body.password = await bcrypt.hash(req.body.password, 10);
-
-        }
-
-        const pharmacist = await User.findOneAndUpdate(
-            { _id: id, role: 'pharmacist' },
-            req.body,
-            { new: true, runValidators: true }
-        );
-
-        if (!pharmacist) {
-            return res.status(404).json({ message: 'Pharmacist not found' });
-        }
-
+        const pharmacist = await pharmacyService.updatePharmacist(id, req.body);
         res.json(pharmacist);
     } catch (err) {
         res.status(400).json({ message: err.message });
     }
 };
 
-const deletePharmacist = async (req,res) => {
+const deletePharmacist = async (req, res) => {
     try {
         const { id } = req.params;
-
-        const pharmacist = await User.findOneAndDelete({ _id: id, role: 'pharmacist' });
-
-        if (!pharmacist) {
-            return res.status(400).json({ message: 'Pharmacist not found' });
-        }
-
-        res.json({ message: 'Pharmacist deleted successfully' });
+        const result = await pharmacyService.deletePharmacist(id);
+        res.json(result);
     } catch (err) {
         res.status(500).json({ message: err.message });
     }
@@ -92,4 +58,5 @@ export {
     getPharmacists,
     updatePharmacist,
     deletePharmacist
-};
+}
+