refactor: begin moving logic from controller to service layer; doctor login API still pending fix

Author: rohitbytecode

src/controllers/doctor.controller.js

@@ -1,18 +1,8 @@
-import User from '../models/User.js';
-import bcrypt from 'bcrypt';
+import doctorService from '../services/doctor.service.js';
 
 const createDoctor = async (req, res) => {
   try {
-    const password = req.body.password || "doctor@123"; 
-    const hashedPassword = await bcrypt.hash(password, 10);
-
-    const doctor = new User({
-      ...req.body,           
-      password: hashedPassword,
-      role: 'doctor'
-    });
-
-    await doctor.save();
+    const doctor = await doctorService.createDoctor(req.body);
     res.status(201).json(doctor);
   } catch (err) {
     res.status(400).json({ message: err.message });
@@ -21,25 +11,20 @@ const createDoctor = async (req, res) => {
 
 const changePassword = async (req, res) => {
   try {
-    const doctor = await User.findById(req.user.id); 
     const { oldPassword, newPassword } = req.body;
-
-    const isMatch = await bcrypt.compare(oldPassword, doctor.password);
-    if (!isMatch) return res.status(400).json({ message: 'Old password is incorrect' });
-
-    doctor.password = await bcrypt.hash(newPassword, 10);
-    await doctor.save();
-
-    res.status(200).json({ message: 'Password updated successfully' });
+    const result = await doctorService.changePassword(
+      req.user.id, 
+      oldPassword, 
+      newPassword);
+    res.status(200).json(result);
   } catch (err) {
-    res.status(500).json({ message: err.message });
+    res.status(400).json({ message: err.message });
   }
 };
 
-
 const getDoctors = async (req, res) => {
   try {
-    const doctors = await User.find({ role: 'doctor' });
+    const doctors = await doctorService.getDoctors();
     res.json(doctors);
   } catch (err) {
     res.status(500).json({ message: err.message });
@@ -49,21 +34,7 @@ const getDoctors = async (req, res) => {
 const updateDoctor = async (req, res) => {
   try {
     const { id } = req.params;
-
-    if (req.body.password) {
-      req.body.password = await bcrypt.hash(req.body.password, 10);
-    }
-
-    const doctor = await User.findOneAndUpdate(
-      { _id: id, role: 'doctor' },
-      req.body,
-      { new: true, runValidators: true }
-    );
-
-    if (!doctor) {
-      return res.status(404).json({ message: 'Doctor not found' });
-    }
-
+    const doctor = await doctorService.updateDoctor(id, req.body);
     res.json(doctor);
   } catch (err) {
     res.status(400).json({ message: err.message });
@@ -73,19 +44,13 @@ const updateDoctor = async (req, res) => {
 const deleteDoctor = async (req, res) => {
   try {
     const { id } = req.params;
-
-    const doctor = await User.findOneAndDelete({ _id: id, role: 'doctor' });
-
-    if (!doctor) {
-      return res.status(404).json({ message: 'Doctor not found' });
-    }
-
-    res.json({ message: 'Doctor deleted successfully' });
+    const result = await doctorService.deleteDoctor(id);
+    res.json(result);
   } catch (err) {
     res.status(500).json({ message: err.message });
   }
 };
-
+  
 export {
   createDoctor,
   changePassword,

src/services/doctor.service.js

@@ -0,0 +1,63 @@
+import User from '../models/User.js';
+import bcrypt from 'bcrypt';
+
+const createDoctor = async (data) => {
+    const password = data.password || 'doctor@123';
+    const hashedPassword = await bcrypt.hash(password, 10);
+    
+    const doctor = new User({
+        ...data,
+        password: hashedPassword,
+        role: 'Doctor',
+    });
+
+    return await doctor.save();
+}
+
+const changePassword = async (useImperativeHandle, oldPassword, newPassword) => {
+    const doctor = await User.findById(userId);
+    if(!doctor) throw new Error('Doctor not found');
+
+    const isMatch = await bcrypt.compare(oldPassword, doctor.password);
+    if(!isMatch) throw new Error('Old password is incorrect');
+
+    doctor.password = await bcrypt.hash(newPassword, 10);
+    await doctor.save();
+
+    return { message: 'Password changed successfully' };
+};
+
+const getDoctors = async () => {
+    return await User.find({ role: 'doctor' });
+};
+
+const updateDoctor = async (id, data) => {
+    if(data.password) {
+        data.password = await bcrypt.hash(data.password, 10);
+    }
+
+    const doctor = await User.findOneAndUpdate(
+        { _id: id, role: 'doctor' },
+        data,
+        { new: true, runvalidators: true }
+    );
+
+    if(!doctor) throw new Error('Doctor not found');
+
+    return doctor;
+};
+
+const deleteDoctor = async (id) => {
+    const doctor = await User.findOneAndDelete({ _id: id, role: 'doctor' });
+    if(!doctor) throw new Error('Doctor not found');
+
+    return { message: 'Doctor deleted successfully' };
+};
+
+export {
+  createDoctor,
+  changePassword,
+  getDoctors,
+  updateDoctor,
+  deleteDoctor
+};