Merge pull request #5 from hms-int/dev-gautam

refactor code

Author: rohitbytecode

server.js

@@ -2,10 +2,12 @@ import 'dotenv/config';
 import app from './src/app.js';
 import connectDB from './src/config/db.js';
 
-connectDB();
-
 const PORT = process.env.PORT || 5000;
 
-app.listen(PORT, () => {
-  console.log(`Server running on port ${PORT}`);
-});
+connectDB().then(() => {
+  app.listen(PORT, () => {
+    console.log(`Server running on port ${PORT}`);
+  });
+}).catch((error) => {
+  console.log(`Error: ${error}`);
+});

src/app.js

@@ -19,12 +19,17 @@ import appointmentRoutes from './routes/appointment.js';
 const app = express();
 
 // Global middleware
-app.use(cors());
+app.use(cors({
+  origin: "*",
+  credentials: true
+}));
 app.use(express.json());
 app.use(morgan('dev'));
 
-app.get('/', (req, res) => {
-  res.json({ ok: true });
+app.get('/', (_req, res) => {
+  res.status(200).json({
+    message: "Backend is online"
+  })
 });
 
 app.use('/api/auth', authRoutes);
@@ -41,10 +46,10 @@ app.use('/api/patients', patientRoutes);
 app.use('/api/departments', deptRoutes);
 app.use('/api/appointments', appointmentRoutes);
 
-app.use((err, req, res, next) => {
+app.use((err, _req, res, _next) => {
   console.error(err);
   res.status(err.status || 500).json({
-    error: err.message || 'Server error'
+    error: err.message || 'Internal Server Error'
   });
 });
 

src/controllers/authcontroller.js

@@ -6,6 +6,13 @@ export const login = async (req, res) => {
   try {
     const { role, email, password } = req.body;
 
+    if (!role || !email || !password) {
+      return res.status(400).json({
+        success: false,
+        message: "Invalid Request",
+      });
+    }
+
     const user = await User.findOne({
       email: { $regex: new RegExp(`^${email}$`, 'i') },
       role: { $regex: new RegExp(`^${role}$`, 'i') },
@@ -48,4 +55,4 @@ export const login = async (req, res) => {
     console.error('Login error:', error);
     res.status(500).json({ success: false, message: 'Server error' });
   }
-};
+};

src/middleware/authmiddleware.js

@@ -1,5 +1,4 @@
 import jwt from 'jsonwebtoken';
-import User from '../models/User.js';
 
 const protect = (req, res, next) => {
   let token;
@@ -44,4 +43,4 @@ const authorize = (...roles) => {
 };
 
 
-export { protect, authorize };
+export { protect, authorize };