refactor: extract reception logic into service layer and standardize create method responses

Author: rohitbytecode

src/controllers/reception.controller.js

@@ -1,44 +1,31 @@
-import User from '../models/User.js';
-import bcrypt from 'bcrypt';
+import receptionService from "../services/reception.service.js";
 
-const creatReceptionist = async (req, res) =>{
-    try{
-        const password = req.body.password || 'reception@123';
-        const hashedPassword = await bcrypt.hash(password, 10);
-
-        const receptionist = new User({
-            ...req.body,
-            password: hashedPassword,
-            role: 'receptionist'
-        });
-
-        await receptionist.save();
+const creatReceptionist = async (req, res) => {
+    try {
+        const receptionist = await receptionService.creatReceptionist(req.body);
         res.status(201).json(receptionist);
-    } catch(err) {
+    } catch (err) {
         res.status(400).json({ message: err.message });
     }
-}
+};
 
 const changePassword = async (req, res) => {
     try {
-        const receptionist = await User.findById(req.user.id);
-        const {oldPassword, newPassword} = req.body;
-
-        const isMatch = await bcrypt.compare(oldPassword, receptionist.password);
-        if (!isMatch) return res.status(400).json({ message: "Old password is incorrect"});
-
-        receptionist.password = await bcrypt.hash(newPassword, 10);
-        await receptionist.save();
-
-        res.status(200).json({ message: "Password updated successfully" });        
+        const { oldPassword, newPassword } = req.body;
+        const result = await receptionService.changePassword(
+            req.user.id,
+            oldPassword,
+            newPassword
+        );
+        res.status(200).json(result);
     } catch (err) {
-        res.status(500).json({ message: err.message});
+        res.status(400).json({ message: err.message });
     }
 };
 
-const getReceptionist = async (req, res) => {
+const getReceptionists = async (req, res) => {
     try {
-        const receptionist = await User.find({ role: 'receptionist'});
+        const receptionist = await receptionService.getReceptionists();
         res.json(receptionist);
     } catch (err) {
         res.status(500).json({ message: err.message });
@@ -48,47 +35,28 @@ const getReceptionist = async (req, res) => {
 const updateReceptionist = async (req, res) => {
     try {
         const { id } = req.params;
-
-        if(res.body.password){
-            req.body.password = await bcrypt.hash(req.body.password, 10);
-        }
-
-        const receptionist = await User.findOneAndUpdate(
-            { _id: id, role: 'receptionist' },
-            req.body,
-            { new: true, runValidators: true }
-        );
-
-        if (!receptionist){
-            return res.status(404).json({ message: 'Receptionist not found' });
-        }
-
+        const receptionist = await receptionService.updateReceptionist(id, req.body);
         res.json(receptionist);
     } catch (err) {
         res.status(400).json({ message: err.message });
     }
 };
 
 const deleteReceptionist = async (req, res) => {
-    try{
+    try {
         const { id } = req.params;
-
-        const receptionist = await User.findOneAndDelete({ _id: id, role: 'receptionist' });
-        
-        if (!receptionist) {
-            return res.status(404).json({ message: "Receptionist not found" });
-        }
-
-        res.json({ message: "Receptionist deleted successfully" });
+        const result = await receptionService.deleteReceptionist(id);
+        res.json(result);
     } catch (err) {
         res.status(500).json({ message: err.message });
     }
 };
 
+
 export {
     creatReceptionist,
     changePassword,
-    getReceptionist,
+    getReceptionists,
     updateReceptionist,
     deleteReceptionist
 };

src/routes/reception.routes.js

@@ -6,7 +6,7 @@ const router = express.Router();
 
 router.post('/', protect, authorize('admin'), receptionController.creatReceptionist);
 
-router.get('/', protect, authorize('admin', 'receptionist'), receptionController.getReceptionist);
+router.get('/', protect, authorize('admin', 'receptionist'), receptionController.getReceptionists);
 
 router.put('/change-password', protect, authorize('receptionist'), receptionController.changePassword);
 

src/services/doctor.service.js

@@ -4,16 +4,22 @@ import bcrypt from 'bcrypt';
 const createDoctor = async (data) => {
     const password = data.password || 'doctor@123';
     const hashedPassword = await bcrypt.hash(password, 10);
-    
+
     const doctor = new User({
         ...data,
         password: hashedPassword,
         role: 'doctor',
     });
 
-    return await doctor.save();
+    await doctor.save();
+
+    return {
+        success: true,
+        message: 'Doctor created successfully',
+    };
 };
 
+
 const changePassword = async (userId, oldPassword, newPassword) => {
     const doctor = await User.findById(userId);
     if(!doctor) throw new Error('Doctor not found');

src/services/lab.service.js

@@ -1,6 +1,5 @@
 import User from '../models/User.js';
 import bcrypt from 'bcrypt';
-import doctorService from './doctor.service.js';
 
 const createLabtechnician = async (data) => {
         const password = data.password || 'labtech@123';
@@ -12,7 +11,12 @@ const createLabtechnician = async (data) => {
             role: 'lab-technician'
         });
 
-        return await technician.save();
+        await technician.save();
+
+        return {
+            success: true,
+            message: 'Lab technician created successfully'
+        };
 };
 
 const changePassword = async (userId,oldPassword, newPassword) => {

src/services/nurse.service.js

@@ -11,7 +11,12 @@ const createNurse = async (data) => {
         role: 'nurse',
     });
 
-    return await nurse.save();
+    await nurse.save();
+
+    return {
+        success: true,
+        message: 'Nurse created successfully'
+    };
 };
 
 const changePassword = async (userId, oldPassword, newPassword) => {

src/services/pharmacy.service.js

@@ -11,7 +11,12 @@ const createPharmacist = async (data) => {
        role: 'pharmacist', 
     });
 
-    return await pharmacist.save();
+    await pharmacist.save();
+
+    return {
+        success: true,
+        message: 'Pharmacist created successfully'
+    };
 };
 
 const changePassword = async (userId, oldPassword, newPassword) => {

src/services/reception.service.js

@@ -11,9 +11,61 @@ const creatReceptionist = async (data) => {
         role: 'receptionist'
     });
 
-    return await receptionist.save();
+    await receptionist.save();
+
+    return {
+        success: true,
+        message: 'Receptionist created successfully'
+    };
 };
 
 const changePassword = async (userId, oldPassword, newPassword) => {
-    const receptionist = await User.findById(userId)
-}
+    const receptionist = await User.findById(userId);
+    if(!receptionist) throw new Error('Receptionist not found');
+
+    const isMatch = await bcrypt.compare(oldPassword, receptionist.password);
+    if(!isMatch) throw new Error('Old password is incorrect');
+
+    receptionist.password = await bcrypt.hash(newPassword, 10);
+    await receptionist.save();
+
+    return { message: 'Password changes successfully' };
+};
+
+const getReceptionists = async () => {
+    return await User.find({ role: 'receptionist' });
+};
+
+const updateReceptionist = async (id, data) => {
+    if(data.password) {
+        data.password = await bcrypt.hash(data.password, 10);
+    }
+
+    const receptionist = await User.findOneAndUpdate(
+        { _id: id, role: 'receptionist' },
+        data,
+        { new: true, runValidators:true }
+    );
+
+    if(!receptionist) throw new Error('Receptionist not found');
+
+    return receptionist;
+};
+
+const deleteReceptionist = async (id) => {
+    const receptionist = await User.findOneAndDelete(
+        { _id: id, role: 'receptionist' }
+    );
+
+    if(!receptionist) throw new Error('Receptionist not found');
+
+    return { message: 'Receptionist deleted successfully' };
+};
+
+export default {
+    creatReceptionist,
+    changePassword,
+    getReceptionists,
+    updateReceptionist,
+    deleteReceptionist
+};