refactor: nurse service add

Author: rohitbytecode

src/controllers/nurse.controller.js

@@ -1,95 +1,9 @@
 import User from "../models/User.js";
 import bcrypt from "bcrypt";
+import nurseService from "../services/nurse.service.js";
 
-const createNurse= async (req, res) => {
+const createNurse = async => {
     try {
-        const password= req.body.password || 'nurse@123';
-        const hashedPassword= await bcrypt.hash(password, 10);
-
-        const nurse= new User({
-            ...req.body,
-            password: hashedPassword,
-            role: 'nurse'
-        });
-        await nurse.save();
-        res.status(201).json(nurse);
-    } catch (err) {
-        res.status(400).json({ message: err.message });
-    }
-};
-
-const changePassword = async (req, res) => {
-    try {
-        const nurse= await User.findById(req.user.id);
-        const { oldPassword, newPassword }= req.body;
-
-        const isMatch= await bcrypt.compare(oldPassword, nurse.password);
-        if (!isMatch) return res.status(400).json({ message: 'Old password is incorrect' });
-
-        res.status(200).json({ message: 'Password updated successfully' });
-    } catch (err) {
-        res.status(500).json({ message: err.message });
-    }
-}
-
-const getNurses = async (req, res) => {
-    try {
-        const nurses=await User.find({ role: 'nurse' });
-
-        if(!nurses){
-            res.status(404).json({ message: 'Nurse not found' });
-        }
-
-        res.json(nurses);
-    } catch (err) {
-        res.status(500).json({ message: err.message });
-    }
-};
-
-const updateNurse = async (req,res) =>{
-    try{
-        const { id }= req.params;
-    
-    if (req.body.password){
-    req.body.password=await bcrypt.hash(req.body.password, 10);
-    }
-
-    const nurse = await User.findOneAndUpdate(
-        { _id: id, role: 'nurse'},
-        req.body,
-        { new: true, runValidators: true}
-    );
-
-    if(!nurse){
-        return res.status(404).json({ message: 'Nurse not found' });
-    }
-
-    res.json(nurse);
-    } catch(error) {
-        res.status(400).json({ message: err.message });
+        const nurse = await nurseService.createNurse(req.body);
     }
-};
-
-const deleteNurse =  async (req,res)=> {
-    try{
-      const { id }= req.params;
-
-      const nurse= await User.findOneAndDelete({ _id: id, role: 'nurse' });
-
-      if(!nurse){
-        return res.status(404).json({ message: 'Nurse not found'});
-      }
-
-      res.json({ message: 'Nurse deleted successfully'});
-    } catch(error){
-        res.status(500).json({ message: err.message});
-    }
-};
-
-export { 
-    createNurse,
-    changePassword,
-    getNurses,
-    updateNurse,
-    deleteNurse
-};
+}

src/services/doctor.service.js

@@ -14,7 +14,7 @@ const createDoctor = async (data) => {
     return await doctor.save();
 };
 
-const changePassword = async (oldPassword, newPassword) => {
+const changePassword = async (userId, oldPassword, newPassword) => {
     const doctor = await User.findById(userId);
     if(!doctor) throw new Error('Doctor not found');
 

src/services/lab.service.js

@@ -15,7 +15,7 @@ const createLabtechnician = async (data) => {
         return await technician.save();
 };
 
-const changePassword = async (oldPassword, newPassword) => {
+const changePassword = async (userId,oldPassword, newPassword) => {
     const technician = await User.findById(userId);
     if(!technician) throw new Error('Lab technician not found');
 

src/services/nurse.service.js

@@ -0,0 +1,63 @@
+import User from '../models/User.js';
+import bcrypt from 'bcrypt';
+
+const createNurse = async (data) => {
+    const password = data.password || 'nurse@123';
+    const hashedPassword = await bcrypt.hash(password, 10);
+
+    const nurse = new User ({
+        ...data,
+        password :hashedPassword,
+        role: 'nurse',
+    });
+
+    return await nurse.save();
+};
+
+const changePassword = async (userId, oldPassword, newPassword) => {
+    const nurse = await User.findById(userId);
+    if(!nurse) throw new Error('Nurse not found');
+
+    const isMatch = await bcrypt.compare(oldPassword, nurse.password);
+    if(!isMatch) throw new Error('Old password is incorrect');
+
+    nurse.password = await bcrypt.hash(newPassword, 10);
+    await nurse.save();
+
+    return { message: 'Password changed successfully' };
+};
+
+const getNurses = async () => {
+    return await User.find({ role: 'nurse' });
+};
+
+const updateNurse = async (id, data) => {
+    if(data.password) {
+        data.password = await bcrypt.hash(data.password, 10);
+    }
+
+    const nurse = await User.findOneAndUpdate(
+        { _id: id, role: 'nurse' },
+        data,
+        { new: true, runValidators: true }, 
+    );
+
+    if(!nurse) throw new Error('Nurse not found');
+
+    return nurse;
+};
+
+const deleteNurse = async (id) => {
+    const nurse = await User.findOneAndDelete({ _id: id, role: 'nurse' });
+    if(!nurse) throw new Error('Nurse not found');
+
+    return { message: 'Nurse deleted successfully' };
+};
+
+export default {
+    createNurse,
+    changePassword,
+    getNurses,
+    updateNurse,
+    deleteNurse
+};