From 36d3b411d65e369ef4dfa2b35c19a92224a22e82 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Fri, 24 Jul 2026 22:25:19 -0700 Subject: [PATCH] Resolve remaining zizmor code scanning alerts Fixes the 9 open alerts at https://github.com/rubyatscale/shared-config/security/code-scanning: - zizmor/ref-version-mismatch (8 alerts): stale version comments on already-pinned SHAs across ci.yml, stale.yml, and zizmor.yml. Floating major tags (v6, v1, v3, v10) move forward as new releases ship, so a comment written when a SHA was "the current v6" goes stale once v6 moves on. Same class of issue already fixed in cd.yml (#27). Updated each comment to the precise version currently tagged at that exact SHA (v7.0.0, v1.314.0, v3.0.3, v10.3.0 respectively) - the pinned SHAs themselves are unchanged. - zizmor/artipacked (1 alert): codeql.yml's checkout step didn't set persist-credentials: false. Unlike cd.yml's deploy job, this one only reads the repo for analysis and never pushes, so disabling persistence is correct here (no exception needed). Verified with `zizmor .github/workflows/`, both offline and --gh-token: 0 findings across every workflow in the repo. --- .github/workflows/ci.yml | 14 +++++++------- .github/workflows/codeql.yml | 2 ++ .github/workflows/stale.yml | 2 +- .github/workflows/zizmor.yml | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 91a1dfc..d9ed8e2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,13 +26,13 @@ jobs: BUNDLE_GEMFILE: Gemfile name: "Run tests: Ruby ${{ matrix.ruby }}" steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 + - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: persist-credentials: false - name: Install ripgrep run: sudo apt-get install -y ripgrep - name: Set up Ruby ${{ matrix.ruby }} - uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1 + uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1.314.0 with: bundler-cache: true ruby-version: ${{ matrix.ruby }} @@ -43,11 +43,11 @@ jobs: name: "Type Check" runs-on: ubuntu-latest steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 + - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: persist-credentials: false - name: Set up Ruby - uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1 + uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1.314.0 with: bundler-cache: true ruby-version: 3.4 @@ -57,11 +57,11 @@ jobs: runs-on: ubuntu-latest name: "Linter" steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 + - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: persist-credentials: false - name: Set up Ruby - uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1 + uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1.314.0 with: bundler-cache: true ruby-version: 3.4 @@ -73,7 +73,7 @@ jobs: needs: [run_tests, static_type_check, run_linter] if: ${{ failure() && github.ref == 'refs/heads/main' }} steps: - - uses: slackapi/slack-github-action@45a88b9581bfab2566dc881e2cd66d334e621e2c # v3 + - uses: slackapi/slack-github-action@45a88b9581bfab2566dc881e2cd66d334e621e2c # v3.0.3 with: webhook: ${{ secrets.SLACK_WEBHOOK_URL }} webhook-type: incoming-webhook diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 9407ab7..68e9b7f 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -29,6 +29,8 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false - name: Initialize CodeQL uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3 diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 25f49ca..563c802 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -6,7 +6,7 @@ jobs: stale: runs-on: ubuntu-latest steps: - - uses: actions/stale@eb5cf3af3ac0a1aa4c9c45633dd1ae542a27a899 # v10 + - uses: actions/stale@eb5cf3af3ac0a1aa4c9c45633dd1ae542a27a899 # v10.3.0 with: stale-issue-message: 'This issue has been marked stale because it has been open for six months with no activity. To prevent this issue from automatically being closed in one week, update it or remove the stale label.' stale-pr-message: 'This PR has been marked stale because it has been open for six months with no activity. To prevent this PR from automatically being closed in one week, update it or remove the stale label.' diff --git a/.github/workflows/zizmor.yml b/.github/workflows/zizmor.yml index 561976b..461b902 100644 --- a/.github/workflows/zizmor.yml +++ b/.github/workflows/zizmor.yml @@ -16,7 +16,7 @@ jobs: contents: read actions: read steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 + - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: persist-credentials: false - name: Run zizmor