Skip to content

Commit 52ca630

Browse files
committed
Update Rubocop and add extensions.
* Added rubocop-performance and rubocop-rake to match RubyZip. * Added Rubocop to the Rakefile.
1 parent 973e555 commit 52ca630

4 files changed

Lines changed: 86 additions & 3 deletions

File tree

.rubocop.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
1+
require:
2+
- rubocop-performance
3+
- rubocop-rake
4+
5+
inherit_from: .rubocop_todo.yml
6+
7+
# Set this to the minimum supported ruby in the gemspec. Otherwise
8+
# we get errors if our ruby version doesn't match.
19
AllCops:
2-
TargetRubyVersion: 2.4
10+
SuggestExtensions: false
11+
TargetRubyVersion: 3.0
12+
NewCops: enable
313

414
Layout/LineLength:
515
Max: 120

.rubocop_todo.yml

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
# This configuration was generated by
2+
# `rubocop --auto-gen-config`
3+
# on 2025-02-08 19:37:20 UTC using RuboCop version 1.61.0.
4+
5+
# Offense count: 7
6+
# Configuration parameters: EnforcedStyle, AllowedGems, Include.
7+
# SupportedStyles: Gemfile, gems.rb, gemspec
8+
# Include: **/*.gemspec, **/Gemfile, **/gems.rb
9+
Gemspec/DevelopmentDependencies:
10+
Exclude:
11+
- 'rubyzip-bzip2.gemspec'
12+
13+
# Offense count: 11
14+
# This cop supports safe autocorrection (--autocorrect).
15+
# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
16+
Layout/LeadingCommentSpace:
17+
Exclude:
18+
- 'lib/zip/bzip2/decompress.rb'
19+
- 'lib/zip/bzip2/decompressor.rb'
20+
- 'lib/zip/bzip2/errors.rb'
21+
- 'lib/zip/bzip2/ffi/libbz2.rb'
22+
- 'lib/zip/bzip2/libbz2.rb'
23+
24+
# Offense count: 2
25+
# This cop supports safe autocorrection (--autocorrect).
26+
# Configuration parameters: EnforcedStyle.
27+
# SupportedStyles: space, no_space
28+
Layout/LineContinuationSpacing:
29+
Exclude:
30+
- 'lib/zip/bzip2/errors.rb'
31+
- 'rubyzip-bzip2.gemspec'
32+
33+
# Offense count: 3
34+
# This cop supports unsafe autocorrection (--autocorrect-all).
35+
Performance/UnfreezeString:
36+
Exclude:
37+
- 'lib/zip/bzip2/decompress.rb'
38+
- 'lib/zip/bzip2/decompressor.rb'
39+
40+
# Offense count: 9
41+
# This cop supports safe autocorrection (--autocorrect).
42+
Style/FileRead:
43+
Exclude:
44+
- 'test/integration/zip_file_bzip2_support_test.rb'
45+
- 'test/integration/zip_input_stream_bzip2_support_test.rb'
46+
- 'test/models/zip/bzip2/decompress_test.rb'
47+
- 'test/models/zip/bzip2/decompressor_test.rb'
48+
- 'test/models/zip/bzip2/libbz2_test.rb'
49+
50+
# Offense count: 1
51+
# Configuration parameters: AllowedMethods.
52+
# AllowedMethods: respond_to_missing?
53+
Style/OptionalBooleanParameter:
54+
Exclude:
55+
- 'lib/zip/bzip2/libbz2.rb'
56+
57+
# Offense count: 1
58+
# This cop supports safe autocorrection (--autocorrect).
59+
Style/RedundantConstantBase:
60+
Exclude:
61+
- 'rubyzip-bzip2.gemspec'
62+
63+
# Offense count: 1
64+
# This cop supports safe autocorrection (--autocorrect).
65+
# Configuration parameters: AllowMultipleReturnValues.
66+
Style/RedundantReturn:
67+
Exclude:
68+
- 'lib/zip/bzip2/decompressor.rb'

Rakefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22

33
require 'bundler/gem_tasks'
44
require 'rake/testtask'
5+
require 'rubocop/rake_task'
6+
7+
task default: :test
58

69
Rake::TestTask.new(:test) do |t|
710
t.libs << 'test'
811
t.libs << 'lib'
912
t.test_files = FileList['test/**/*_test.rb']
1013
end
1114

12-
task default: :test
15+
RuboCop::RakeTask.new

rubyzip-bzip2.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ Gem::Specification.new do |spec|
3939

4040
spec.add_development_dependency 'minitest', '~> 5.15'
4141
spec.add_development_dependency 'rake', '~> 13.2'
42-
spec.add_development_dependency 'rubocop', '~> 0.79.0'
42+
spec.add_development_dependency 'rubocop', '~> 1.61.0'
43+
spec.add_development_dependency 'rubocop-performance', '~> 1.20.0'
44+
spec.add_development_dependency 'rubocop-rake', '~> 0.6.0'
4345
spec.add_development_dependency 'simplecov', '~> 0.18.0'
4446
spec.add_development_dependency 'simplecov-lcov', '~> 0.8'
4547
end

0 commit comments

Comments
 (0)