Changelog #220

Author: lnicola

generated_assists.adoc

@@ -693,7 +693,7 @@ fn main() {
 
 [discrete]
 === `convert_to_guarded_return`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_to_guarded_return.rs#L21[convert_to_guarded_return.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_to_guarded_return.rs#L24[convert_to_guarded_return.rs]
 
 Replace a large conditional with a guarded return.
 
@@ -944,7 +944,7 @@ fn main() {
 
 [discrete]
 === `extract_function`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L39[extract_function.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L37[extract_function.rs]
 
 Extracts selected statements and comments into new function.
 
@@ -977,7 +977,7 @@ fn ┃fun_name(n: i32) {
 
 [discrete]
 === `extract_module`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_module.rs#L32[extract_module.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_module.rs#L30[extract_module.rs]
 
 Extracts a selected region as separate module. All the references, visibility and imports are
 resolved.
@@ -1251,7 +1251,7 @@ impl Default for Example {
 
 [discrete]
 === `generate_delegate_methods`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_delegate_methods.rs#L17[generate_delegate_methods.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_delegate_methods.rs#L15[generate_delegate_methods.rs]
 
 Generate delegate methods.
 
@@ -1681,15 +1681,15 @@ struct Person {
 
 impl Person {
     fn ┃name(&self) -> &str {
-        self.name.as_ref()
+        &self.name
     }
 }
 ```
 
 
 [discrete]
 === `generate_getter_mut`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter_or_setter.rs#L113[generate_getter_or_setter.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter_or_setter.rs#L127[generate_getter_or_setter.rs]
 
 Generate a mut getter method.
 
@@ -1733,9 +1733,7 @@ struct Ctx<T: Clone> {
     data: T,
 }
 
-impl<T: Clone> Ctx<T> {
-    ┃
-}
+impl<T: Clone> Ctx<T> {┃}
 ```
 
 
@@ -1816,7 +1814,7 @@ impl<T> core::ops::Index<Axis> for [T; 3] {
 
 [discrete]
 === `generate_new`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_new.rs#L13[generate_new.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_new.rs#L14[generate_new.rs]
 
 Adds a `fn new` for a type.
 
@@ -1834,7 +1832,9 @@ struct Ctx<T: Clone> {
 }
 
 impl<T: Clone> Ctx<T> {
-    fn ┃new(data: T) -> Self { Self { data } }
+    fn ┃new(data: T) -> Self {
+        Self { data }
+    }
 }
 ```
 
@@ -1928,7 +1928,7 @@ impl<const N: usize> ${0:TraitName}<N> for Foo<N> {
 
 [discrete]
 === `generate_trait_impl`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L56[generate_impl.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L59[generate_impl.rs]
 
 Adds a new trait impl for a type.
 
@@ -1945,9 +1945,7 @@ struct Ctx<T: Clone> {
     data: T,
 }
 
-impl<T: Clone> ┃ for Ctx<T> {
-
-}
+impl<T: Clone> ${0:_} for Ctx<T> {}
 ```
 
 
@@ -2348,7 +2346,7 @@ use std::{fmt::Formatter, io};
 
 [discrete]
 === `merge_match_arms`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/merge_match_arms.rs#L11[merge_match_arms.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/merge_match_arms.rs#L12[merge_match_arms.rs]
 
 Merges the current match arm with the following if their bodies are identical.
 
@@ -3006,7 +3004,7 @@ fn main() {
 
 [discrete]
 === `replace_derive_with_manual_impl`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_derive_with_manual_impl.rs#L18[replace_derive_with_manual_impl.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_derive_with_manual_impl.rs#L20[replace_derive_with_manual_impl.rs]
 
 Converts a `derive` impl into a manual one.
 

generated_config.adoc

@@ -251,6 +251,12 @@ Can be a single target, e.g. `"x86_64-unknown-linux-gnu"` or a list of targets,
 
 Aliased as `"checkOnSave.targets"`.
 --
+[[rust-analyzer.check.workspace]]rust-analyzer.check.workspace (default: `true`)::
++
+--
+Whether `--workspace` should be passed to `cargo check`.
+If false, `-p <package>` will be passed instead.
+--
 [[rust-analyzer.completion.autoimport.enable]]rust-analyzer.completion.autoimport.enable (default: `true`)::
 +
 --
@@ -745,6 +751,11 @@ Sets the LRU capacity of the specified queries.
 --
 Whether to show `can't find Cargo.toml` error message.
 --
+[[rust-analyzer.notifications.unindexedProject]]rust-analyzer.notifications.unindexedProject (default: `false`)::
++
+--
+Whether to send an UnindexedProject notification to the client.
+--
 [[rust-analyzer.numThreads]]rust-analyzer.numThreads (default: `null`)::
 +
 --

generated_diagnostic.adoc

@@ -124,6 +124,20 @@ module.
 This diagnostic is triggered if the accessed field is not visible from the current module.
 
 
+=== remove-trailing-return
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/remove_trailing_return.rs#L8[remove_trailing_return.rs]
+
+This diagnostic is triggered when there is a redundant `return` at the end of a function
+or closure.
+
+
+=== remove-unnecessary-else
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/remove_unnecessary_else.rs#L14[remove_unnecessary_else.rs]
+
+This diagnostic is triggered when there is an `else` block for an `if` expression whose
+then branch diverges (e.g. ends with a `return`, `continue`, `break` e.t.c).
+
+
 === replace-filter-map-next-with-find-map
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/replace_filter_map_next_with_find_map.rs#L11[replace_filter_map_next_with_find_map.rs]
 

generated_features.adoc

@@ -223,7 +223,7 @@ image::https://user-images.githubusercontent.com/48062697/113020654-b42fc800-917
 
 
 === Find All References
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/references.rs#L44[references.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/references.rs#L42[references.rs]
 
 Shows all references of the item at the cursor location
 
@@ -414,6 +414,7 @@ There are postfix completions, which can be triggered by typing something like
 - `expr.ref` -> `&expr`
 - `expr.refm` -> `&mut expr`
 - `expr.let` -> `let $0 = expr;`
+- `expr.lete` -> `let $1 = expr else { $0 };`
 - `expr.letm` -> `let mut $0 = expr;`
 - `expr.not` -> `!expr`
 - `expr.dbg` -> `dbg!(expr)`

thisweek/_posts/2024-02-12-changelog-220.adoc

@@ -0,0 +1,42 @@
+= Changelog #220
+:sectanchors:
+:experimental:
+:page-layout: post
+
+Commit: commit:c06ca6cff5af0fce63d4a28b33e5d244686cb442[] +
+Release: release:2024-02-12[] (`v0.3.1839`)
+
+== New Features
+
+* pr:16510[] add option to only run `cargo check` on the current package.
+* pr:16502[] add unnecessary else diagnostic.
+* pr:16460[] add trailing return diagnostic.
+* pr:16477[] add incorrect case diagnostics for traits and their associated items.
+* pr:16454[] add `break` and `return` postfix completions.
+* pr:16424[] add support for converting `let` statements to guarded returns.
+* pr:15863[] add `UnindexedProject` notification for LSP clients.
+
+== Fixes
+
+* pr:16487[] (first contribution) improve `Deref` handling in "Generate getter" assist.
+* pr:16509[] render visibility for tuple struct fields.
+* pr:16124[] improve parser error recovery on missing arguments in call expressions.
+* pr:16484[] preserve `where` clause when expanding built-in derive macros.
+* pr:16462[] improve error message when proc-macros have not yet been built.
+* pr:16497[] fix spacing when inlining functions defined in macros.
+* pr:16517[] fix crash inside `filter_unnecessary_bounds` on missing generic parameter.
+
+== Internal Improvements
+
+* pr:16482[] (first contribution) use boxed slice for `Subtree::token_trees`.
+* pr:16503[] move `salsa` fork in-tree.
+* pr:16505[] optimize input queries that take no arguments.
+* pr:16527[] remove hack for self-referential ``SyntaxContext``s.
+* pr:16467[] migrate assists to the structured snippet API, part 6.
+* pr:16474[] instrument more paths using `tracing`.
+* pr:16499[] bump `rustc_pattern_analysis`.
+* pr:16525[] abstract more over `ItemTreeLoc`-like structs.
+* pr:16470[] lint against debug prints and disallowed types using Clippy.
+* pr:16500[] run Clippy on Windows, not Linux.
+* pr:16518[], pr:16519[], pr:16521[] enable more Clippy lints.
+* pr:16492[], pr:16532[] sync from downstream.