Changelog #123

Author: lnicola

generated_assists.adoc

@@ -1020,9 +1020,9 @@ pub fn my_func(a: i32, b: i32) -> Result<(), std::io::Error> {
 
 [discrete]
 === `generate_enum_as_method`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_projection_method.rs#L55[generate_enum_projection_method.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_projection_method.rs#L56[generate_enum_projection_method.rs]
 
-Generate an `as_` method for an enum variant.
+Generate an `as_` method for this enum variant.
 
 .Before
 ```rust
@@ -1053,9 +1053,9 @@ impl Value {
 
 [discrete]
 === `generate_enum_is_method`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_is_method.rs#L10[generate_enum_is_method.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_is_method.rs#L11[generate_enum_is_method.rs]
 
-Generate an `is_` method for an enum variant.
+Generate an `is_` method for this enum variant.
 
 .Before
 ```rust
@@ -1088,9 +1088,9 @@ impl Version {
 
 [discrete]
 === `generate_enum_try_into_method`
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_projection_method.rs#L11[generate_enum_projection_method.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_enum_projection_method.rs#L12[generate_enum_projection_method.rs]
 
-Generate an `try_into_` method for an enum variant.
+Generate a `try_into_` method for this enum variant.
 
 .Before
 ```rust
@@ -1123,7 +1123,7 @@ impl Value {
 === `generate_from_impl_for_enum`
 **Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/generate_from_impl_for_enum.rs#L6[generate_from_impl_for_enum.rs]
 
-Adds a From impl for an enum variant with one tuple field.
+Adds a From impl for this enum variant with one tuple field.
 
 .Before
 ```rust
@@ -2445,6 +2445,26 @@ use std::fmt::Display;
 ```
 
 
+[discrete]
+=== `unnecessary_async`
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/unnecessary_async.rs#L15[unnecessary_async.rs]
+
+Removes the `async` mark from functions which have no `.await` in their body.
+Looks for calls to the functions and removes the `.await` on the call site.
+
+.Before
+```rust
+pub async f┃n foo() {}
+pub async fn bar() { foo().await }
+```
+
+.After
+```rust
+pub fn foo() {}
+pub async fn bar() { foo() }
+```
+
+
 [discrete]
 === `unwrap_block`
 **Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_assists/src/handlers/unwrap_block.rs#L11[unwrap_block.rs]

generated_config.adoc

@@ -558,3 +558,10 @@ Workspace symbol search scope.
 --
 Workspace symbol search kind.
 --
+[[rust-analyzer.workspace.symbol.search.limit]]rust-analyzer.workspace.symbol.search.limit (default: `128`)::
++
+--
+Limits the number of items returned from a workspace symbol search (Defaults to 128).
+Some clients like vs-code issue new searches on result filtering and don't require all results to be returned in the initial search.
+Other clients requires all results upfront and might require a higher limit.
+--

generated_diagnostic.adoc

@@ -82,7 +82,7 @@ This diagnostic is triggered when `.filter_map(..).next()` is used, rather than
 
 
 === type-mismatch
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_diagnostics/src/handlers/type_mismatch.rs#L14[type_mismatch.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_diagnostics/src/handlers/type_mismatch.rs#L11[type_mismatch.rs]
 
 This diagnostic is triggered when the type of an expression does not match
 the expected type.

generated_features.adoc

@@ -55,9 +55,9 @@ In `VS Code` the configuration for this is `rust-analyzer.assist.importGranulari
 The style of imports in the same crate is configurable through the `importPrefix` setting.
 It has the following configurations:
 
-- `by_crate`: This setting will force paths to be always absolute, starting with the `crate`
+- `crate`: This setting will force paths to be always absolute, starting with the `crate`
  prefix, unless the item is defined outside of the current crate.
-- `by_self`: This setting will force paths that are relative to the current module to always
+- `self`: This setting will force paths that are relative to the current module to always
  start with `self`. This will result in paths that always start with either `crate`, `self`,
  `super` or an extern crate identifier.
 - `plain`: This setting does not impose any restrictions in imports.
@@ -68,7 +68,7 @@ image::https://user-images.githubusercontent.com/48062697/113020673-b85be580-917
 
 
 === Completion With Autoimport
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_completion/src/completions/flyimport.rs#L18[flyimport.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_completion/src/completions/flyimport.rs#L17[flyimport.rs]
 
 When completing names in the current scope, proposes additional imports from other modules or crates,
 if they can be qualified in the scope, and their name contains all symbols from the completion input.
@@ -378,7 +378,7 @@ image::https://user-images.githubusercontent.com/48062697/113020661-b6922200-917
 
 
 === Magic Completions
-**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_completion/src/lib.rs#L37[lib.rs]
+**Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_completion/src/lib.rs#L39[lib.rs]
 
 In addition to usual reference completion, rust-analyzer provides some ✨magic✨
 completions as well:

manual.adoc

@@ -310,7 +310,7 @@ nvim_lsp.rust_analyzer.setup({
         ["rust-analyzer"] = {
             assist = {
                 importGranularity = "module",
-                importPrefix = "by_self",
+                importPrefix = "self",
             },
             cargo = {
                 loadOutDirsFromCheck = true

thisweek/_posts/2022-04-04-changelog-123.adoc

@@ -0,0 +1,52 @@
+= Changelog #123
+:sectanchors:
+:page-layout: post
+
+Commit: commit:46d7ee68f26285db26b2640f2c07d6332380c756[] +
+Release: release:2022-04-04[]
+
+== Sponsors
+
+**Become a sponsor:** On https://opencollective.com/rust-analyzer/[OpenCollective] or
+https://github.com/sponsors/rust-analyzer[GitHub Sponsors].
+
+== New Features
+
+* pr:11699[] (first contribution) add assist to remove unneeded ``async``s:
++
+video::https://user-images.githubusercontent.com/308347/161477319-ba66afa6-c532-49e2-9c02-905c28c18d0b.mp4[options=loop]
+* pr:11879[] suggest inferred types in completion (add `:` and trigger it manually):
++
+video::https://user-images.githubusercontent.com/308347/161476343-a8d70387-3d45-4653-8a4e-2a1aff23e017.mp4[options=loop]
+* pr:10802[] allow clients to configure the global workspace search limit.
+
+== Fixes
+
+* pr:11869[] (first contribution) allow tildes as code block fences:
++
+image::https://user-images.githubusercontent.com/26626194/161207693-8e39997c-9ca6-4e69-8c65-e9b70899f7db.png[]
+* pr:11866[] (first contribution) avoid underflows in range conversion.
+* pr:11857[], pr:11886[] decrease relevance of postfix completions.
+* pr:11840[] fix another const generic panic.
+* pr:11842[] fix duplicate type mismatches with blocks.
+* pr:11844[] fix divergence detection for bare match arms.
+* pr:11852[] expand `asm!` to infinite loops to improve type inference.
+* pr:11863[] allow varargs in any param position.
+* pr:11870[] recover from missing type annotation.
+* pr:11878[] paper over GAT panic.
+* pr:11881[] don't rely on lang items to find primitive impls.
+* pr:11877[] don't add `self` when splitting glob imports.
+* pr:11887[] add missing fields diagnostic fix for patterns.
+* pr:11865[] select correct insert position for disabled group import.
+
+== Internal Improvements
+
+* pr:11849[] (first contribution) change `by_self` to `self` and `by_crate` to `crate` in docs.
+* pr:11867[], pr:11874[] (first contribution) create `Generate is, as, try_into` assist group.
+* pr:11861[] add `View file text` command to debug sync issues.
+* pr:11827[] enforce invariant that `Resolver` always contains a `ModuleScope`.
+* pr:11871[] move `rust.ungram` into `rust-analyzer/crates/syntax`.
+* pr:11872[] remove `PathResolution::AssocItem`.
+* pr:11875[] simplify completion.
+* pr:11882[] record outline child modules with missing backing file in def map.
+* pr:11890[] delete `FUNDING.yml`.