Changelog #139

Author: lnicola

generated_assists.adoc

@@ -328,7 +328,7 @@ fn main() {
 
 [discrete]
 === `convert_for_loop_with_for_each`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_iter_for_each_to_for.rs#L73[convert_iter_for_each_to_for.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_iter_for_each_to_for.rs#L76[convert_iter_for_each_to_for.rs]
 
 Converts a for loop into a for_each loop on the Iterator.
 
@@ -849,7 +849,7 @@ fn foo<T: Copy + Clone>() { }
 
 [discrete]
 === `generate_constant`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_constant.rs#L12[generate_constant.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_constant.rs#L13[generate_constant.rs]
 
 Generate a named constant.
 
@@ -1100,7 +1100,7 @@ impl S {
 
 [discrete]
 === `generate_enum_as_method`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_enum_projection_method.rs#L56[generate_enum_projection_method.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_enum_projection_method.rs#L59[generate_enum_projection_method.rs]
 
 Generate an `as_` method for this enum variant.
 
@@ -1402,7 +1402,7 @@ impl MyStruct {
 === `generate_new`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_new.rs#L13[generate_new.rs]
 
-Adds a new inherent impl for a type.
+Adds a `fn new` for a type.
 
 .Before
 ```rust
@@ -1959,7 +1959,7 @@ fn main() {
 
 [discrete]
 === `qualify_method_call`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/qualify_method_call.rs#L13[qualify_method_call.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/qualify_method_call.rs#L10[qualify_method_call.rs]
 
 Replaces the method call with a qualified function call.
 

generated_diagnostic.adoc

@@ -38,7 +38,7 @@ This diagnostic is shown when the derive attribute has invalid input.
 
 
 === mismatched-arg-count
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L10[mismatched_arg_count.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L8[mismatched_arg_count.rs]
 
 This diagnostic is triggered if a function is invoked with an incorrect amount of arguments.
 

generated_features.adoc

@@ -384,7 +384,7 @@ image::https://user-images.githubusercontent.com/48062697/113020661-b6922200-917
 
 
 === Magic Completions
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-completion/src/lib.rs#L43[lib.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-completion/src/lib.rs#L45[lib.rs]
 
 In addition to usual reference completion, rust-analyzer provides some ✨magic✨
 completions as well:
@@ -765,7 +765,7 @@ image::https://user-images.githubusercontent.com/48062697/113065584-05f34500-91b
 
 
 === Structural Search and Replace
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-ssr/src/lib.rs#L6[lib.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-ssr/src/lib.rs#L8[lib.rs]
 
 Search and replace with named wildcards that will match any expression, type, path, pattern or item.
 The syntax for a structural search replace command is `<search_pattern> ==>> <replace_pattern>`.
@@ -846,7 +846,7 @@ A custom snippet can be defined by adding it to the `rust-analyzer.completion.sn
       "body": [
         "thread::spawn(move || {",
         "\t$0",
-        ")};",
+        "});",
       ],
       "description": "Insert a thread::spawn call",
       "requires": "std::thread",

thisweek/_posts/2022-07-25-changelog-139.adoc

@@ -0,0 +1,59 @@
+= Changelog #139
+:sectanchors:
+:page-layout: post
+
+Commit: commit:7e2b983fd459977e11026683ee4afb9598960a4c[] +
+Release: release:2022-07-25[]
+
+== New Features
+
+* pr:12549[], pr:12841[] make `Go to implementation` work on trait methods:
++
+video::https://user-images.githubusercontent.com/308347/180722666-15962825-02b8-4b8e-b3e1-a86dbfefa369.mp4[options=loop]
+* pr:12286[] don't ignore the path prefix in `Generate constant`:
++
+video::https://user-images.githubusercontent.com/10148927/168710096-59d5c594-0e4a-4ba7-bfb3-21c4b99409ea.mov[options=loop]
++
+video::https://user-images.githubusercontent.com/10148927/168710111-cd6d3df4-58eb-4358-ae9e-791bfc408efa.mov[options=loop]
+* pr:12798[] drop support for the 1.47–1.58 proc macro ABIs.
+* pr:12795[] add support for the 1.64 nightly proc macro ABI.
+* pr:12859[] don't highlight the whole fn on return-type mismatch.
+
+== Fixes
+
+* pr:12821[] (first contribution) don't generate default `PartialEq::ne`.
+* pr:12811[] (first contribution) insert `pub(crate)` after doc comments and attribute macros.
+* pr:12863[] fix missing fields check on destructuring assignment.
+* pr:12809[] work around Code bug with empty diagnostics.
+* pr:12789[] prevent panic on overlapping ranges in `Remove Unused Parameter`.
+* pr:12788[] fix `Extract variable` for subexpression with mutable borrow.
+* pr:12646[] escape receiver texts in completion
+* pr:12825[] make searching for associated trait items consistent.
+* pr:12844[] improve syntax highlighting in attributes
+* pr:12847[] don't duplicate language clients in `Restart server`.
+* pr:12850[] fix error tooltip message for VSCode status bar item.
+* pr:12851[] don't add braces to 'if' completion in match guard position.
+* pr:12832[] don't try to implement default members.
+* pr:12861[] include receiver in struct field autocomplete.
+* pr:12807[] add basic support for completion item details.
+* pr:12804[] clarify `rust-analyzer.files.watcher` and add enum variants for it.
+* pr:12796[] use `to_owned` instead of `to_string` in `&str to String`.
+
+== Internal Improvements
+
+* pr:12827[] construct fewer ``AstIdMap``s while lowering.
+* pr:12840[] use `ItemTree` for variant, field and module attribute collection in `attrs_query`.
+* pr:12849[] don't parse files unnecessarily in scope_for_offset.
+* pr:12800[] find original AST node before calling `compute_ref_match`.
+* pr:12817[] bump `expect-test` and set `CARGO_WORKSPACE_DIR`.
+* pr:12826[] enable (and fix) extra lint groups required for building inside `rust-lang/rust`.
+* pr:12828[] rename proc macro server from `Rustc` to `RustAnalyzer`.
+* pr:12829[] remove `check_merge_commits` test.
+* pr:12831[] build `proc-macro-test-impl` out-of-tree.
+* pr:12833[] add `proc-macro-srv` integration test that clones literals.
+* pr:12834[] add `PROC_MACRO_TEST_TOOLCHAIN` environment variable.
+* pr:12835[] introduce `proc-macro-srv/sysroot-abi` feature.
+* pr:12854[] fix `generate_new` description.
+
+== Others
+