Document how to make the library Send in README.md#318
Open
Internal-Compiler-Error wants to merge 2 commits into
Open
Document how to make the library Send in README.md#318Internal-Compiler-Error wants to merge 2 commits into
Send in README.md#318Internal-Compiler-Error wants to merge 2 commits into
Conversation
adamreichold
reviewed
Jun 8, 2026
| ``` | ||
|
|
||
| ### Using the library across threads | ||
| By default, many types of this library are `!Send` due to some internal data |
Member
There was a problem hiding this comment.
I think we can be explicit here that this is due to the Tendril type used by the html5ever crate as this is also the only thing the feature flag will affect.
There was a problem hiding this comment.
Sure, this next commit is more clear about this.
Although this got me wondering, why list Tendril as a dependency when html5ever basically exposes as a module? Won't using the bundled version stop you from worrying about their compatibility?
Internal-Compiler-Error
force-pushed
the
master
branch
from
faf2466 to
b5d7fd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had been using the library along with tokio but always found the
Htmltype wasn'tSendannoying. Turns out a feature flag already existed that solved my problem but wasn't documented. This just documents it.