W-22550508: prevent SOQL injection in assign_permission_set#461
Open
jag-j wants to merge 2 commits into
Open
Conversation
Fixes W-22550508 This commit addresses a high-severity SOQL injection vulnerability in the assign_permission_set tool where usernames were interpolated directly into SOQL queries without validation or escaping. Vulnerability: The onBehalfOf parameter allowed injection via malformed usernames like: "x@example.com' OR IsActive = true OR Username='x" This could change the query predicate and assign permissions to unintended users. Changes: - Created soqlUtils.ts with validation functions for usernames - Added validateAndEscapeUsername() to validate email format and detect injection - Added containsSqlInjectionPatterns() to detect SQL keywords and patterns - Applied validation before SOQL query construction in assign_permission_set.ts - Added comprehensive unit tests including POC from security report Security improvements: - Validates strict email format (something@domain.tld) - Blocks SQL keywords (OR, AND, UNION, SELECT, DROP, etc.) - Blocks SQL comments (--) and terminators (;) - Escapes single quotes in valid usernames - Returns clear error messages for invalid input Testing: - 100+ test cases covering valid usernames, injection attempts, and edge cases - Explicitly tests the POC from W-22550508 - Validates legitimate usernames pass through safely Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-22550508@
This commit addresses a high-severity SOQL injection vulnerability in the assign_permission_set tool where usernames were interpolated directly into SOQL queries without validation or escaping.
Vulnerability:
The onBehalfOf parameter allowed injection via malformed usernames like:
"x@example.com' OR IsActive = true OR Username='x"
This could change the query predicate and assign permissions to unintended users.
Changes:
Security improvements:
Testing:
What does this PR do?
What issues does this PR fix or reference?