resolve shellcheck issues

Author: sameersbn

.circleci/config.yml

@@ -281,7 +281,7 @@ workflows:
     jobs:
       - shellcheck/check:
           name: shellcheck
-          ignore: SC2086,SC2181
+          ignore: SC2086,SC2181,SC2124
           filters:
             tags:
               only: /^([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*))?(?:\+[0-9A-Za-z-]+)?$/

entrypoint.sh

@@ -1,14 +1,16 @@
 #!/bin/bash
 set -e
-source ${PG_APP_HOME}/functions
+
+# shellcheck source=runtime/functions
+source "${PG_APP_HOME}/functions"
 
 [[ ${DEBUG} == true ]] && set -x
 
 # allow arguments to be passed to postgres
 if [[ ${1:0:1} = '-' ]]; then
   EXTRA_ARGS="$@"
   set --
-elif [[ ${1} == postgres || ${1} == $(which postgres) ]]; then
+elif [[ ${1} == postgres || ${1} == $(command -v postgres) ]]; then
   EXTRA_ARGS="${@:2}"
   set --
 fi
@@ -27,8 +29,8 @@ if [[ -z ${1} ]]; then
   configure_postgresql
 
   echo "Starting PostgreSQL ${PG_VERSION}..."
-  exec start-stop-daemon --start --chuid ${PG_USER}:${PG_USER} \
-    --exec ${PG_BINDIR}/postgres -- -D ${PG_DATADIR} ${EXTRA_ARGS}
+  exec start-stop-daemon --start --chuid "${PG_USER}:${PG_USER}" \
+    --exec "${PG_BINDIR}/postgres" -- -D "${PG_DATADIR}" ${EXTRA_ARGS}
 else
   exec "$@"
 fi