Improve scenario test interaction (#259)

* scenario test listing as property

* fix get scenario test

* fix scenario_tests usage

* fix docstring

Author: pfmark

cli/tests.py

@@ -32,7 +32,7 @@ def list_tests():
     console = Console()
     with console.status("Finding your Scenario Tests", spinner="dots4"):
         client = init_client()
-        scenario_tests = client.validate.list_scenario_tests()
+        scenario_tests = client.validate.scenario_tests
         table = Table(
             Column("id", overflow="fold", min_width=24),
             "Name",
@@ -73,7 +73,7 @@ def describe_test(scenario_test_id, all):
     # scenario_test = client.validate.get_scenario_test(scenario_test_id)
     assert scenario_test_id or all, "Must pass a scenario_test_id or --all"
     client = init_client()
-    scenario_tests = client.validate.list_scenario_tests()
+    scenario_tests = client.validate.scenario_tests
     if all:
         tree = Tree(":chart_with_upwards_trend: All Scenario Tests")
         with Live(

nucleus/validate/client.py

@@ -92,9 +92,10 @@ def get_scenario_test(self, scenario_test_id: str) -> ScenarioTest:
         response = self.connection.get(
             f"validate/scenario_test/{scenario_test_id}",
         )
-        return ScenarioTest(response["id"], self.connection)
+        return ScenarioTest(response["unit_test"]["id"], self.connection)
 
-    def list_scenario_tests(self) -> List[ScenarioTest]:
+    @property
+    def scenario_tests(self) -> List[ScenarioTest]:
         """Lists all Scenario Tests of the current user. ::
 
             import nucleus
@@ -103,7 +104,7 @@ def list_scenario_tests(self) -> List[ScenarioTest]:
                 "sample_scenario_test", "slc_bx86ea222a6g057x4380"
             )
 
-            client.validate.list_scenario_tests()
+            client.validate.scenario_tests
 
         Returns:
             A list of ScenarioTest objects.
@@ -121,7 +122,7 @@ def delete_scenario_test(self, scenario_test_id: str) -> bool:
 
             import nucleus
             client = nucleus.NucleusClient("YOUR_SCALE_API_KEY")
-            scenario_test = client.validate.list_scenario_tests()[0]
+            scenario_test = client.validate.scenario_tests[0]
 
             success = client.validate.delete_scenario_test(scenario_test.id)
 

nucleus/validate/scenario_test.py

@@ -98,7 +98,7 @@ def get_criteria(self) -> List[ScenarioTestMetric]:
 
             import nucleus
             client = nucleus.NucleusClient("YOUR_SCALE_API_KEY")
-            scenario_test = client.validate.list_scenario_tests()[0]
+            scenario_test = client.validate.scenario_tests[0]
 
             scenario_test.get_criteria()
 
@@ -118,7 +118,7 @@ def get_eval_history(self) -> List[ScenarioTestEvaluation]:
 
             import nucleus
             client = nucleus.NucleusClient("YOUR_SCALE_API_KEY")
-            scenario_test = client.validate.list_scenario_tests()[0]
+            scenario_test = client.validate.scenario_tests[0]
 
             scenario_test.get_eval_history()
 

tests/validate/test_scenario_test.py

@@ -37,7 +37,7 @@ def test_list_scenario_test(CLIENT, test_slice, annotations):
         evaluation_criteria=[e.bbox_iou() > 0.5],
     )
 
-    scenario_tests = CLIENT.validate.list_scenario_tests()
+    scenario_tests = CLIENT.validate.scenario_tests
     assert all(
         isinstance(scenario_test, ScenarioTest)
         for scenario_test in scenario_tests