update the tests

Author: Roxanne Farhad

src/agentex/lib/sdk/config/environment_config.py

@@ -118,7 +118,7 @@ def get_config_for_env(self, env_name: str) -> AgentEnvironmentConfig:
             )
         return self.environments[env_name]
 
-    def get_configs_for_env(self, env: str) -> List[AgentEnvironmentConfig]:
+    def get_configs_for_env(self, env: str) -> dict[str, AgentEnvironmentConfig]:
         """Get configuration for a specific environment based on the expected mapping.
         The environment is either:
         1. explicitly specified like so using a key-map in the environments conifg:
@@ -154,15 +154,15 @@ def get_configs_for_env(self, env: str) -> List[AgentEnvironmentConfig]:
         Raises:
             ValueError: If environment is not found
         """
-        envs_to_deploy = []
+        envs_to_deploy = {}
         if env in self.environments:
             # this supports if the top-level key is just "dev, staging, etc" and matches
             # the environment name exactly without any explicit mapping
-            envs_to_deploy.append(self.environments[env])
+            envs_to_deploy[env] = self.environments[env]
 
-        for _, config in self.environments.items():
+        for env_name, config in self.environments.items():
             if config.environment == env:
-                envs_to_deploy.append(config)
+                envs_to_deploy[env_name] = config
 
         if len(envs_to_deploy) == 0:
             available_envs = [env.environment for env in self.environments.values() if env.environment] + [

tests/lib/cli/test_environment_config.py

@@ -93,21 +93,25 @@ def test_get_config_by_specific_cluster_name(self, multi_cluster_same_env_config
         assert result is not None
 
     def test_get_configs_without_explicit_mapping(self, single_env_config: AgentEnvironmentsConfig):
-        """Test getting config without explicit mapping"""
-
+        """Test getting config without explicit mapping returns a dict with env name as key."""
         result = single_env_config.get_configs_for_env("dev")
+        assert isinstance(result, dict)
         assert len(result) == 1
-        assert result[0] == single_env_config.get_config_for_env("dev")
+        assert "dev" in result
+        assert result["dev"] == single_env_config.get_config_for_env("dev")
 
     def test_multiple_envs_same_keyword_returns_multiple(self, multi_cluster_same_env_config: AgentEnvironmentsConfig):
         """Test that querying 'dev' when multiple envs have environment='dev' returns multiple.
 
-        This documents current behavior - may need to change based on design decision.
+        Returns a dict mapping env names (dev-aws, dev-gcp) to their configs.
         """
         result = multi_cluster_same_env_config.get_configs_for_env("dev")
-        # Current implementation returns a list
-        assert isinstance(result, list)
-        assert len(result) >= 1
+        assert isinstance(result, dict)
+        assert len(result) == 2
+        assert "dev-aws" in result
+        assert "dev-gcp" in result
+        assert result["dev-aws"].kubernetes.namespace == "dev-ns-aws"
+        assert result["dev-gcp"].kubernetes.namespace == "dev-ns-gcp"
 
     def test_list_environments(self, multi_env_config: AgentEnvironmentsConfig):
         """Test listing all environment names."""