fix(tracing): satisfy pyright in obs-correlation test mocks

Annotate fake ModuleType stubs as Any (pyright rejects attribute assignment
on ModuleType), widen the mock 'record' dicts to dict[str, Any], assert the
Optional resolver returns before unpacking, and narrow span.data with
isinstance before subscripting. Clears the pyright errors failing the lint
job. No behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: NiteshDhanpal

tests/lib/core/tracing/test_obs_ids.py

@@ -2,6 +2,7 @@
 
 import sys
 import types
+from typing import Any
 
 import pytest
 
@@ -87,13 +88,15 @@ class TestIdFormatting:
     def test_ddtrace_ids_formats_w3c_hex(self, monkeypatch):
         ctx = types.SimpleNamespace(trace_id=0xABC, span_id=0xFF)
         tracer = types.SimpleNamespace(current_trace_context=lambda: ctx)
-        fake_ddtrace = types.ModuleType("ddtrace")
-        fake_trace = types.ModuleType("ddtrace.trace")
+        fake_ddtrace: Any = types.ModuleType("ddtrace")
+        fake_trace: Any = types.ModuleType("ddtrace.trace")
         fake_trace.tracer = tracer
         monkeypatch.setitem(sys.modules, "ddtrace", fake_ddtrace)
         monkeypatch.setitem(sys.modules, "ddtrace.trace", fake_trace)
 
-        trace_id, span_id = obs_ids._ddtrace_ids()
+        result = obs_ids._ddtrace_ids()
+        assert result is not None
+        trace_id, span_id = result
         assert trace_id == "00000000000000000000000000000abc"
         assert span_id == "000000000000000000ff"[-16:]  # 16-hex
         assert len(trace_id) == 32 and len(span_id) == 16
@@ -102,18 +105,20 @@ def test_lgtm_ids_formats_w3c_hex(self, monkeypatch):
         span_ctx = types.SimpleNamespace(trace_id=0xABC, span_id=0xFF, is_valid=True)
         current_span = types.SimpleNamespace(get_span_context=lambda: span_ctx)
         fake_trace_mod = types.SimpleNamespace(get_current_span=lambda: current_span)
-        fake_otel = types.ModuleType("opentelemetry")
+        fake_otel: Any = types.ModuleType("opentelemetry")
         fake_otel.trace = fake_trace_mod
         monkeypatch.setitem(sys.modules, "opentelemetry", fake_otel)
 
-        trace_id, span_id = obs_ids._lgtm_ids()
+        result = obs_ids._lgtm_ids()
+        assert result is not None
+        trace_id, span_id = result
         assert trace_id == "00000000000000000000000000000abc"
         assert len(trace_id) == 32 and len(span_id) == 16
 
     def test_ddtrace_ids_none_when_no_context(self, monkeypatch):
         tracer = types.SimpleNamespace(current_trace_context=lambda: None)
-        fake_ddtrace = types.ModuleType("ddtrace")
-        fake_trace = types.ModuleType("ddtrace.trace")
+        fake_ddtrace: Any = types.ModuleType("ddtrace")
+        fake_trace: Any = types.ModuleType("ddtrace.trace")
         fake_trace.tracer = tracer
         monkeypatch.setitem(sys.modules, "ddtrace", fake_ddtrace)
         monkeypatch.setitem(sys.modules, "ddtrace.trace", fake_trace)

tests/lib/core/tracing/test_obs_span.py

@@ -2,6 +2,7 @@
 
 import sys
 import types
+from typing import Any
 from unittest.mock import MagicMock
 
 import pytest
@@ -62,7 +63,7 @@ def end(self):
 
 
 def _install_fake_otel(monkeypatch, *, trace_id=0xABC, span_id=0xFF):
-    record: dict = {"span": None, "attached": [], "detached": []}
+    record: dict[str, Any] = {"span": None, "attached": [], "detached": []}
 
     def start_span(name):
         span = _FakeOtelSpan(name, trace_id, span_id)
@@ -80,7 +81,7 @@ def start_span(name):
         attach=lambda ctx: record["attached"].append(ctx) or object(),
         detach=lambda token: record["detached"].append(token),
     )
-    fake_otel = types.ModuleType("opentelemetry")
+    fake_otel: Any = types.ModuleType("opentelemetry")
     fake_otel.trace = fake_trace
     fake_otel.context = fake_context
     monkeypatch.setitem(sys.modules, "opentelemetry", fake_otel)
@@ -104,7 +105,7 @@ def finish(self):
 
 
 def _install_fake_ddtrace(monkeypatch, *, active=True, trace_id=0xABC, span_id=0xFF):
-    record: dict = {"span": None, "started": []}
+    record: dict[str, Any] = {"span": None, "started": []}
     ctx_obj = object() if active else None
     record["ctx"] = ctx_obj
 
@@ -118,8 +119,8 @@ def start_span(name, child_of=None, activate=False):
         current_trace_context=lambda: ctx_obj,
         start_span=start_span,
     )
-    fake_ddtrace = types.ModuleType("ddtrace")
-    fake_trace = types.ModuleType("ddtrace.trace")
+    fake_ddtrace: Any = types.ModuleType("ddtrace")
+    fake_trace: Any = types.ModuleType("ddtrace.trace")
     fake_trace.tracer = tracer
     monkeypatch.setitem(sys.modules, "ddtrace", fake_ddtrace)
     monkeypatch.setitem(sys.modules, "ddtrace.trace", fake_trace)
@@ -262,6 +263,7 @@ def test_lgtm_business_span_tagged_with_wrapper_ids(self, monkeypatch):
         span = trace.start_span(name="chat_completion")
 
         assert record["span"].name == "chat_completion"  # dedicated named span
+        assert isinstance(span.data, dict)
         assert span.data["obs_trace_id"] == "00000000000000000000000000000111"
         assert span.data["obs_span_id"] == "0000000000000222"
         assert span.trace_id == "task-run-1"  # business id unchanged
@@ -309,6 +311,7 @@ def test_dd_only_business_span_tagged_via_ddtrace(self, monkeypatch):
         span = trace.start_span(name="get_state")
 
         assert record["span"].name == "get_state"
+        assert isinstance(span.data, dict)
         assert span.data["obs_trace_id"] == "00000000000000000000000000000111"
         assert span.data["obs_span_id"] == "0000000000000222"
         assert record["span"].tags == {
@@ -444,7 +447,7 @@ def start_span(name):
         attach=lambda ctx: object(),
         detach=lambda token: None,
     )
-    fake_otel = types.ModuleType("opentelemetry")
+    fake_otel: Any = types.ModuleType("opentelemetry")
     fake_otel.trace = fake_trace
     fake_otel.context = fake_context
     monkeypatch.setitem(sys.modules, "opentelemetry", fake_otel)