From c713d9128f60edca109078f74f1be7c5bc8d11b7 Mon Sep 17 00:00:00 2001 From: Colin Neilens Date: Thu, 12 Nov 2026 10:10:56 -0700 Subject: [PATCH] Pin Windows Winghostty to additive cursor revision Pin Winghostty to 4b48d90fd1c6658dfdaa588f2b2d685e52336030 with matching manifests, exact-pin contracts, current-production fixtures and provenance documentation. Clarify that ruleset 23625510 protects graphcode-host, not the publicly retained cursor branch. Add failure-only process-identity diagnostics without changing strict checks or cleanup. The single admitted V3 VisualBaseline run passed: 41 theme-validator calls, 51 rendered-validator calls and 8 static capture assertions; overlapping result assertions are not additive. The previous intermittent failure remains retained and its cause unresolved/unproven, not fixed. Other passing PreviewCore, ProviderPins, TerminalGate, extracted WindowsShell pin assertions and synthetic CanvasPaint results are V2 source-bound evidence, not V3 reruns. No native qualification or PR evidence is claimed. Signed-off-by: Colin Neilens Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- AGENTS.md | 2 +- Tools/windows/Convert-CanvasPaintArtifact.ps1 | 2 +- Tools/windows/PACKAGING.md | 12 +++++++--- .../Tests/PreviewCore.Qualification.ps1 | 2 +- Tools/windows/Tests/PreviewCore.Tests.ps1 | 2 +- Tools/windows/Tests/TerminalGate.Tests.ps1 | 2 +- Tools/windows/Tests/VisualBaseline.Tests.ps1 | 23 +++++++++++++++++-- Tools/windows/Tests/WindowsShell.Tests.ps1 | 2 +- graphcode-windows/README.md | 2 +- graphcode-windows/provider-pins.json | 2 +- .../spikes/windows-terminal-gate/README.md | 7 ++++-- .../windows-terminal-gate/provider-pins.json | 2 +- 12 files changed, 44 insertions(+), 16 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 6d68be50..ec72608a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -347,7 +347,7 @@ These are the single source of truth. Never silently upgrade one. | Swift | 6.3.3 | `.github/workflows/windows-*.yml` (`swift-version: swift-6.3.3-release`), `Tools/windows/bootstrap.ps1` | | Zig (shell) | 0.15.2 | `mise.toml`, `graphcode-windows/build.zig.zon` (`minimum_zig_version`) | | Zig (zmx only) | 0.16.0 | `graphcode-windows/provider-pins.json` | -| Winghostty | `cac8f5f148fd5015d49e81e169ce9006ac7156ea` | `graphcode-windows/provider-pins.json` | +| Winghostty | `4b48d90fd1c6658dfdaa588f2b2d685e52336030` | `graphcode-windows/provider-pins.json` | | zmx | `785b3fd15dcafd1882b495c831a10f98c201b908` | `graphcode-windows/provider-pins.json` | If a build fails because a tool is missing or the wrong version, rerun diff --git a/Tools/windows/Convert-CanvasPaintArtifact.ps1 b/Tools/windows/Convert-CanvasPaintArtifact.ps1 index 1022b355..3eeeecb5 100644 --- a/Tools/windows/Convert-CanvasPaintArtifact.ps1 +++ b/Tools/windows/Convert-CanvasPaintArtifact.ps1 @@ -980,7 +980,7 @@ namespace GraphCode.PaintArtifactTests osVersion = [Environment]::OSVersion.Version.ToString() platform = [Environment]::OSVersion.Platform.ToString() zigVersion = "0.15.2" - winghosttyPin = "cac8f5f148fd5015d49e81e169ce9006ac7156ea" + winghosttyPin = "4b48d90fd1c6658dfdaa588f2b2d685e52336030" pinEvidenceScope = "Expected repository pins; actual Zig executable and Winghostty checkout identity are not measured by the converter." } dimensions = $receipt.dimensions diff --git a/Tools/windows/PACKAGING.md b/Tools/windows/PACKAGING.md index acc415f5..f1c6a438 100644 --- a/Tools/windows/PACKAGING.md +++ b/Tools/windows/PACKAGING.md @@ -420,7 +420,7 @@ The current accepted public provider commits are: | Provider | Pinned commit | Retained branch | |---|---|---| -| [coneilen/winghostty](https://github.com/coneilen/winghostty/commit/cac8f5f148fd5015d49e81e169ce9006ac7156ea) | `cac8f5f148fd5015d49e81e169ce9006ac7156ea` | `graphcode-host` | +| [coneilen/winghostty](https://github.com/coneilen/winghostty/commit/4b48d90fd1c6658dfdaa588f2b2d685e52336030) | `4b48d90fd1c6658dfdaa588f2b2d685e52336030` | `coneilen-terminal-cursor-rendering` | | [coneilen/zmx](https://github.com/coneilen/zmx/commit/785b3fd15dcafd1882b495c831a10f98c201b908) | `785b3fd15dcafd1882b495c831a10f98c201b908` | `graphcode-quickchat-hang` | The annotated `graphcode-windows-baseline-2026-09-17` tags remain historical @@ -434,9 +434,15 @@ The current zmx commit adopts the named-pipe accept-deadline race fix merged in As verified on 2026-09-17, each fork has an active ruleset forbidding updates or deletion of `refs/tags/graphcode-windows-*`, without bypass actors. Separate -active rulesets prevent deletion and non-fast-forward changes of the branches -above; normal forward development is allowed. The Winghostty tag/branch ruleset +active rulesets prevent deletion and non-fast-forward changes of Winghostty's +`graphcode-host` and zmx's `graphcode-quickchat-hang`; normal forward development +is allowed. The Winghostty tag/branch ruleset IDs are `23625509`/`23625510`; zmx's are `23625508`/`23625511`. +Read-only verification on 2026-11-12 confirmed that Winghostty ruleset `23625510` +matches only `refs/heads/graphcode-host`, while `23625509` matches +`refs/tags/graphcode-windows-*`. The current Winghostty commit is publicly +retained at the exact fork commit and `coneilen-terminal-cursor-rendering` branch +listed above; ruleset `23625510` does not protect that branch. Administrators can still change rulesets or repository availability; these settings are retention controls, not an irrevocable archival guarantee. diff --git a/Tools/windows/Tests/PreviewCore.Qualification.ps1 b/Tools/windows/Tests/PreviewCore.Qualification.ps1 index 46c9c821..55298072 100644 --- a/Tools/windows/Tests/PreviewCore.Qualification.ps1 +++ b/Tools/windows/Tests/PreviewCore.Qualification.ps1 @@ -155,7 +155,7 @@ function Assert-PreviewCoreArtifact($artifact, [string] $source, [string] $hash) foreach ($name in @("metadata", "manifest", "providerProvenance", "shell", "daemon", "cli", "zmx")) { Assert-PreviewCoreHash $artifact.hashes.$name 64 "$name digest" } - Assert-PreviewCore ($artifact.winghosttyCommit -ceq "cac8f5f148fd5015d49e81e169ce9006ac7156ea" -and + Assert-PreviewCore ($artifact.winghosttyCommit -ceq "4b48d90fd1c6658dfdaa588f2b2d685e52336030" -and $artifact.zmxCommit -ceq "785b3fd15dcafd1882b495c831a10f98c201b908") "accepted provider pins changed" } diff --git a/Tools/windows/Tests/PreviewCore.Tests.ps1 b/Tools/windows/Tests/PreviewCore.Tests.ps1 index ceb6e8d2..3f622f72 100644 --- a/Tools/windows/Tests/PreviewCore.Tests.ps1 +++ b/Tools/windows/Tests/PreviewCore.Tests.ps1 @@ -27,7 +27,7 @@ function New-ContractArtifact { tag = "v1.2.3-alpha"; tagCommit = "b" * 40 tagMatchesSource = $true; tagMismatchAllowed = $false signing = "UNSIGNED (not code signed)" - winghosttyCommit = "cac8f5f148fd5015d49e81e169ce9006ac7156ea" + winghosttyCommit = "4b48d90fd1c6658dfdaa588f2b2d685e52336030" zmxCommit = "785b3fd15dcafd1882b495c831a10f98c201b908" hashes = [pscustomobject]$hashes } diff --git a/Tools/windows/Tests/TerminalGate.Tests.ps1 b/Tools/windows/Tests/TerminalGate.Tests.ps1 index 04452b67..8c3a9697 100644 --- a/Tools/windows/Tests/TerminalGate.Tests.ps1 +++ b/Tools/windows/Tests/TerminalGate.Tests.ps1 @@ -239,7 +239,7 @@ foreach ($provider in @("winghostty", "zmx")) { } Assert-Contract ($pins.schemaVersion -eq 1) "provider pin schema is not 1" Assert-Contract ($pins.winghostty.sha -eq - "cac8f5f148fd5015d49e81e169ce9006ac7156ea") "Winghostty SHA is not exact" + "4b48d90fd1c6658dfdaa588f2b2d685e52336030") "Winghostty SHA is not exact" Assert-Contract ($pins.zmx.sha -eq "785b3fd15dcafd1882b495c831a10f98c201b908") "zmx SHA is not exact" Assert-Contract ($pins.winghostty.remoteUrl -eq diff --git a/Tools/windows/Tests/VisualBaseline.Tests.ps1 b/Tools/windows/Tests/VisualBaseline.Tests.ps1 index cc4bd8e9..5a2eadd9 100644 --- a/Tools/windows/Tests/VisualBaseline.Tests.ps1 +++ b/Tools/windows/Tests/VisualBaseline.Tests.ps1 @@ -399,7 +399,7 @@ try { providers = @{ zmx = @{ sha256 = ('4' * 64); pin = '785b3fd15dcafd1882b495c831a10f98c201b908' artifact = '.graphcode-tools\providers\zmx\zig-out\bin\zmx.exe' } - winghostty = @{ sha256 = ('5' * 64); pin = 'cac8f5f148fd5015d49e81e169ce9006ac7156ea' + winghostty = @{ sha256 = ('5' * 64); pin = '4b48d90fd1c6658dfdaa588f2b2d685e52336030' artifact = '.graphcode-tools\providers\winghostty\zig-out\lib\winghostty-win32-host.lib' } } renderer = @{ uiaGate = $false; daemonSupervisorHook = $false } @@ -480,7 +480,26 @@ try { try { $record = @{ pid = $sleeper.Id; executable = $sleeper.Path; commandLine = "$($sleeper.Path) attach fixture" createdAt = $sleeper.StartTime.ToUniversalTime().ToString('o') } - if (-not (Test-CaptureProcessIdentity $sleeper $record)) { throw 'String process timestamp identity failed' } + if (-not (Test-CaptureProcessIdentity $sleeper $record)) { + try { + $postFailureUtc = $sleeper.StartTime.ToUniversalTime() + $diagnostics = [ordered]@{ + scope = 'Original expected record and POST-FAILURE same-held-Process observations; not exact operands inside the earlier failed comparison' + expectedPid = $record.pid + expectedExecutable = $record.executable + expectedUtcTimestamp = $record.createdAt + parsedExpectedUtcTicks = Get-CaptureUtcTicks $record.createdAt + postFailureActualPid = $sleeper.Id + postFailureActualExecutable = $sleeper.Path + postFailureActualUtcTimestamp = $postFailureUtc.ToString('o') + postFailureActualUtcTicks = $postFailureUtc.Ticks + } + Write-Output ("VISUAL_IDENTITY_FAILURE_DIAGNOSTICS " + ($diagnostics | ConvertTo-Json -Compress)) + } catch { + Write-Output ("VISUAL_IDENTITY_FAILURE_DIAGNOSTICS unavailable: " + $_.Exception.Message) + } + throw 'String process timestamp identity failed' + } $parsedRecord = $record | ConvertTo-Json | ConvertFrom-Json if (-not (Test-CaptureProcessIdentity $sleeper $parsedRecord)) { throw 'JSON process timestamp identity failed' } $registry = [Collections.Generic.Dictionary[int,object]]::new() diff --git a/Tools/windows/Tests/WindowsShell.Tests.ps1 b/Tools/windows/Tests/WindowsShell.Tests.ps1 index 2e159ceb..51feafc5 100644 --- a/Tools/windows/Tests/WindowsShell.Tests.ps1 +++ b/Tools/windows/Tests/WindowsShell.Tests.ps1 @@ -785,7 +785,7 @@ $pins = Get-Content -LiteralPath (Join-Path $shellRoot "provider-pins.json") -Ra ConvertFrom-Json Assert-Contract ($pins.schemaVersion -eq 1) "provider pin schema is not 1" Assert-Contract ($pins.winghostty.sha -eq - "cac8f5f148fd5015d49e81e169ce9006ac7156ea") "Winghostty pin changed" + "4b48d90fd1c6658dfdaa588f2b2d685e52336030") "Winghostty pin changed" Assert-Contract ($pins.zmx.sha -eq "785b3fd15dcafd1882b495c831a10f98c201b908") "zmx pin changed" Assert-Contract ($pins.winghostty.remoteUrl -eq diff --git a/graphcode-windows/README.md b/graphcode-windows/README.md index fd5d36de..8a0574b4 100644 --- a/graphcode-windows/README.md +++ b/graphcode-windows/README.md @@ -163,7 +163,7 @@ coverage, antialiasing appearance, or visual parity. ### Terminal VT parser and glyph snapshots The public `libghostty-vt` C API from the existing Winghostty pin -`cac8f5f148fd5015d49e81e169ce9006ac7156ea` is the production default. Set +`4b48d90fd1c6658dfdaa588f2b2d685e52336030` is the production default. Set `GRAPHCODE_EXPERIMENTAL_TERMINAL_VT=0` before startup only as a rollback to the limited legacy parser; an absent variable or exactly `1` enables Ghostty VT. Other values, including an empty value, fail workspace initialization with diff --git a/graphcode-windows/provider-pins.json b/graphcode-windows/provider-pins.json index b502bdfb..97077fed 100644 --- a/graphcode-windows/provider-pins.json +++ b/graphcode-windows/provider-pins.json @@ -3,7 +3,7 @@ "winghostty": { "repository": "coneilen/winghostty", "remoteUrl": "https://github.com/coneilen/winghostty.git", - "sha": "cac8f5f148fd5015d49e81e169ce9006ac7156ea", + "sha": "4b48d90fd1c6658dfdaa588f2b2d685e52336030", "artifact": "zig-out/lib/winghostty-win32-host.lib", "minimumZig": "0.15.2" }, diff --git a/investigation/spikes/windows-terminal-gate/README.md b/investigation/spikes/windows-terminal-gate/README.md index c24c2d3f..85f870e9 100644 --- a/investigation/spikes/windows-terminal-gate/README.md +++ b/investigation/spikes/windows-terminal-gate/README.md @@ -10,7 +10,7 @@ session/ConPTY lifetime. `provider-pins.json` records the accepted provider commits: -- Winghostty `cac8f5f148fd5015d49e81e169ce9006ac7156ea` +- Winghostty `4b48d90fd1c6658dfdaa588f2b2d685e52336030` - zmx `785b3fd15dcafd1882b495c831a10f98c201b908` Both commits are publicly reachable in the `coneilen` provider repositories. @@ -20,7 +20,10 @@ provider source into GraphCode. The annotated `graphcode-windows-baseline-2026-09-17` tags preserve the original baseline sources, including zmx `029e11d2b19162fb3bdf90c8270237d303b8bfb4`, not the current zmx pin. The provider forks protect these tags against -updates/deletion and the dedicated branches against deletion/history rewrites; see +updates/deletion and the `graphcode-host` (Winghostty) and +`graphcode-quickchat-hang` (zmx) branches against deletion/history rewrites. The +current Winghostty commit is publicly retained on `coneilen-terminal-cursor-rendering`; +the recorded Winghostty branch ruleset does not cover that branch. See `Tools\windows\PACKAGING.md` for the recorded ruleset IDs and retention limits. These are source-retention tags, not signed Windows releases. diff --git a/investigation/spikes/windows-terminal-gate/provider-pins.json b/investigation/spikes/windows-terminal-gate/provider-pins.json index 0941613a..96880222 100644 --- a/investigation/spikes/windows-terminal-gate/provider-pins.json +++ b/investigation/spikes/windows-terminal-gate/provider-pins.json @@ -3,7 +3,7 @@ "winghostty": { "repository": "coneilen/winghostty", "remoteUrl": "https://github.com/coneilen/winghostty.git", - "sha": "cac8f5f148fd5015d49e81e169ce9006ac7156ea", + "sha": "4b48d90fd1c6658dfdaa588f2b2d685e52336030", "artifact": "zig-out/lib/winghostty-win32-host.lib", "minimumZig": "0.15.2" },