From 79d2a1069f6648a712ee08ade8f87df12e354b1e Mon Sep 17 00:00:00 2001 From: scgopi Date: Tue, 17 Nov 2026 19:46:14 -0800 Subject: [PATCH] Backport Ghostty's opener-stderr drain fix (#1014) Pin ThirdParty/ghostty to scgopi/ghostty graphcode-patches (ff98ec4), which is the current pin 30e1f3bb plus upstream 3b8141fbd8e2. Without it, an opener that writes a line to stderr leaves openThread spinning on an empty slice forever, one pinned core and a log flood per link opened. Co-Authored-By: Claude Opus 5.5 Signed-off-by: scgopi --- .gitmodules | 6 +++++- ThirdParty/ghostty | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 3baa99e6b..12e17f2df 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,6 +1,10 @@ [submodule "ThirdParty/ghostty"] path = ThirdParty/ghostty - url = https://github.com/ghostty-org/ghostty.git + # A fork of ghostty-org/ghostty because graphcode pins a commit that only exists + # on the fork's `graphcode-patches` branch: upstream's 3b8141f (opener stderr + # drain spins a core forever) backported onto the pinned revision. Drop the fork + # once the pin moves past 3b8141f. + url = https://github.com/scgopi/ghostty.git shallow = true [submodule "ThirdParty/zmx"] path = ThirdParty/zmx diff --git a/ThirdParty/ghostty b/ThirdParty/ghostty index 30e1f3bb8..ff98ec4e8 160000 --- a/ThirdParty/ghostty +++ b/ThirdParty/ghostty @@ -1 +1 @@ -Subproject commit 30e1f3bb8c3d2949e9ae4aefc1c2b76142569cfb +Subproject commit ff98ec4e8ac84a7ee036f150a946a9e6338b0af6