Skip to content

Commit d364a8e

Browse files
committed
Improve PR data extraction.
1 parent 0500faf commit d364a8e

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

site/numpy_timeseries.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,11 @@ tags: [hide-input]
256256
---
257257
258258
with open("../_data/prs.json", "r") as fh:
259-
data = json.loads(fh.read())
259+
prs = [item["node"] for item in json.loads(fh.read())]
260260
```
261261

262+
### Merged PRs over time
263+
262264
A look at merged PRs over time.
263265

264266
% TODO: This data includes backports - in the future, should limit to PRs merged
@@ -270,8 +272,8 @@ tags: [hide-input]
270272
---
271273
# All contributors
272274
273-
merged_prs = [d for d in data if d['node']['state'] == 'MERGED']
274-
merge_dates = np.array([r['node']['mergedAt'] for r in merged_prs], dtype=np.datetime64)
275+
merged_prs = [pr for pr in prs if pr['state'] == 'MERGED']
276+
merge_dates = np.array([pr['mergedAt'] for pr in merged_prs], dtype=np.datetime64)
275277
binsize = np.timedelta64(30, "D")
276278
date_bins = np.arange(merge_dates[0], merge_dates[-1], binsize)
277279
h_all, bedges = np.histogram(merge_dates, date_bins)
@@ -283,7 +285,7 @@ first_time_contributor = []
283285
prev_contrib = set()
284286
for record in merged_prs:
285287
try:
286-
author = record['node']['author']['login']
288+
author = record['author']['login']
287289
except TypeError: # Author no longer has GitHub account
288290
first_time_contributor.append(None)
289291
continue

0 commit comments

Comments
 (0)