JythonAutocompletionProvider.debug: a static integer flag to control the level of debugging messages.

Author: acardona

src/main/java/org/scijava/plugins/scripteditor/jython/JythonAutoCompletions.java

@@ -82,15 +82,17 @@ public List<String> apply(final Path filepath) {
 									.collect(Collectors.toList());
 							return modules;
 						} catch (Exception e) {
-							e.printStackTrace();
+							System.out.println("Failed to load jython module");
+							if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 						} finally {
 							if (null != jar) try { jar.close(); } catch (Exception ee) {}
 						}
 						return Collections.emptyList();
 					}
 				}).findFirst().orElse(Collections.emptyList());
 		} catch (IOException e) {
-			e.printStackTrace();
+			System.out.println("Cannot find jython-slim-*.jar file");
+			if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 		} finally {
 			jython_jar_modules = ls;
 		}
@@ -138,7 +140,7 @@ public List<Completion> completionsFor(final CompletionProvider provider, String
 			JythonScriptParser.print("PYTHONPATH:\n" + String.join("\n", Scope.indexer.getLoadPath()));
 		} catch (Exception e) {
 			System.out.println("Failed to add path from sys.path.append expression.");
-			e.printStackTrace();
+			if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 		}
 
 		// Situations to autocomplete:
@@ -170,7 +172,8 @@ public List<Completion> completionsFor(final CompletionProvider provider, String
 											: s.substring(dir.length(), s.length() -3))  // remove ending ".py"
 											.replace('/', '.'));
 						} catch (IOException e) {
-							e.printStackTrace();
+							System.out.println("Failed to read jython module file.");
+							if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 						}
 						return null;
 					}).flatMap(Function.identity())

src/main/java/org/scijava/plugins/scripteditor/jython/JythonAutocompletionProvider.java

@@ -52,6 +52,15 @@ public class JythonAutocompletionProvider extends DefaultCompletionProvider {
 	private final JythonAutoCompletions autoCompletions = new JythonAutoCompletions();
 	private final RSyntaxTextArea text_area;
 	private final ImportFormat formatter;
+	
+	/** Adjust value to see debgging information, including:
+	 * 0: nothing at all;
+	 * 1: plus information messages;
+	 * 2: plus {@code Exception} stack traces.
+	 * 
+	 * Defaults to 1.
+	 */
+	static public int debug = 1;
 
 	public JythonAutocompletionProvider(final RSyntaxTextArea text_area, final ImportFormat formatter) {
 		this.text_area = text_area;
@@ -109,8 +118,8 @@ public List<Completion> getCompletionsImpl(final JTextComponent comp) {
 			if (cs != null) completions.addAll(cs);
 		}
 		catch (Exception e) {
-			System.out.println("Failed to get autocompletions from " + autoCompletions);
-			e.printStackTrace();
+			if (debug >= 1) System.out.println("Failed to get autocompletions from " + autoCompletions);
+			if (debug >= 2) e.printStackTrace();
 		}
 		// Java class discovery for completions with auto-imports
 		completions.addAll(getCompletions(alreadyEnteredText));
@@ -137,7 +146,7 @@ public List<Completion> getCompletions(final String text) {
 			final String packageName = m2.group(3);
 			String className = m2.group(4); // incomplete or empty, or multiple separated by commas with the last one incomplete or empty
 
-			System.out.println("m2 matches className: " + className);
+			if (debug >= 2) System.out.println("m2 matches className: " + className);
 			final String[] bycomma = className.split(",");
 			String precomma = "";
 			if (bycomma.length > 1) {
@@ -267,7 +276,7 @@ private String[] getVariableAnSeedAtCaretLocation() {
 			final String[] varAndSeed = words[words.length - 1].split("\\.");
 			return (varAndSeed.length == 2) ? varAndSeed : new String[] { varAndSeed[varAndSeed.length - 1], "" };
 		} catch (final BadLocationException e) {
-			e.printStackTrace();
+			if (debug >= 2) e.printStackTrace();
 		}
 		return null;
 	}

src/main/java/org/scijava/plugins/scripteditor/jython/JythonScriptParser.java

@@ -69,11 +69,8 @@
 import org.python.indexer.types.NModuleType;
 import org.scijava.ui.swing.script.autocompletion.CompletionText;
 
-public class JythonScriptParser {
-	
-	/** Controls whether debugging statements print to stdout. */
-	static public boolean DEBUG = false;
-	
+public class JythonScriptParser
+{	
 	/**
 	 * Parse valid jython code.
 	 * 
@@ -88,7 +85,7 @@ static public Scope parseAST(final String code) {
 			final mod m = ParserFacade.parse(code, CompileMode.exec, "<none>", new CompilerFlags());
 			return parseNode(m.getChildren(), null, null);
 		} catch (Throwable t) {
-			t.printStackTrace();
+			if (JythonAutocompletionProvider.debug >= 2) t.printStackTrace();
 			return new Scope(null);
 		}
 	}
@@ -171,7 +168,7 @@ static public Map<String, DotAutocompletions> parseImportStatement(final Import
 	}
 
 	static private DotAutocompletions maybeStaticToDot(final PythonTree node, final DotAutocompletions da) {
-		System.out.println("children count:" + node.getChildCount() + ", children: " + (null != node.getChildren() ? node.getChildren().stream().map(c -> c.toString()).collect(Collectors.toList()) : ""));
+		print("children count:" + node.getChildCount() + ", children: " + (null != node.getChildren() ? node.getChildren().stream().map(c -> c.toString()).collect(Collectors.toList()) : ""));
 		if (node.getChildCount() > 0 && da instanceof StaticDotAutocompletions) {
 			// It's a right expression (a constructor invocation assigned to a variable on the left) so the left is an instance of the class
 			return new VarDotAutocompletions(da.getClassname());
@@ -198,7 +195,7 @@ static public Map<String, DotAutocompletions> parseAssignStatement(final Assign
 			for (int i=0; i<right.getChildren().size(); ++i) {
 				final CommonTree ct = left.getChildren().get(i).getNode();
 				if (null == ct) {
-					System.out.println("null for left: '" + left + "'" + " at child node " + i);
+					print("null for left: '" + left + "'" + " at child node " + i);
 					continue;
 				}
 				final String name = ct.toString();
@@ -400,6 +397,6 @@ static public DotAutocompletions parseRight(final PyObject right, final Scope sc
 	}
 
 	static public final void print(Object s) {
-		if (DEBUG) System.out.println(s);
+		if (JythonAutocompletionProvider.debug >= 2) System.out.println(s);
 	}
 }

src/main/java/org/scijava/plugins/scripteditor/jython/Scope.java

@@ -112,8 +112,8 @@ static NModuleType loadPythonModule(final String qname) {
 				mod = indexer.loadModule(qname);
 				if (null == mod) return null;
 			} catch (Exception e) {
-				System.out.println("Could not load python module named " + qname);
-				e.printStackTrace();
+				if (JythonAutocompletionProvider.debug >= 1) System.out.println("Could not load python module named " + qname);
+				if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 				return null;
 			}
 			try {
@@ -131,9 +131,11 @@ static NModuleType loadPythonModule(final String qname) {
 					System.out.println("Python module " + qname + " doesn't have an associated file path.");
 				}
 			} catch (Exception e) {
-				System.out.println("Could not load python module named " + qname);
-				System.out.println(e.getMessage());
-				e.printStackTrace();
+				if (JythonAutocompletionProvider.debug >= 1) {
+					System.out.println("Could not load python module named " + qname);
+					System.out.println(e.getMessage());
+				}
+				if (JythonAutocompletionProvider.debug >= 2) e.printStackTrace();
 			}
 			return mod;
 		}