Skip to content

Commit 7f0d6f4

Browse files
ctruedenimagejan
andcommitted
Update JRuby to 9.1.17.0
This requires JRubyTest to be updated, as the return type of get() is now Long. Note that the 9.2.x versions of JRuby have a more serious breakage: [INFO] Running org.scijava.plugins.scripting.jruby.JRubyTest NoMethodError: undefined method `getLanguageByName' for nil:NilClass <main> at hello.rb:3 [ERROR] null org.jruby.embed.EvalFailedException: (NoMethodError) undefined method `getLanguageByName' for nil:NilClass at org.jruby.embed.internal.EmbedEvalUnitImpl.run(EmbedEvalUnitImpl.java:131) at org.jruby.embed.jsr223.JRubyEngine.eval(JRubyEngine.java:90) at org.jruby.embed.jsr223.JRubyEngine.eval(JRubyEngine.java:142) at org.scijava.script.ScriptModule.run(ScriptModule.java:160) at org.scijava.module.ModuleRunner.run(ModuleRunner.java:168) at org.scijava.module.ModuleRunner.call(ModuleRunner.java:127) at org.scijava.module.ModuleRunner.call(ModuleRunner.java:66) at org.scijava.thread.DefaultThreadService$3.call(DefaultThreadService.java:238) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: org.jruby.exceptions.NoMethodError: (NoMethodError) undefined method `getLanguageByName' for nil:NilClass at RUBY.<main>(hello.rb:3) [ERROR] Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2.78 s <<< FAILURE! - in org.scijava.plugins.scripting.jruby.JRubyTest [ERROR] testParameters(org.scijava.plugins.scripting.jruby.JRubyTest) Time elapsed: 0.14 s <<< FAILURE! java.lang.AssertionError: expected:<Ruby> but was:<null> at org.scijava.plugins.scripting.jruby.JRubyTest.testParameters(JRubyTest.java:97) [ERROR] testLocals(org.scijava.plugins.scripting.jruby.JRubyTest) Time elapsed: 0.011 s <<< FAILURE! java.lang.AssertionError: expected:<17> but was:<null> at org.scijava.plugins.scripting.jruby.JRubyTest.testLocals(JRubyTest.java:77) Co-authored-by: Jan Eglinger <jan.eglinger@fmi.ch>
1 parent 2a05d12 commit 7f0d6f4

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎pom.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.scijava</groupId>
77
<artifactId>pom-scijava</artifactId>
8-
<version>17.1.1</version>
8+
<version>23.2.0</version>
99
<relativePath />
1010
</parent>
1111

@@ -93,7 +93,7 @@ Institute of Molecular Cell Biology and Genetics.</license.copyrightOwners>
9393
<!-- NB: Deploy releases to the ImageJ Maven repository. -->
9494
<releaseProfiles>deploy-to-imagej</releaseProfiles>
9595

96-
<jruby.version>1.7.12</jruby.version>
96+
<jruby.version>9.1.17.0</jruby.version>
9797
<jruby-core.version>${jruby.version}</jruby-core.version>
9898
<jruby-stdlib.version>${jruby.version}</jruby-stdlib.version>
9999
</properties>

‎src/test/java/org/scijava/plugins/scripting/jruby/JRubyTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void testLocals() throws ScriptException {
7575
assertEquals("org.jruby.embed.jsr223.JRubyEngine", engineClassName);
7676
engine.put("hello", 17);
7777
assertEquals(17L, engine.eval("$hello"));
78-
assertEquals(17, engine.get("hello"));
78+
assertEquals(17L, engine.get("hello"));
7979
}
8080

8181
@Test

0 commit comments

Comments
 (0)