change status and reason to *string

Author: wanyufe

api/v1beta2/cloudstackmachine_types.go

@@ -128,11 +128,11 @@ type CloudStackMachineStatus struct {
 
 	// Status indicates the status of the provider resource.
 	// +optional
-	Status string `json:"status"`
+	Status *string `json:"status,omitempty"`
 
 	// Reason indicates the reason of status failure
 	// +optional
-	Reason string `json:"reason"`
+	Reason *string `json:"reason,omitempty"`
 }
 
 // TimeSinceLastStateChange returns the amount of time that's elapsed since the state was last updated.  If the state

api/v1beta2/zz_generated.deepcopy.go

@@ -19,6 +19,7 @@ package controllers
 import (
 	"context"
 	"fmt"
+	"k8s.io/utils/pointer"
 	"math/rand"
 	"reflect"
 	"regexp"
@@ -274,8 +275,8 @@ func (r *CloudStackMachineReconciliationRunner) ReconcileDelete() (retRes ctrl.R
 		// ResolveVMInstanceDetails can get InstanceID by CS machine name
 		err := r.CSClient.ResolveVMInstanceDetails(r.ReconciliationSubject)
 		if err != nil {
-			r.ReconciliationSubject.Status.Status = metav1.StatusFailure
-			r.ReconciliationSubject.Status.Reason = err.Error()
+			r.ReconciliationSubject.Status.Status = pointer.String(metav1.StatusFailure)
+			r.ReconciliationSubject.Status.Reason = pointer.String(err.Error())
 			// Cloudstack VM may be not found or more than one found by name
 			return ctrl.Result{}, err
 		}

controllers/cloudstackmachine_controller.go

@@ -282,7 +282,7 @@ func (c *client) GetOrCreateVMInstance(
 		return err
 	}
 	csMachine.Spec.InstanceID = pointer.StringPtr(deployVMResp.Id)
-	csMachine.Status.Status = metav1.StatusSuccess
+	csMachine.Status.Status = pointer.String(metav1.StatusSuccess)
 	// Resolve uses a VM metrics request response to fill cloudstack machine status.
 	// The deployment response is insufficient.
 	return c.ResolveVMInstanceDetails(csMachine)