Drop in-playbook fail; let ci-framework report UNSTABLE

Remove the final ocp_testing play and fail_if_test_stage_unstable task.
Testing stages still write test_stage_unstable_flag; the ci-framework
shiftstack role fails after artifact rsync when that flag is present.

Pair with ci-framework-jobs failure-message: unstable so monolithic
Zuul jobs show yellow on test failures instead of green or red FAILURE.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: tusharjadhav3302

collection/tools/roles/tools_stage_results/tasks/fail_if_test_stage_unstable.yml

@@ -33,8 +33,9 @@ report_dir: "{{ artifacts_dir }}/test_results"
 # Sets the Ansible Controller Node machine's HOME environment variable
 controller_home_dir: "{{ lookup('ansible.builtin.env', 'HOME') }}"
 # The resources_file and stage_unstable flags are on the Ansible control node's HOME.
-# test_stage_unstable_flag is written only by testing-stage rescues; ocp_testing.yaml
-# fails at the end if it exists so Zuul can report UNSTABLE for test failures.
+# test_stage_unstable_flag is written only by testing-stage rescues. The ci-framework
+# shiftstack role fails the Zuul job when this file is present in rsynced artifacts;
+# pair with failure-message: unstable on monolithic shiftstack Zuul jobs for yellow UI.
 # stage_unstable_flag is used by soft verification/install workarounds (no end-of-run fail).
 resources_file: "{{ controller_home_dir }}/artifacts/resources.yml"
 stage_unstable_flag: "{{ controller_home_dir }}/artifacts/stage_unstable_flag"

configs/global.yml

@@ -124,14 +124,3 @@
 - name: Run EgressIP tests on OpenShift
   ansible.builtin.import_playbook: plays/egressip_tests.yaml
   when: "'egressip_tests' in stages"
-
-- name: Fail if any testing stage was marked UNSTABLE
-  hosts: localhost
-  gather_facts: false
-  vars_files:
-    - "../configs/global.yml"
-  tasks:
-    - name: Check accumulated UNSTABLE testing stages and fail the playbook
-      ansible.builtin.include_role:
-        name: tools_stage_results
-        tasks_from: fail_if_test_stage_unstable.yml