fix(autom): address review feedback

- Keep response mappers with a single caller in that tool's file
- Document the AutomIcon export
- Read the operation from the mapper context so agent tools coerce Page and
  Results per Page too

Author: Josselin Liebe

apps/docs/components/icons.tsx

@@ -10460,6 +10460,7 @@ export function PlaneIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
+/** Autom logo, as used by the Autom block. */
 export function AutomIcon(props: SVGProps<SVGSVGElement>) {
   return (
     <svg viewBox='-1 1 22 22' fill='none' xmlns='http://www.w3.org/2000/svg' {...props}>

apps/sim/blocks/blocks/autom.ts

@@ -173,7 +173,8 @@ export const AutomBlock: BlockConfig = {
     ],
     config: {
       tool: (params) => `autom_${params.operation}`,
-      params: (params) => {
+      params: (params, context) => {
+        const operation = context?.operation ?? params.operation
         const result: Record<string, unknown> = {}
         if (
           [
@@ -184,11 +185,11 @@ export const AutomBlock: BlockConfig = {
             'duckduckgo_search',
             'yahoo_search',
             'brave_search',
-          ].includes(params.operation)
+          ].includes(operation)
         ) {
           result.page = parseOptionalNumberInput(params.page, 'Page', { integer: true, min: 1 })
         }
-        if (['google_search', 'google_news', 'bing_search'].includes(params.operation)) {
+        if (['google_search', 'google_news', 'bing_search'].includes(operation)) {
           result.numResults = parseOptionalNumberInput(params.numResults, 'Results per Page', {
             integer: true,
             min: 1,

apps/sim/components/icons.tsx

@@ -10460,6 +10460,7 @@ export function PlaneIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
+/** Autom logo, as used by the Autom block. */
 export function AutomIcon(props: SVGProps<SVGSVGElement>) {
   return (
     <svg viewBox='-1 1 22 22' fill='none' xmlns='http://www.w3.org/2000/svg' {...props}>

apps/sim/tools/autom/find_google_locations.ts

@@ -1,13 +1,27 @@
-import { toArray } from '@sim/utils/object'
+import { toNumberOrNull, toStringOrNull } from '@sim/utils/coerce'
+import { toArray, toRecordOrNull } from '@sim/utils/object'
 import type {
   AutomFindGoogleLocationsParams,
   AutomFindGoogleLocationsResponse,
   AutomLocation,
 } from '@/tools/autom/types'
 import { AUTOM_LOCATION_OUTPUT_PROPERTIES } from '@/tools/autom/types'
-import { mapAutomLocation } from '@/tools/autom/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Reads a `AutomLocation` from an untyped Autom API payload. */
+function mapAutomLocation(value: unknown): AutomLocation | null {
+  const record = toRecordOrNull(value)
+  if (!record) return null
+  return {
+    canonicalName: toStringOrNull(record.canonical_name),
+    name: toStringOrNull(record.name),
+    targetType: toStringOrNull(record.target_type),
+    countryCode: toStringOrNull(record.country_code),
+    reach: toNumberOrNull(record.reach),
+    googleId: toNumberOrNull(record.google_id),
+  }
+}
+
 export const automFindGoogleLocationsTool: ToolConfig<
   AutomFindGoogleLocationsParams,
   AutomFindGoogleLocationsResponse

apps/sim/tools/autom/google_autocomplete.ts

@@ -1,13 +1,22 @@
-import { toArray, toRecord } from '@sim/utils/object'
+import { toStringOrNull } from '@sim/utils/coerce'
+import { toArray, toRecord, toRecordOrNull } from '@sim/utils/object'
 import type {
   AutomGoogleAutocompleteParams,
   AutomGoogleAutocompleteResponse,
   AutomSuggestion,
 } from '@/tools/autom/types'
 import { AUTOM_SUGGESTION_OUTPUT_PROPERTIES } from '@/tools/autom/types'
-import { mapAutomSuggestion } from '@/tools/autom/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Reads a `AutomSuggestion` from an untyped Autom API payload. */
+function mapAutomSuggestion(value: unknown): AutomSuggestion | null {
+  const record = toRecordOrNull(value)
+  if (!record) return null
+  return {
+    value: toStringOrNull(record.value),
+  }
+}
+
 export const automGoogleAutocompleteTool: ToolConfig<
   AutomGoogleAutocompleteParams,
   AutomGoogleAutocompleteResponse

apps/sim/tools/autom/google_maps.ts

@@ -1,13 +1,28 @@
-import { toArray } from '@sim/utils/object'
+import { toNumberOrNull, toStringOrNull } from '@sim/utils/coerce'
+import { toArray, toRecordOrNull } from '@sim/utils/object'
 import type {
   AutomGoogleMapsParams,
   AutomGoogleMapsResponse,
   AutomPlace,
 } from '@/tools/autom/types'
 import { AUTOM_PLACE_OUTPUT_PROPERTIES } from '@/tools/autom/types'
-import { mapAutomPlace } from '@/tools/autom/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Reads a `AutomPlace` from an untyped Autom API payload. */
+function mapAutomPlace(value: unknown): AutomPlace | null {
+  const record = toRecordOrNull(value)
+  if (!record) return null
+  return {
+    title: toStringOrNull(record.title),
+    address: toStringOrNull(record.address),
+    website: toStringOrNull(record.website),
+    phoneNumber: toStringOrNull(record.phone_number),
+    latitude: toNumberOrNull(record.lat),
+    longitude: toNumberOrNull(record.long),
+    placeId: toStringOrNull(record.fid),
+  }
+}
+
 export const automGoogleMapsTool: ToolConfig<AutomGoogleMapsParams, AutomGoogleMapsResponse> = {
   id: 'autom_google_maps',
   name: 'Autom Google Maps',

apps/sim/tools/autom/google_search.ts

@@ -1,17 +1,29 @@
-import { toBooleanOrNull, toNumberOrNull } from '@sim/utils/coerce'
-import { toArray, toRecord } from '@sim/utils/object'
+import { toBooleanOrNull, toNumberOrNull, toStringOrNull } from '@sim/utils/coerce'
+import { toArray, toRecord, toRecordOrNull } from '@sim/utils/object'
 import type {
   AutomGoogleSearchParams,
   AutomGoogleSearchResponse,
+  AutomKnowledgeGraph,
   AutomSearchResult,
 } from '@/tools/autom/types'
 import {
   AUTOM_KNOWLEDGE_GRAPH_OUTPUT_PROPERTIES,
   AUTOM_SEARCH_RESULT_OUTPUT_PROPERTIES,
 } from '@/tools/autom/types'
-import { mapAutomKnowledgeGraph, mapAutomSearchResult } from '@/tools/autom/utils'
+import { mapAutomSearchResult } from '@/tools/autom/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Reads a `AutomKnowledgeGraph` from an untyped Autom API payload. */
+function mapAutomKnowledgeGraph(value: unknown): AutomKnowledgeGraph | null {
+  const record = toRecordOrNull(value)
+  if (!record) return null
+  return {
+    title: toStringOrNull(record.title),
+    type: toStringOrNull(record.type),
+    website: toStringOrNull(record.website),
+  }
+}
+
 export const automGoogleSearchTool: ToolConfig<AutomGoogleSearchParams, AutomGoogleSearchResponse> =
   {
     id: 'autom_google_search',

apps/sim/tools/autom/utils.ts

@@ -1,12 +1,6 @@
 import { toNumberOrNull, toStringOrNull } from '@sim/utils/coerce'
 import { toRecordOrNull } from '@sim/utils/object'
-import type {
-  AutomKnowledgeGraph,
-  AutomLocation,
-  AutomPlace,
-  AutomSearchResult,
-  AutomSuggestion,
-} from '@/tools/autom/types'
+import type { AutomSearchResult } from '@/tools/autom/types'
 
 /** Reads a `AutomSearchResult` from an untyped Autom API payload. */
 export function mapAutomSearchResult(value: unknown): AutomSearchResult | null {
@@ -23,52 +17,3 @@ export function mapAutomSearchResult(value: unknown): AutomSearchResult | null {
     date: toStringOrNull(record.date),
   }
 }
-
-/** Reads a `AutomKnowledgeGraph` from an untyped Autom API payload. */
-export function mapAutomKnowledgeGraph(value: unknown): AutomKnowledgeGraph | null {
-  const record = toRecordOrNull(value)
-  if (!record) return null
-  return {
-    title: toStringOrNull(record.title),
-    type: toStringOrNull(record.type),
-    website: toStringOrNull(record.website),
-  }
-}
-
-/** Reads a `AutomPlace` from an untyped Autom API payload. */
-export function mapAutomPlace(value: unknown): AutomPlace | null {
-  const record = toRecordOrNull(value)
-  if (!record) return null
-  return {
-    title: toStringOrNull(record.title),
-    address: toStringOrNull(record.address),
-    website: toStringOrNull(record.website),
-    phoneNumber: toStringOrNull(record.phone_number),
-    latitude: toNumberOrNull(record.lat),
-    longitude: toNumberOrNull(record.long),
-    placeId: toStringOrNull(record.fid),
-  }
-}
-
-/** Reads a `AutomSuggestion` from an untyped Autom API payload. */
-export function mapAutomSuggestion(value: unknown): AutomSuggestion | null {
-  const record = toRecordOrNull(value)
-  if (!record) return null
-  return {
-    value: toStringOrNull(record.value),
-  }
-}
-
-/** Reads a `AutomLocation` from an untyped Autom API payload. */
-export function mapAutomLocation(value: unknown): AutomLocation | null {
-  const record = toRecordOrNull(value)
-  if (!record) return null
-  return {
-    canonicalName: toStringOrNull(record.canonical_name),
-    name: toStringOrNull(record.name),
-    targetType: toStringOrNull(record.target_type),
-    countryCode: toStringOrNull(record.country_code),
-    reach: toNumberOrNull(record.reach),
-    googleId: toNumberOrNull(record.google_id),
-  }
-}