Skip to content

Commit 4a38eee

Browse files
committed
fix(settings): reset group detail params on open and drop issuer mono styling
1 parent 02aa9a1 commit 4a38eee

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

apps/sim/ee/access-control/components/access-control.tsx

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,22 @@ export function AccessControl({ isOrganizationAdmin, organizationId }: AccessCon
108108
...groupStatusUrlKeys,
109109
})
110110

111+
/**
112+
* The detail view's tab/search/status params are scoped to one group, so both
113+
* transitions reset them — otherwise a stale `group-id` that never resolves
114+
* leaves them in the URL and the next group opens on the previous group's tab
115+
* and filters. nuqs batches these same-tick writes into one URL update.
116+
*/
117+
const openGroupDetail = useCallback(
118+
(groupId: string) => {
119+
void setSelectedGroupId(groupId)
120+
void setGroupTab(null)
121+
void setGroupSearch(null)
122+
void setGroupStatus(null)
123+
},
124+
[setSelectedGroupId, setGroupTab, setGroupSearch, setGroupStatus]
125+
)
126+
111127
const closeGroupDetail = useCallback(() => {
112128
void setSelectedGroupId(null, { history: 'replace' })
113129
void setGroupTab(null)
@@ -236,7 +252,7 @@ export function AccessControl({ isOrganizationAdmin, organizationId }: AccessCon
236252
<button
237253
key={group.id}
238254
type='button'
239-
onClick={() => void setSelectedGroupId(group.id)}
255+
onClick={() => openGroupDetail(group.id)}
240256
className='flex items-center gap-2.5 rounded-lg p-2 text-left transition-colors hover-hover:bg-[var(--surface-active)]'
241257
>
242258
<div className='flex min-w-0 flex-1 flex-col'>

apps/sim/ee/sso/components/sso-settings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ function OrganizationSsoSettings({ organizationId }: SSOProps) {
409409
</SettingRow>
410410

411411
<SettingRow label='Issuer URL'>
412-
<p className='break-all font-mono text-[var(--text-primary)] text-small leading-relaxed'>
412+
<p className='break-all text-[var(--text-primary)] text-small'>
413413
{existingProvider.issuer}
414414
</p>
415415
</SettingRow>

0 commit comments

Comments
 (0)