fix(design-diff): bound parser retention and preserve historical capability resolution

Author: Bill Leoutsakos

design-diff.config.json

@@ -97,7 +97,7 @@
       "export": "wireServerFallback",
       "environmentModule": "apps/sim/lib/core/config/env.ts",
       "environmentExport": "env",
-      "implementationModule": "packages/deployment-config/src/env-capabilities.ts",
+      "implementationModule": "apps/sim/lib/core/config/env-capabilities.ts",
       "implementationExport": "wireFallback"
     }
   ]

scripts/design-diff/README.md

@@ -180,7 +180,7 @@ JSON inputs are compared semantically, retaining array order and attributing cha
 the spec and configured renderer. Malformed/missing configured inputs flag with a limitation.
 
 The graph reuses up to 10,000 import/export snapshots keyed by source blob, resolving their
-paths again for each revision. The resolver retains at most 128 parsed modules per revision,
+paths again for each revision. The resolver retains at most 32 parsed modules per revision,
 and requests Bun garbage collection between parser batches. These resource controls do
 not change evidence or decisions. The Node-based test runner uses its own garbage collector.
 

scripts/design-diff/refactors.ts

@@ -133,6 +133,7 @@ export function normalizeLiteralAliases(ast: t.File, visit: typeof traverse): vo
   visit(ast, {
     Expression(path) {
       if (path.parentPath.isExportSpecifier()) return
+      if (path.findParent((parent) => parent.isTSType())) return
       if (!(path.isReferencedIdentifier() || path.isObjectExpression() || path.isArrayExpression()))
         return
       const value = literal(path)

scripts/design-diff/resolve.ts

@@ -32,7 +32,6 @@ interface Module {
 /** A bounded interpreter for data expressions. It never invokes a source function. */
 export class Resolver {
   private readonly modules = new Map<string, Module>()
-  private readonly values = new WeakMap<t.Node, Map<string, Evidence & { cost: number }>>()
   private readonly evaluations = new WeakMap<t.Node, Evidence>()
   private readonly unknowns = new WeakMap<t.Node, Map<string, Evidence>>()
   private readonly opaqueValues = new Map<string, Evidence>()
@@ -77,7 +76,7 @@ export class Resolver {
       },
     })
     const result = { ast, exports, stars }
-    if (this.modules.size >= 128) this.modules.delete(this.modules.keys().next().value!)
+    if (this.modules.size >= 32) this.modules.delete(this.modules.keys().next().value!)
     this.modules.set(file, result)
     return result
   }
@@ -729,15 +728,6 @@ export class Resolver {
 
   private value(path: NodePath, file: string, depth: number): Data {
     if (!path?.node) return null
-    const started = this.steps
-    const cacheKey = `${depth}:${this.tree.config.limits.resolutionSteps - started}`
-    const cached = this.values.get(path.node)?.get(cacheKey)
-    if (cached && !this.active.has(path.node)) {
-      this.steps += cached.cost
-      for (const file of cached.dependencies) this.dependencies.add(file)
-      for (const reason of cached.unresolved) this.unresolved.add(reason)
-      return cached.value
-    }
     if (
       ++this.steps > this.tree.config.limits.resolutionSteps ||
       depth > this.tree.config.limits.resolutionDepth
@@ -752,21 +742,7 @@ export class Resolver {
     this.dependencies = new Set([file])
     this.unresolved = new Set()
     try {
-      const value = this.inner(path, file, depth)
-      if (![...this.unresolved].some((reason) => /cycle/i.test(reason))) {
-        const entries = this.values.get(path.node) ?? new Map()
-        // Bound per-node cache variants; budget/depth are part of the key so warming
-        // a cache cannot change evidence in a later evaluation.
-        if (entries.size < 8)
-          entries.set(cacheKey, {
-            value,
-            cost: this.steps - started,
-            dependencies: [...this.dependencies],
-            unresolved: [...this.unresolved],
-          })
-        this.values.set(path.node, entries)
-      }
-      return value
+      return this.inner(path, file, depth)
     } finally {
       for (const file of this.dependencies) dependencies.add(file)
       for (const reason of this.unresolved) unresolved.add(reason)

scripts/design-diff/tests/precision.test.ts

@@ -237,7 +237,7 @@ it('projects configured capability environment fields and retains helper changes
     ...settings,
     aliases: [
       ...settings.aliases,
-      { from: 'apps/sim/', prefix: '@capability/', target: 'packages/deployment-config/src/' },
+      { from: 'apps/sim/', prefix: '@capability/', target: 'apps/sim/lib/core/config/' },
     ],
   }
   const environment = (batch: number, email: boolean) =>
@@ -272,3 +272,15 @@ it('projects configured capability environment fields and retains helper changes
     ).flagged
   ).toBe(true)
 })
+
+it('leaves type queries over literal constants erased and parseable', async () => {
+  const source = (kind: string) =>
+    `const KINDS=['one','two'] as const;type Kind = typeof KINDS[number];export const Page=()=> <span>${kind}</span>`
+  const report = await compareFiles({ [view]: source('a') }, { [view]: source('b') }, settings)
+  expect(report.flagged).toBe(true)
+  expect(
+    report.findings
+      .flatMap((finding) => finding.limitations)
+      .some((reason) => /parser|extraction failed/i.test(reason))
+  ).toBe(false)
+})