Merge branch 'wip/fx24-consistency' into wip/platform-org-wiring

Author: waleedlatif1

.claude/rules/sim-ui-copy.md

@@ -15,6 +15,17 @@ paths:
 
 This applies to app UI outside the Platform: settings rows, modals, panels, cards, list rows, empty states, form fields, and section headers. Platform views (`app/(product)`, `platform`) follow the stricter one-line-per-control rule in `apps/sim/platform/AGENTS.md`, which `check:platform-design` enforces (`helper-copy`); marketing surfaces (`app/(landing)`, docs) follow `constitution.md`.
 
+## Platform copy vocabulary
+
+Platform views also share one vocabulary, documented in `apps/sim/platform/AGENTS.md` (Code-first product design) and enforced by `check:platform-design`:
+
+- **Sentence case** for every literal `label`, `title`, `confirmLabel`, `pendingLabel` and `cancelLabel`, for `label`s in menu, column, sort and command data, and for button, menu item and chip text (`copy-case`). Product, plan and brand names keep their capitals through `PROPER_NOUNS` / `PROPER_PHRASES` in `scripts/platform-source-rules.ts`; a page or tab name inside a label is a common noun ("Open logs", "Switch to runs").
+- **The `…` glyph**, never three periods, in rendered copy and in object or record values such as status labels (`copy-ellipsis`).
+- **Confirmations** go through `ConfirmDialog` with a real `pendingLabel` ("Deleting…"), `safe` when nothing is lost (`confirm-owner`). Titles are "{Verb} {noun}" with no question mark, identical for one object everywhere; unsaved changes read "Unsaved changes" / "Discard".
+- **Verbs**: editing saves with "Save", creating says "Create {noun}", adding a connection or credential says "Add {noun}", OAuth keeps "Connect".
+- **Empty and no-results**: an empty list is `EmptyState` (`Muted` in a narrow rail or dialog picker); no results read "No matching {noun}", the query in curly quotes, no period.
+- **Back, tabs, alerts, tooltips** belong to their owners: `DirectoryBack` / `DetailHeader` with bare-noun labels (`back-owner`), `ContentTabs` (`tab-owner`), `InlineNotice` / `FailureNotice` / a field's `error` (`alert-owner`), and `Tooltip` / `OverflowText` rather than a native `title=` (`native-title`). Statuses use Logs' words: a failed run reads "Failed".
+
 **Carve-out — settings section metadata.** `SettingsNavigationItem.description` in `components/settings/navigation.ts` stays required, and `SettingsPanel` keeps rendering it as the page subtitle. Settings sections are reached through a nav list where the description is the only thing distinguishing adjacent sections, so it earns its place by the "prevents misunderstanding" test. Keep those descriptions verb-first and one line, per `sim-settings-pages.md`. Everything else on a settings page — inline `<p>` blurbs under section headings, field hints, modal bodies, row subtitles — follows the default rule above.
 
 ## The default is no description

.cursor/rules/sim-ui-copy.mdc

@@ -11,6 +11,17 @@ globs: ["apps/sim/components/**/*.tsx","apps/sim/ee/**/*.tsx","apps/sim/app/_she
 
 This applies to app UI outside the Platform: settings rows, modals, panels, cards, list rows, empty states, form fields, and section headers. Platform views (`app/(product)`, `platform`) follow the stricter one-line-per-control rule in `apps/sim/platform/AGENTS.md`, which `check:platform-design` enforces (`helper-copy`); marketing surfaces (`app/(landing)`, docs) follow `constitution.md`.
 
+## Platform copy vocabulary
+
+Platform views also share one vocabulary, documented in `apps/sim/platform/AGENTS.md` (Code-first product design) and enforced by `check:platform-design`:
+
+- **Sentence case** for every literal `label`, `title`, `confirmLabel`, `pendingLabel` and `cancelLabel`, for `label`s in menu, column, sort and command data, and for button, menu item and chip text (`copy-case`). Product, plan and brand names keep their capitals through `PROPER_NOUNS` / `PROPER_PHRASES` in `scripts/platform-source-rules.ts`; a page or tab name inside a label is a common noun ("Open logs", "Switch to runs").
+- **The `…` glyph**, never three periods, in rendered copy and in object or record values such as status labels (`copy-ellipsis`).
+- **Confirmations** go through `ConfirmDialog` with a real `pendingLabel` ("Deleting…"), `safe` when nothing is lost (`confirm-owner`). Titles are "{Verb} {noun}" with no question mark, identical for one object everywhere; unsaved changes read "Unsaved changes" / "Discard".
+- **Verbs**: editing saves with "Save", creating says "Create {noun}", adding a connection or credential says "Add {noun}", OAuth keeps "Connect".
+- **Empty and no-results**: an empty list is `EmptyState` (`Muted` in a narrow rail or dialog picker); no results read "No matching {noun}", the query in curly quotes, no period.
+- **Back, tabs, alerts, tooltips** belong to their owners: `DirectoryBack` / `DetailHeader` with bare-noun labels (`back-owner`), `ContentTabs` (`tab-owner`), `InlineNotice` / `FailureNotice` / a field's `error` (`alert-owner`), and `Tooltip` / `OverflowText` rather than a native `title=` (`native-title`). Statuses use Logs' words: a failed run reads "Failed".
+
 **Carve-out — settings section metadata.** `SettingsNavigationItem.description` in `components/settings/navigation.ts` stays required, and `SettingsPanel` keeps rendering it as the page subtitle. Settings sections are reached through a nav list where the description is the only thing distinguishing adjacent sections, so it earns its place by the "prevents misunderstanding" test. Keep those descriptions verb-first and one line, per `sim-settings-pages.md`. Everything else on a settings page — inline `<p>` blurbs under section headings, field hints, modal bodies, row subtitles — follows the default rule above.
 
 ## The default is no description

apps/sim/app/(product)/_components/access-requests/my-requests.tsx

@@ -73,7 +73,7 @@ export function MyRequests({ scope, view, mine }: MyRequestsProps) {
         <EmptyState
           title={
             mine.query
-              ? 'No matching results'
+              ? 'No matching requests'
               : mine.page > 0
                 ? 'No more access to request'
                 : 'Nothing to request in this organization'

apps/sim/app/(product)/_components/access-requests/review-requests.tsx

@@ -23,7 +23,7 @@ interface ReviewRequestsProps {
 }
 
 function emptyTitle(query: string, status: RequestStatusFilter, statusLabel: string | null) {
-  if (query) return `No matching requests for "${query}"`
+  if (query) return `No matching requests for “${query}”`
   if (status === 'pending') return 'No pending requests'
   if (status === 'all') return 'No requests yet'
   return `No ${statusLabel?.toLowerCase()} requests`

apps/sim/app/(product)/_components/chat/cards/live-credential-card.tsx

@@ -243,7 +243,7 @@ export function LiveCredentialCard({
                   render={
                     <Link href={integrationsHref} target='_blank' rel='noopener noreferrer' />
                   }
-                  label={`Connect ${serviceName(item)} in Integrations`}
+                  label={`Connect ${serviceName(item)} in integrations`}
                   trailingIcon='I030'
                 />
               ) : null
@@ -291,12 +291,12 @@ export function LiveUsageNotice({ action, reason, message }: UsageNoticeProps) {
     !canManage && reason === 'usage_limit' && action === 'increase_limit'
   )
   if (reason === 'job_run_budget')
-    return <InlineNotice intent='warning' title='Run Spend Limit Reached' message={message} />
+    return <InlineNotice intent='warning' title='Run spend limit reached' message={message} />
   return (
     <>
       <InlineNotice
         intent='warning'
-        title={reason === 'chat_plan_required' ? 'Paid Plan Required' : 'Usage Limit Reached'}
+        title={reason === 'chat_plan_required' ? 'Paid plan required' : 'Usage limit reached'}
         message={
           canManage
             ? message
@@ -306,7 +306,7 @@ export function LiveUsageNotice({ action, reason, message }: UsageNoticeProps) {
           canManage ? (
             <ControlRow
               render={<Link href={href} />}
-              label={upgrade ? 'Upgrade Plan' : 'Increase Limit'}
+              label={upgrade ? 'Upgrade plan' : 'Increase limit'}
               trailingIcon='I030'
             />
           ) : memberLimit ? (

apps/sim/app/(product)/_components/chat/cards/tool-approval.tsx

@@ -5,6 +5,7 @@ import { ActivityBody } from '@sim/emcn/activity-row/activity-body'
 import { Button } from '@sim/emcn/button'
 import { Icon } from '@sim/emcn/icon'
 import { ActionMenu } from '@sim/emcn/menu/action-menu'
+import { Tooltip } from '@sim/emcn/tooltip'
 import { generateId } from '@sim/utils/id'
 import styles from '@/app/(product)/_components/chat/cards/cards.module.css'
 import { usePlatformNotices } from '@/app/(product)/_components/notification-tray/notification-tray'
@@ -50,9 +51,11 @@ export function ToolApproval({ tool }: { tool: PlatformTool }) {
   return (
     <div className={styles.card}>
       <ActivityBody leading={<Icon name='I084' />} decorativeLeading>
-        <span className={styles.title} data-type='T048' title={tool.input}>
-          {tool.title}
-        </span>
+        <Tooltip label={tool.input ?? ''} enabled={Boolean(tool.input)}>
+          <span className={styles.title} data-type='T048'>
+            {tool.title}
+          </span>
+        </Tooltip>
       </ActivityBody>
       <div className={styles.actions}>
         <Button

apps/sim/app/(product)/_components/chat/panel/browser-session/browser-session.tsx

@@ -52,33 +52,33 @@ export function BrowserSession({ scopeId, visible }: BrowserSessionProps) {
   const menuActions = (): MenuAction[] => [
     {
       id: 'find',
-      label: 'Find in Page',
+      label: 'Find in page',
       shortcut: '⌘F',
       onSelect: menu.afterClose(browser.openFind),
     },
     ...continueSignInActions(signIn, menu.afterClose),
     {
       id: 'zoom-in',
-      label: 'Zoom In',
+      label: 'Zoom in',
       shortcut: '⌘+',
       separatorBefore: true,
       onSelect: menu.afterClose(() => menu.zoom('zoom-in')),
     },
     {
       id: 'zoom-out',
-      label: 'Zoom Out',
+      label: 'Zoom out',
       shortcut: '⌘−',
       onSelect: menu.afterClose(() => menu.zoom('zoom-out')),
     },
     {
       id: 'zoom-reset',
-      label: 'Actual Size',
+      label: 'Actual size',
       shortcut: '⌘0',
       onSelect: menu.afterClose(() => menu.zoom('zoom-reset')),
     },
     {
       id: 'fill-password',
-      label: 'Fill Saved Password',
+      label: 'Fill saved password',
       separatorBefore: true,
       disabled: !menu.fillAvailable,
       onSelect: menu.afterClose(() => menu.fillPassword(menuAnchor.current)),
@@ -90,13 +90,13 @@ export function BrowserSession({ scopeId, visible }: BrowserSessionProps) {
     },
     {
       id: 'import-passwords',
-      label: 'Import Passwords',
+      label: 'Import passwords',
       disabled: !menu.canImport,
       onSelect: menu.afterClose(() => menu.settings('?browserImport=1')),
     },
     {
       id: 'browser-settings',
-      label: 'Browser Settings',
+      label: 'Browser settings',
       separatorBefore: true,
       onSelect: menu.afterClose(() => menu.settings('')),
     },

apps/sim/app/(product)/_components/chat/panel/browser-session/continue-sign-in.tsx

@@ -37,7 +37,7 @@ export function continueSignInActions(
   return [
     {
       id: 'continue-sign-in',
-      label: 'Continue in Browser',
+      label: 'Continue in browser',
       separatorBefore: true,
       children: [head, ...tail],
     },

apps/sim/app/(product)/_components/chat/panel/browser-session/page-prompts.tsx

@@ -5,6 +5,7 @@ import { Button, IconButton } from '@sim/emcn/button'
 import { Checkbox } from '@sim/emcn/checkbox'
 import { SelectField, TextField } from '@sim/emcn/field'
 import { Modal } from '@sim/emcn/modal'
+import { ConfirmDialog } from '@sim/emcn/modal/confirm-dialog'
 import { InlineNotice } from '@sim/emcn/status'
 import { useActivationDelay, type useBrowserPanel } from '@/platform/lib/data/browser-panel'
 import { formatInstantDate } from '@/platform/shared/time'
@@ -48,7 +49,7 @@ export function PageDialogModal({ dialog, onAnswer }: PageDialogModalProps) {
       onOpenChange={(open) => {
         if (!open) answer(false)
       }}
-      title='Leave page?'
+      title='Leave page'
       description='Changes on this page may not be saved.'
       cancelLabel='Stay'
       confirmLabel='Leave'
@@ -240,15 +241,14 @@ function ExternalAppPrompt({ prompt, respond }: PromptModalProps<'external-app'>
   const armed = useActivationDelay(true)
   const [alwaysAllow, setAlwaysAllow] = useState(false)
   return (
-    <Modal
-      variant='confirm'
-      open
-      onOpenChange={(open) => {
-        if (!open) respond({ allowed: false })
-      }}
-      title={`Open ${prompt.appName}?`}
+    <ConfirmDialog
+      target={prompt}
+      onClose={() => respond({ allowed: false })}
+      safe
+      title={`Open ${prompt.appName}`}
       description={`${prompt.origin} wants to open this app.`}
       confirmLabel='Open'
+      pendingLabel='Opening…'
       confirmDisabled={!armed}
       onConfirm={() =>
         respond({
@@ -265,7 +265,7 @@ function ExternalAppPrompt({ prompt, respond }: PromptModalProps<'external-app'>
           onCheckedChange={setAlwaysAllow}
         />
       )}
-    </Modal>
+    </ConfirmDialog>
   )
 }
 

apps/sim/app/(product)/_components/credential-members/credential-members.tsx

@@ -255,7 +255,7 @@ export function AddPeopleModal({
         if (!next) close()
       }}
       title='Add people'
-      confirmLabel='Add'
+      confirmLabel='Add people'
       confirmDisabled={emails.length === 0 || Boolean(firstError)}
       onConfirm={add}
     >