Merge branch 'codex/design-diff-engine' into codex/design-diff-benchmark-v3

Author: Bill Leoutsakos

scripts/design-diff/ast.ts

@@ -43,6 +43,15 @@ export function canonical(value: unknown): Data {
     return canonical(node.expression)
   const result: Record<string, Data> = Object.create(null)
   for (const key of Object.keys(node).sort()) {
+    /** Babel builders and parsed nodes spell absent optional fields differently. */
+    if (
+      (key === 'optional' && /Expression$/.test(String(node.type)) && !node[key]) ||
+      (key === 'method' && node.type === 'ObjectProperty' && node[key] === false) ||
+      (['id', 'generator', 'expression'].includes(key) &&
+        node.type === 'ArrowFunctionExpression' &&
+        !node[key])
+    )
+      continue
     if (
       [
         'start',

scripts/design-diff/refactors.ts

@@ -132,6 +132,7 @@ export function normalizeLiteralAliases(ast: t.File, visit: typeof traverse): vo
   }
   visit(ast, {
     Expression(path) {
+      if (path.key === 'id') return
       if (path.parentPath.isExportSpecifier()) return
       if (path.findParent((parent) => parent.isTSType())) return
       if (!(path.isReferencedIdentifier() || path.isObjectExpression() || path.isArrayExpression()))

scripts/design-diff/tests/precision.test.ts

@@ -200,21 +200,24 @@ it('preserves helper switch selection conditions', async () => {
   expect(report.flagged).toBe(true)
 })
 
-it('preserves the audited Object.entries reducer to fromEntries refactor', async () => {
-  const before =
-    'export const copy=(blocks)=>Object.entries(blocks).reduce((acc,[id,block])=>({...acc,[id]:{...block,value:structuredClone(block.value)}}),{})'
-  const after =
-    'export const copy=(blocks)=>Object.fromEntries(Object.entries(blocks).map(([id,block])=>[id,{...block,value:structuredClone(block.value)}]))'
-  const report = await compareFiles(
-    {
-      [data]: before,
-      [view]: 'import {copy} from "./data";export const Page=()=> <Panel data={copy(blocks)}/>',
-    },
-    { [data]: after },
-    settings
-  )
-  expect(report.flagged).toBe(false)
-})
+it.each([1, 24])(
+  'preserves the audited record-map refactor at resolution depth %s',
+  async (resolutionDepth) => {
+    const before =
+      'export const copy=(blocks)=>Object.entries(blocks).reduce((acc,[id,block])=>({...acc,[id]:{...block,value:structuredClone(block.value)}}),{})'
+    const after =
+      'export const copy=(blocks)=>Object.fromEntries(Object.entries(blocks).map(([id,block])=>[id,{...block,value:structuredClone(block.value)}]))'
+    const report = await compareFiles(
+      {
+        [data]: before,
+        [view]: 'import {copy} from "./data";export const Page=()=> <Panel data={copy(blocks)}/>',
+      },
+      { [data]: after },
+      { ...settings, limits: { ...settings.limits, resolutionDepth } }
+    )
+    expect(report.flagged).toBe(false)
+  }
+)
 
 it('keeps selected environment evidence narrow after exhausting expression depth', async () => {
   const source = (size: number) =>
@@ -284,3 +287,15 @@ it('leaves type queries over literal constants erased and parseable', async () =
       .some((reason) => /parser|extraction failed/i.test(reason))
   ).toBe(false)
 })
+
+it('preserves value/type names shared by generated schema declarations', async () => {
+  const source = (text: string) =>
+    `const Kind={ONE:1};type Kind=typeof Kind;export const Page=()=> <div>${text}</div>`
+  const report = await compareFiles({ [view]: source('a') }, { [view]: source('b') }, settings)
+  expect(report.flagged).toBe(true)
+  expect(
+    report.findings
+      .flatMap((finding) => finding.limitations)
+      .some((reason) => /parser|extraction failed/i.test(reason))
+  ).toBe(false)
+})