Skip to content

Commit c82d225

Browse files
committed
fix(ci): drop redundant setup-node from bun-only jobs
Once lifecycle scripts are skipped, nothing in create-release, migrate, or deploy-trigger-dev invokes node: they run bun run scripts/create-single-release.ts, bun run db:push plus bun run scripts/migrate.ts, and bunx trigger.dev deploy. All three were green without setup-node for months — the isolated-vm install script was the only thing that ever needed it, and --ignore-scripts covers that. setup-node stays where it is load-bearing: publish-cli and publish-ts-sdk need it for npm publish and its registry-url auth, and test-build/docs-embeddings already had it. publish-cli keeps the Node 18 -> 22 bump: that setup-node is required, and 18 has been EOL since April 2025, so it now matches publish-ts-sdk.
1 parent f1c014a commit c82d225

2 files changed

Lines changed: 0 additions & 21 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,6 @@ jobs:
186186
with:
187187
bun-version: 1.3.13
188188

189-
# Repo scripts target engines.node >= 22.19.0; without this the job runs on
190-
# the runner default (Node 20).
191-
- name: Setup Node
192-
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
193-
with:
194-
node-version: 22
195-
196189
- name: Cache Bun dependencies
197190
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
198191
with:
@@ -590,13 +583,6 @@ jobs:
590583
with:
591584
bun-version: 1.3.13
592585

593-
# Repo scripts target engines.node >= 22.19.0; without this the job runs on
594-
# the runner default (Node 20).
595-
- name: Setup Node
596-
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
597-
with:
598-
node-version: 22
599-
600586
- name: Install dependencies
601587
run: bun install --frozen-lockfile --ignore-scripts
602588

.github/workflows/migrations.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,6 @@ jobs:
3636
with:
3737
bun-version: 1.3.13
3838

39-
# Repo scripts target engines.node >= 22.19.0; without this the job runs on
40-
# the runner default (Node 20).
41-
- name: Setup Node
42-
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
43-
with:
44-
node-version: 22
45-
4639
- name: Cache Bun dependencies
4740
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
4841
with:

0 commit comments

Comments
 (0)