fix(jira): expose customFields as an array to LLMs and reject empty text

Round 7 (Cursor):
- customFields tool param was type: 'json', which the schema builder exposes to
  LLMs as a JSON Schema object while the contract requires an array — a model
  emitting an object/map would 400. Switch to type: 'array' with an items schema
  describing { fieldId, type, value }, matching the array params in jira/write.ts.
- text custom-field values must be non-empty (min 1), so '' is rejected at the
  boundary instead of passing validation and being silently skipped — consistent
  with select/userpicker/cascading. Adds a route test.

Author: mzxchandra

apps/sim/app/api/tools/jira/update/route.test.ts

@@ -105,6 +105,13 @@ describe('Jira update route custom-field serialization', () => {
     expect(response.status).toBe(400)
   })
 
+  it('rejects a text entry with an empty value', async () => {
+    const { response } = await update({
+      customFields: [{ fieldId: 'customfield_10007', type: 'text', value: '' }],
+    })
+    expect(response.status).toBe(400)
+  })
+
   it('rejects a select entry with an empty option value', async () => {
     const { response } = await update({
       customFields: [{ fieldId: 'customfield_10001', type: 'select', value: { value: '' } }],

apps/sim/lib/api/contracts/selectors/jira.ts

@@ -167,7 +167,7 @@ export const jiraCustomFieldEntrySchema = z
     z.object({
       fieldId: customFieldIdSchema,
       type: z.literal('text'),
-      value: z.string(),
+      value: z.string().min(1, 'text value cannot be empty'),
     }),
     z.object({ fieldId: customFieldIdSchema, type: z.literal('number'), value: numberInputSchema }),
     z.object({ fieldId: customFieldIdSchema, type: z.literal('select'), value: optionInputSchema }),

apps/sim/tools/jira/update.ts

@@ -101,11 +101,27 @@ export const jiraUpdateTool: ToolConfig<JiraUpdateParams, JiraUpdateResponse> =
       description: 'Raw value for the legacy single custom field. Prefer `customFields`.',
     },
     customFields: {
-      type: 'json',
+      type: 'array',
       required: false,
       visibility: 'user-or-llm',
       description:
         'Structured custom fields to set, as an array of { fieldId, type, value }. type is one of text | number | select | multiselect | userpicker | multiuserpicker | cascading | raw. Serialization: select→{value} (or {id} for numeric option ids); multiselect→[{value}]; userpicker→{accountId}; multiuserpicker→[{accountId}]; cascading→{value, child:{value}} (value = [parent, child] or {parent, child}); text/number→scalar; raw→passed through untouched.',
+      items: {
+        type: 'object',
+        required: ['fieldId', 'type', 'value'],
+        properties: {
+          fieldId: { type: 'string', description: 'Custom field id, e.g. customfield_10001' },
+          type: {
+            type: 'string',
+            description:
+              'One of: text, number, select, multiselect, userpicker, multiuserpicker, cascading, raw',
+          },
+          value: {
+            description:
+              'The value to set; its shape depends on type (scalar, option, accountId, array, or cascading object)',
+          },
+        },
+      },
     },
     notifyUsers: {
       type: 'boolean',