fix: improve script consistency and safety following bolt-python patterns

- Add -U flag to all pip install commands in install.sh for consistent upgrades
- Add PIP_REQUIRE_VIRTUALENV=1 to lint.sh for virtualenv safety
- Chain twine upload with && in deploy_to_test_pypi.sh for proper error handling
- Simplify flake8 invocation (single command instead of two separate calls)
- Quote all variables consistently across scripts for bash best practices
- Always run format and lint before tests in install_and_run_tests.sh

These changes align with bolt-python patterns and improve script reliability.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Author: WilliamBergamin

scripts/build_pypi_package.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 rm -rf dist/ build/ slack_cli_hooks.egg-info/
 

scripts/deploy_to_test_pypi.sh

@@ -1,12 +1,11 @@
 #!/bin/bash
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 rm -rf dist/ build/ slack_cli_hooks.egg-info/
 
 pip install -r requirements/build.txt && \
 python -m build && \
-twine check dist/*
-
+twine check dist/* && \
 twine upload --repository testpypi dist/*

scripts/format.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 # ./scripts/format.sh [--no-install]
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 if [[ "$1" != "--no-install" ]]; then
     export PIP_REQUIRE_VIRTUALENV=1

scripts/install.sh

@@ -1,10 +1,10 @@
 #!/bin/bash
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 export PIP_REQUIRE_VIRTUALENV=1
 pip install -U pip
-pip install -e .
-pip install -r requirements/testing.txt
-pip install -r requirements/format.txt
+pip install -U -e .
+pip install -U -r requirements/testing.txt
+pip install -U -r requirements/format.txt

scripts/install_and_run_tests.sh

@@ -3,19 +3,18 @@
 # all: ./scripts/install_and_run_tests.sh
 # single: ./scripts/install_and_run_tests.sh tests/scenario_tests/test_app.py
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 test_target="$1"
 
 ./scripts/install.sh
+./scripts/format.sh --no-install
+./scripts/lint.sh --no-install
 
-if [[ $test_target != "" ]]
+if [[ "$test_target" != "" ]]
 then
-    ./scripts/format.sh --no-install
-    pytest -vv $test_target
+    pytest -vv "$test_target"
 else
-    ./scripts/format.sh --no-install
-    ./scripts/lint.sh --no-install
     pytest
 fi

scripts/lint.sh

@@ -1,13 +1,14 @@
 #!/bin/bash
 # ./scripts/lint.sh [--no-install]
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 if [[ "$1" != "--no-install" ]]; then
+    export PIP_REQUIRE_VIRTUALENV=1
     pip install -U pip
     pip install -U -r requirements/format.txt
 fi
 
 black --check slack_cli_hooks/ tests/
-flake8 slack_cli_hooks/ && flake8 tests/
+flake8 slack_cli_hooks/ tests/

scripts/run_mypy.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 # ./scripts/run_mypy.sh [--no-install]
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 if [[ "$1" != "--no-install" ]]; then
     ./scripts/install.sh

scripts/run_tests.sh

@@ -3,16 +3,16 @@
 # all: ./scripts/run_tests.sh
 # single: ./scripts/run_tests.sh tests/scenario_tests/test_app.py
 
-script_dir=$(dirname $0)
-cd ${script_dir}/..
+script_dir=$(dirname "$0")
+cd "${script_dir}/.."
 
 test_target="$1"
 
 ./scripts/format.sh --no-install
 
-if [[ $test_target != "" ]]
+if [[ "$test_target" != "" ]]
 then
-  pytest -vv $test_target
+  pytest -vv "$test_target"
 else
   pytest
 fi