feat: default manifest source to manifest.json for Bolt Framework projects (#395)

* feat: default manifest source to local for non-Deno apps

Change the default manifest source for non-Deno (Bolt) projects from
ManifestSourceRemote to ManifestSourceLocal, aligning their behavior
with Deno projects.

* feat: fix preserving app manifest source when template sets it

Author: mwbrooks

cmd/project/init.go

@@ -20,7 +20,6 @@ import (
 	"strings"
 
 	"github.com/slackapi/slack-cli/cmd/app"
-	"github.com/slackapi/slack-cli/internal/config"
 	"github.com/slackapi/slack-cli/internal/pkg/create"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/shared/types"
@@ -108,8 +107,7 @@ func projectInitCommandRunE(clients *shared.ClientFactory, cmd *cobra.Command, a
 
 	// Install the project dependencies, such as .slack/ and runtime packages
 	// Existing projects initialized always default to config.ManifestSourceLocal.
-	// The link command will switch it to config.ManifestSourceRemote
-	_ = create.InstallProjectDependencies(ctx, clients, projectDirPath, config.ManifestSourceLocal)
+	_ = create.InstallProjectDependencies(ctx, clients, projectDirPath)
 
 	// Add an existing app to the project
 	err = app.LinkExistingApp(ctx, clients, &types.App{}, true)

cmd/project/init_test.go

@@ -72,7 +72,7 @@ func Test_Project_InitCommand(t *testing.T) {
 				require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack"))
 				require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack", ".gitignore"))
 				require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack", "hooks.json"))
-				require.Contains(t, output, `Updated config.json manifest source to "project" (local)`)
+				require.Contains(t, output, `Updated app manifest source to "project" (local)`)
 				// Assert prompt to add existing apps was called
 				cm.IO.AssertCalled(
 					t,

internal/pkg/create/create.go

@@ -156,7 +156,7 @@ func Create(ctx context.Context, clients *shared.ClientFactory, createArgs Creat
 
 	// Install project dependencies to add CLI support and cache dev dependencies.
 	// CLI created projects always default to config.ManifestSourceLocal.
-	InstallProjectDependencies(ctx, clients, projectDirPath, config.ManifestSourceLocal)
+	InstallProjectDependencies(ctx, clients, projectDirPath)
 	clients.IO.PrintTrace(ctx, slacktrace.CreateDependenciesSuccess)
 
 	return appDirPath, nil
@@ -413,7 +413,6 @@ func InstallProjectDependencies(
 	ctx context.Context,
 	clients *shared.ClientFactory,
 	projectDirPath string,
-	manifestSource config.ManifestSource,
 ) []string {
 	var outputs []string
 
@@ -516,30 +515,20 @@ func InstallProjectDependencies(
 		}
 	}
 
-	// Default manifest source to ManifestSourceLocal
-	if !manifestSource.Exists() {
-		manifestSource = config.ManifestSourceLocal
-	}
-
-	// Set non-Deno (non-ROSI) projects to ManifestSourceRemote.
-	// TODO: should check if Slack hosted project, but the SDKConfig has not been initialized yet.
-	if clients.Runtime != nil {
-		isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno")
-		if !isDenoProject {
-			manifestSource = config.ManifestSourceRemote
-		}
+	// Get the manifest source from the project-level config
+	manifestSource, err := clients.Config.ProjectConfig.GetManifestSource(ctx)
+	if err != nil {
+		clients.IO.PrintDebug(ctx, "Error getting manifest source: %s", err)
 	}
 
 	// Set "manifest.source" in .slack/config.json
 	if err := config.SetManifestSource(ctx, clients.Fs, clients.Os, manifestSource); err != nil {
 		clients.IO.PrintDebug(ctx, "Error setting manifest source in project-level config: %s", err)
 	} else {
-		configJSONFilename := config.ProjectConfigJSONFilename
 		manifestSourceStyled := style.Highlight(manifestSource.Human())
 
 		outputs = append(outputs, fmt.Sprintf(
-			"Updated %s manifest source to %s",
-			configJSONFilename,
+			"Updated app manifest source to %s",
 			manifestSourceStyled,
 		))
 	}

internal/pkg/create/create_test.go

@@ -366,6 +366,7 @@ func Test_Create_installProjectDependencies(t *testing.T) {
 		experiments            []string
 		runtime                string
 		manifestSource         config.ManifestSource
+		expectedManifestSource config.ManifestSource
 		existingFiles          map[string]string
 		expectedOutputs        []string
 		unexpectedOutputs      []string
@@ -418,24 +419,38 @@ func Test_Create_installProjectDependencies(t *testing.T) {
 		},
 		"When no manifest source, default to project (local)": {
 			expectedOutputs: []string{
-				`Updated config.json manifest source to "project" (local)`,
+				`Updated app manifest source to "project" (local)`,
 			},
 		},
-		"When manifest source is provided, should set it": {
-			manifestSource: config.ManifestSourceRemote,
+		"When remote manifest source is provided, should use it": {
+			manifestSource:         config.ManifestSourceRemote,
+			expectedManifestSource: config.ManifestSourceRemote,
+			existingFiles: map[string]string{
+				".slack/hooks.json": "{}",
+			},
+			expectedOutputs: []string{
+				`Updated app manifest source to "app settings" (remote)`,
+			},
+		},
+		"When local manifest source is provided, should use it": {
+			manifestSource:         config.ManifestSourceLocal,
+			expectedManifestSource: config.ManifestSourceLocal,
+			existingFiles: map[string]string{
+				".slack/hooks.json": "{}",
+			},
 			expectedOutputs: []string{
-				`Updated config.json manifest source to "app settings" (remote)`,
+				`Updated app manifest source to "project" (local)`,
 			},
 		},
 		"When Deno project, should set manifest source to project (local)": {
 			expectedOutputs: []string{
-				`Updated config.json manifest source to "project" (local)`,
+				`Updated app manifest source to "project" (local)`,
 			},
 		},
-		"When non-Deno project, should set manifest source to app settings (remote)": {
+		"When non-Deno project, should set manifest source to project (local)": {
 			runtime: "node",
 			expectedOutputs: []string{
-				`Updated config.json manifest source to "app settings" (remote)`,
+				`Updated app manifest source to "project" (local)`,
 			},
 		},
 	}
@@ -490,8 +505,15 @@ func Test_Create_installProjectDependencies(t *testing.T) {
 				}
 			}
 
+			// Set manifest source
+			if tc.manifestSource != "" {
+				if err := config.SetManifestSource(ctx, clientsMock.Fs, clientsMock.Os, tc.manifestSource); err != nil {
+					require.FailNow(t, fmt.Sprintf("Failed to set the manifest source in the memory-based file system: %s", err))
+				}
+			}
+
 			// Run the test
-			outputs := InstallProjectDependencies(ctx, clients, projectDirPath, tc.manifestSource)
+			outputs := InstallProjectDependencies(ctx, clients, projectDirPath)
 
 			// Assertions
 			for _, expectedOutput := range tc.expectedOutputs {
@@ -503,6 +525,13 @@ func Test_Create_installProjectDependencies(t *testing.T) {
 			for _, expectedVerboseOutput := range tc.expectedVerboseOutputs {
 				clientsMock.IO.AssertCalled(t, "PrintDebug", mock.Anything, expectedVerboseOutput, tc.expectedVerboseArgs)
 			}
+			if tc.expectedManifestSource != "" {
+				actualManifestSource, err := clients.Config.ProjectConfig.GetManifestSource(ctx)
+				if err != nil {
+					require.FailNow(t, fmt.Sprintf("Failed to get the manifest source: %s", err))
+				}
+				assert.Equal(t, tc.expectedManifestSource, actualManifestSource)
+			}
 			assert.NotEmpty(t, clients.Config.ProjectID, "config.project_id")
 			// output := clientsMock.GetCombinedOutput()
 			// assert.Contains(t, output, tc.expectedOutputs)