test: increase test coverage for slackhttp and update (#416)

* test: increase test coverage for slackhttp and update

* test: rename and reorder update test functions to match conventions

Rename test functions to use full struct name (Test_UpdateNotification_*)
and reorder alphabetically by base method name with getter/setter grouping.

Author: mwbrooks

internal/slackhttp/http_test.go

@@ -53,6 +53,27 @@ func Test_NewHTTPClient(t *testing.T) {
 			timeout:         120 * time.Second,
 			expectedTimeout: 120 * time.Second,
 		},
+		"Zero timeout uses default timeout": {
+			timeout:               0,
+			expectedTimeout:       defaultTotalTimeout,
+			expectedSkipTLSVerify: false,
+		},
+		"Custom timeout is used when non-zero": {
+			timeout:               60 * time.Second,
+			expectedTimeout:       60 * time.Second,
+			expectedSkipTLSVerify: false,
+		},
+		"SkipTLSVerify false keeps verification enabled": {
+			skipTLSVerify:         false,
+			expectedSkipTLSVerify: false,
+			expectedTimeout:       defaultTotalTimeout,
+		},
+		"Retries zero returns non-retrying transport": {
+			retries:               0,
+			expectedRetries:       0,
+			expectedTimeout:       defaultTotalTimeout,
+			expectedSkipTLSVerify: false,
+		},
 	}
 	for name, tc := range tests {
 		t.Run(name, func(t *testing.T) {

internal/update/update_test.go

@@ -52,7 +52,32 @@ func (m *mockDependency) InstallUpdate(ctx context.Context) error {
 	return args.Error(0)
 }
 
-func Test_Update_HasUpdate(t *testing.T) {
+func Test_UpdateNotification_Dependencies(t *testing.T) {
+	dep := &mockDependency{}
+	u := &UpdateNotification{
+		dependencies: []Dependency{dep},
+	}
+	require.Len(t, u.Dependencies(), 1)
+	require.Equal(t, dep, u.Dependencies()[0])
+}
+
+func Test_UpdateNotification_SetEnabled(t *testing.T) {
+	u := &UpdateNotification{}
+	u.SetEnabled(true)
+	require.True(t, u.Enabled())
+	u.SetEnabled(false)
+	require.False(t, u.Enabled())
+}
+
+func Test_UpdateNotification_SetEnv(t *testing.T) {
+	u := &UpdateNotification{}
+	u.SetEnv("SLACK_SKIP_UPDATE")
+	require.Equal(t, "SLACK_SKIP_UPDATE", u.Env())
+	u.SetEnv("")
+	require.Equal(t, "", u.Env())
+}
+
+func Test_UpdateNotification_HasUpdate(t *testing.T) {
 	for name, tc := range map[string]struct {
 		dependencyHasUpdate []bool
 		expectedReturnValue bool
@@ -111,7 +136,15 @@ func Test_Update_HasUpdate(t *testing.T) {
 	}
 }
 
-func Test_Update_isIgnoredCommand(t *testing.T) {
+func Test_UpdateNotification_SetHours(t *testing.T) {
+	u := &UpdateNotification{}
+	u.SetHours(48.0)
+	require.Equal(t, 48.0, u.Hours())
+	u.SetHours(0)
+	require.Equal(t, 0.0, u.Hours())
+}
+
+func Test_UpdateNotification_isIgnoredCommand(t *testing.T) {
 	for name, tc := range map[string]struct {
 		command  string
 		expected bool