feat: Add --auto-approve flag to upgrade command

Author: kkemple

.gitignore

@@ -34,6 +34,9 @@ package-lock.json
 # VSCode extensions
 *.http
 
+# Cursor rules
+.cursor/rules
+
 # Temp log files
 *.log
 

cmd/upgrade/upgrade.go

@@ -31,7 +31,9 @@ var checkForUpdatesFunc = checkForUpdates
 const changelogURL = "https://docs.slack.dev/changelog"
 
 func NewCommand(clients *shared.ClientFactory) *cobra.Command {
-	return &cobra.Command{
+	var autoApprove bool
+	
+	cmd := &cobra.Command{
 		Use:     "upgrade",
 		Aliases: []string{"update"},
 		Short:   "Checks for available updates to the CLI or SDK",
@@ -44,16 +46,21 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 		}, "\n"),
 		Example: style.ExampleCommandsf([]style.ExampleCommand{
 			{Command: "upgrade", Meaning: "Check for any available updates"},
+			{Command: "upgrade --auto-approve", Meaning: "Check for updates and automatically upgrade without confirmation"},
 		}),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return checkForUpdatesFunc(clients, cmd)
+			return checkForUpdatesFunc(clients, cmd, autoApprove)
 		},
 	}
+	
+	cmd.Flags().BoolVar(&autoApprove, "auto-approve", false, "automatically approve and install updates without prompting")
+	
+	return cmd
 }
 
 // checkForUpdates will check for CLI/SDK updates and print a message when no updates are available.
 // When there are updates, the function will *not* print a message because the root command handles printing update notifications.
-func checkForUpdates(clients *shared.ClientFactory, cmd *cobra.Command) error {
+func checkForUpdates(clients *shared.ClientFactory, cmd *cobra.Command, autoApprove bool) error {
 	ctx := cmd.Context()
 	updateNotification := update.New(clients, version.Get(), "SLACK_SKIP_UPDATE")
 
@@ -70,6 +77,11 @@ func checkForUpdates(clients *shared.ClientFactory, cmd *cobra.Command) error {
 	// Update notification messages are printed by the root command's persistent post-run (cmd/root.go).
 	// So this command only needs to print a message when everything is up-to-date.
 	if updateNotification.HasUpdate() {
+		if autoApprove {
+			// Automatically install updates without prompting when auto-approve flag is set
+			updateNotification.InstallUpdatesWithoutPrompt(cmd)
+			return nil
+		}
 		return nil
 	}
 

cmd/upgrade/upgrade_test.go

@@ -29,8 +29,8 @@ type UpdatePkgMock struct {
 	mock.Mock
 }
 
-func (m *UpdatePkgMock) CheckForUpdates(clients *shared.ClientFactory, cmd *cobra.Command) error {
-	args := m.Called(clients, cmd)
+func (m *UpdatePkgMock) CheckForUpdates(clients *shared.ClientFactory, cmd *cobra.Command, autoApprove bool) error {
+	args := m.Called(clients, cmd, autoApprove)
 	return args.Error(0)
 }
 
@@ -49,11 +49,26 @@ func TestUpgradeCommand(t *testing.T) {
 	updatePkgMock := new(UpdatePkgMock)
 	checkForUpdatesFunc = updatePkgMock.CheckForUpdates
 
-	updatePkgMock.On("CheckForUpdates", mock.Anything, mock.Anything).Return(nil)
+	// Test default behavior (no auto-approve)
+	updatePkgMock.On("CheckForUpdates", mock.Anything, mock.Anything, false).Return(nil)
 	err := cmd.ExecuteContext(ctx)
 	if err != nil {
 		assert.Fail(t, "cmd.Upgrade had unexpected error")
 	}
+	updatePkgMock.AssertCalled(t, "CheckForUpdates", mock.Anything, mock.Anything, false)
 
-	updatePkgMock.AssertCalled(t, "CheckForUpdates", mock.Anything, mock.Anything)
+	// Test with auto-approve flag
+	cmd = NewCommand(clients)
+	testutil.MockCmdIO(clients.IO, cmd)
+	cmd.SetArgs([]string{"--auto-approve"})
+	
+	updatePkgMock = new(UpdatePkgMock)
+	checkForUpdatesFunc = updatePkgMock.CheckForUpdates
+	updatePkgMock.On("CheckForUpdates", mock.Anything, mock.Anything, true).Return(nil)
+	
+	err = cmd.ExecuteContext(ctx)
+	if err != nil {
+		assert.Fail(t, "cmd.Upgrade with auto-approve had unexpected error")
+	}
+	updatePkgMock.AssertCalled(t, "CheckForUpdates", mock.Anything, mock.Anything, true)
 }

docs/reference/commands/slack_upgrade.md

@@ -18,12 +18,14 @@ slack upgrade [flags]
 
 ```
 $ slack upgrade  # Check for any available updates
+$ slack upgrade --auto-approve  # Check for updates and automatically upgrade without confirmation
 ```
 
 ### Options
 
 ```
-  -h, --help   help for upgrade
+      --auto-approve   automatically approve and install updates without prompting
+  -h, --help           help for upgrade
 ```
 
 ### Options inherited from parent commands

internal/update/cli.go

@@ -87,17 +87,25 @@ func (c *CLIDependency) PrintUpdateNotification(cmd *cobra.Command) (bool, error
 			"\n   To update with Homebrew, run: %s\n\n",
 			style.CommandText(fmt.Sprintf("brew update && brew upgrade %s", processName)),
 		)
+		return false, nil
 	} else {
 		cmd.Printf(
 			"\n   To manually update, visit the download page:\n   %s\n\n",
 			style.CommandText("https://tools.slack.dev/slack-cli"),
 		)
+		
+		// Check for auto-approve from upgrade command
+		if cmd.Name() == "upgrade" && cmd.Flags().Changed("auto-approve") {
+			autoApprove, _ := cmd.Flags().GetBool("auto-approve")
+			if autoApprove {
+				return true, nil 
+			}
+		}
+		
 		selfUpdatePrompt := fmt.Sprintf("%sDo you want to auto-update to the latest version now?", style.Emoji("rocket"))
 		return c.clients.IO.ConfirmPrompt(ctx, selfUpdatePrompt, false)
 	}
 
-	return false, nil
-
 	// TODO: Uncomment when open sourced to display the latest release URL that includes release notes
 	// cmd.Printf(
 	// 	"\n%s\n\n",

internal/update/sdk.go

@@ -319,6 +319,14 @@ func (c *SDKDependency) PrintUpdateNotification(cmd *cobra.Command) (bool, error
 
 	// If `install-update` hook available, prompt to auto-update
 	if c.clients.SDKConfig.Hooks.InstallUpdate.IsAvailable() {
+		// Check for auto-approve from upgrade command
+		if cmd.Name() == "upgrade" && cmd.Flags().Changed("auto-approve") {
+			autoApprove, _ := cmd.Flags().GetBool("auto-approve")
+			if autoApprove {
+				return true, nil
+			}
+		}
+		
 		autoUpdatePrompt := fmt.Sprintf("%sDo you want to auto-update to the latest versions now?", style.Emoji("rocket"))
 		return c.clients.IO.ConfirmPrompt(ctx, autoUpdatePrompt, false)
 	}

internal/update/update.go

@@ -26,6 +26,7 @@ import (
 	"github.com/slackapi/slack-cli/internal/goutils"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/slackerror"
+	"github.com/slackapi/slack-cli/internal/style"
 	"github.com/spf13/cobra"
 )
 
@@ -251,3 +252,31 @@ func (u *UpdateNotification) isLastUpdateCheckedAtGreaterThan(ctx context.Contex
 func newHTTPClient() (*http.Client, error) {
 	return api.NewHTTPClient(api.HTTPClientOptions{TotalTimeOut: 60 * time.Second}), nil
 }
+
+// InstallUpdatesWithoutPrompt automatically installs updates without prompting the user
+// This is used by the upgrade command when the --auto-approve flag is set
+func (u *UpdateNotification) InstallUpdatesWithoutPrompt(cmd *cobra.Command) error {
+	ctx := cmd.Context()
+
+	for _, dependency := range u.Dependencies() {
+		hasUpdate, err := dependency.HasUpdate()
+		if err != nil {
+			return slackerror.Wrap(err, "An error occurred while fetching a dependency")
+		}
+
+		if hasUpdate {
+			// Print update notification but skip the confirmation prompt
+			_, err := dependency.PrintUpdateNotification(cmd)
+			if err != nil {
+				return err
+			}
+			
+			// Install the update without prompting
+			cmd.Printf("%s Installing update automatically...\n", style.Styler().Green("✓").String())
+			if err := dependency.InstallUpdate(ctx); err != nil {
+				return err
+			}
+		}
+	}
+	return nil
+}