prompt when id missing for delete cmd

Author: vegeris

cmd/sandbox/create.go

@@ -49,24 +49,6 @@ var templateNameToID = map[string]int{
 	"empty":   0, // The sandbox will be empty if the template param is not set
 }
 
-// getTemplateID converts a template string to an integer ID
-func getTemplateID(template string) (int, error) {
-	if template == "" {
-		return 0, nil
-	}
-	key := strings.ToLower(strings.TrimSpace(template))
-	// If the provided string is present in the map, return the ID
-	if id, ok := templateNameToID[key]; ok {
-		return id, nil
-	}
-	// We also accept an integer passed directly via the flag
-	if id, err := strconv.Atoi(key); err == nil {
-		return id, nil
-	}
-	return 0, slackerror.New(slackerror.ErrInvalidTemplateID).
-		WithMessage("Invalid template: %q", template)
-}
-
 func NewCreateCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "create [flags]",
@@ -264,6 +246,24 @@ func domainFromName(name string) (string, error) {
 	return string(domain), nil
 }
 
+// getTemplateID converts a template string to an integer ID
+func getTemplateID(template string) (int, error) {
+	if template == "" {
+		return 0, nil
+	}
+	key := strings.ToLower(strings.TrimSpace(template))
+	// If the provided string is present in the map, return the ID
+	if id, ok := templateNameToID[key]; ok {
+		return id, nil
+	}
+	// We also accept an integer passed directly via the flag
+	if id, err := strconv.Atoi(key); err == nil {
+		return id, nil
+	}
+	return 0, slackerror.New(slackerror.ErrInvalidTemplateID).
+		WithMessage("Invalid template: %q", template)
+}
+
 func printCreateSuccess(cmd *cobra.Command, clients *shared.ClientFactory, teamID, url string) {
 	ctx := cmd.Context()
 	clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{

cmd/sandbox/delete.go

@@ -51,10 +51,6 @@ func NewDeleteCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd.Flags().StringVar(&deleteCmdFlags.sandboxID, "sandbox-id", "", "Sandbox team ID to delete")
 	cmd.Flags().BoolVar(&deleteCmdFlags.force, "force", false, "Skip confirmation prompt")
 
-	if err := cmd.MarkFlagRequired("sandbox-id"); err != nil {
-		panic(err)
-	}
-
 	return cmd
 }
 
@@ -66,13 +62,27 @@ func runDeleteCommand(cmd *cobra.Command, clients *shared.ClientFactory) error {
 		return err
 	}
 
+	sandboxID := deleteCmdFlags.sandboxID
+	if sandboxID == "" {
+		sandboxID, err = clients.IO.InputPrompt(
+			ctx,
+			"Enter the ID of the sandbox",
+			iostreams.InputPromptConfig{
+				Required: true,
+			},
+		)
+		if err != nil {
+			return err
+		}
+	}
+
 	skipConfirm := deleteCmdFlags.force
 	if !skipConfirm {
 		clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{
 			Emoji: "warning",
 			Text:  style.Bold(" Danger zone"),
 			Secondary: []string{
-				fmt.Sprintf("Sandbox (%s) and all of its data will be permanently deleted", deleteCmdFlags.sandboxID),
+				fmt.Sprintf("Sandbox (%s) and all of its data will be permanently deleted", sandboxID),
 				"This cannot be undone",
 			},
 		}))
@@ -93,15 +103,15 @@ func runDeleteCommand(cmd *cobra.Command, clients *shared.ClientFactory) error {
 		}
 	}
 
-	if err := clients.API().DeleteSandbox(ctx, auth.Token, deleteCmdFlags.sandboxID); err != nil {
+	if err := clients.API().DeleteSandbox(ctx, auth.Token, sandboxID); err != nil {
 		return err
 	}
 
 	clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{
 		Emoji: "white_check_mark",
 		Text:  "Sandbox Deleted",
 		Secondary: []string{
-			"Sandbox " + deleteCmdFlags.sandboxID + " has been permanently deleted",
+			"Sandbox " + sandboxID + " has been permanently deleted",
 		},
 	}))
 

internal/slackerror/errors.go

@@ -271,6 +271,7 @@ const (
 	ErrYaml                                          = "yaml_error"
 	ErrSandboxDomainTaken                            = "domain_taken"
 	ErrAtActiveSandboxLimit                          = "at_active_sandbox_limit"
+	ErrInvalidSandboxTeamID                          = "invalid_sandbox_team_id"
 	ErrInvalidArchiveTTL                             = "invalid_archive_ttl"
 )
 
@@ -1634,6 +1635,12 @@ Otherwise start your app for local development with: %s`,
 		Message: "You've reached the maximum number of active sandboxes",
 	},
 
+	ErrInvalidSandboxTeamID: {
+		Code:        ErrInvalidSandboxTeamID,
+		Message:     "The provided sandbox team ID is invalid",
+		Remediation: fmt.Sprintf("List your sandboxes with the %s command to find the ID", style.Commandf("sandbox list", false)),
+	},
+
 	ErrInvalidArchiveTTL: {
 		Code:        ErrInvalidArchiveTTL,
 		Message:     "Invalid TTL",