Remove unused methods in base LCM

joeygrover · joeygrover · commit 712c4a9b2ffb · 2020-06-30T11:11:42.000-04:00
diff --git a/base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java b/base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java
@@ -934,12 +934,12 @@ public void onProtocolSessionStarted(SessionType sessionType, byte sessionID, by
 
         @Override
         public void onProtocolSessionEnded(SessionType sessionType, byte sessionID, String correlationID) {
-            BaseLifecycleManager.this.onServiceEnded(sessionType);
+            //Currently not necessary
         }
 
         @Override
         public void onProtocolSessionEndedNACKed(SessionType sessionType, byte sessionID, String correlationID) {
-            BaseLifecycleManager.this.onStopServiceNACKed(sessionType);
+            //Currently not necessary
         }
 
         @Override
@@ -1368,11 +1368,6 @@ void onTransportDisconnected(String info, boolean availablePrimary, BaseTranspor
     void onStartServiceNACKed(SessionType sessionType) {
     }
 
-    void onServiceEnded(SessionType sessionType) {
-    }
-
-    void onStopServiceNACKed(SessionType sessionType) {
-    }
 
     void startVideoService(boolean encrypted, VideoStreamingParameters parameters) {
     }

Original file line number	Diff line number	Diff line change
`@@ -934,12 +934,12 @@ public void onProtocolSessionStarted(SessionType sessionType, byte sessionID, by`
`934`	`934`
`935`	`935`	`@Override`
`936`	`936`	`public void onProtocolSessionEnded(SessionType sessionType, byte sessionID, String correlationID) {`
`937`		`- BaseLifecycleManager.this.onServiceEnded(sessionType);`
	`937`	`+ //Currently not necessary`
`938`	`938`	`}`
`939`	`939`
`940`	`940`	`@Override`
`941`	`941`	`public void onProtocolSessionEndedNACKed(SessionType sessionType, byte sessionID, String correlationID) {`
`942`		`- BaseLifecycleManager.this.onStopServiceNACKed(sessionType);`
	`942`	`+ //Currently not necessary`
`943`	`943`	`}`
`944`	`944`
`945`	`945`	`@Override`
`@@ -1368,11 +1368,6 @@ void onTransportDisconnected(String info, boolean availablePrimary, BaseTranspor`
`1368`	`1368`	`void onStartServiceNACKed(SessionType sessionType) {`
`1369`	`1369`	`}`
`1370`	`1370`
`1371`		`- void onServiceEnded(SessionType sessionType) {`
`1372`		`- }`
`1373`		`-`
`1374`		`- void onStopServiceNACKed(SessionType sessionType) {`
`1375`		`- }`
`1376`	`1371`
`1377`	`1372`	`void startVideoService(boolean encrypted, VideoStreamingParameters parameters) {`
`1378`	`1373`	`}`