Merge branch 'develop' into bugfix/issue_1736_multi_file_upload

Author: Julian Kast

android/sdl_android/libs/TaskMaster-0.5.jar

@@ -32,6 +32,7 @@
 import com.smartdevicelink.proxy.rpc.SetDisplayLayoutResponse;
 import com.smartdevicelink.proxy.rpc.SoftButtonCapabilities;
 import com.smartdevicelink.proxy.rpc.SystemCapability;
+import com.smartdevicelink.proxy.rpc.TextField;
 import com.smartdevicelink.proxy.rpc.VideoStreamingCapability;
 import com.smartdevicelink.proxy.rpc.WindowCapability;
 import com.smartdevicelink.proxy.rpc.WindowTypeCapabilities;
@@ -52,6 +53,7 @@
 import com.smartdevicelink.proxy.rpc.enums.SpeechCapabilities;
 import com.smartdevicelink.proxy.rpc.enums.SystemCapabilityType;
 import com.smartdevicelink.proxy.rpc.enums.SystemContext;
+import com.smartdevicelink.proxy.rpc.enums.TextFieldName;
 import com.smartdevicelink.proxy.rpc.enums.WindowType;
 import com.smartdevicelink.proxy.rpc.listeners.OnMultipleRequestListener;
 import com.smartdevicelink.proxy.rpc.listeners.OnRPCListener;
@@ -689,6 +691,35 @@ public void testGetAndAddListenerForDisplaysCapability() {
         verify(internalInterface, times(0)).sendRPC(any(GetSystemCapability.class));
     }
 
+    /**
+     * Test to verify that we can get null for templatesAvailable without hitting an NPE and
+     * test media field conversion for NON_MEDIA to NON-MEDIA for Sync bug.
+     */
+    @Test
+    public void testMediaFieldConversion() {
+        SystemCapabilityManager systemCapabilityManager = new SystemCapabilityManager(new InternalSDLInterface());
+
+        RegisterAppInterfaceResponse raiResponse = new RegisterAppInterfaceResponse();
+        DisplayCapabilities displayCapabilities = new DisplayCapabilities();
+        displayCapabilities.setGraphicSupported(false);
+        TextField textField = new TextField();
+        textField.setName(TextFieldName.mainField1);
+        displayCapabilities.setTextFields(Collections.singletonList(textField));
+        raiResponse.setDisplayCapabilities(displayCapabilities);
+        raiResponse.setSuccess(true);
+        systemCapabilityManager.parseRAIResponse(raiResponse);
+
+        WindowCapability windowCapability = systemCapabilityManager.getDefaultMainWindowCapability();
+        assertNull(windowCapability.getTemplatesAvailable());
+
+        List<String> templates = new ArrayList<>();
+        templates.add("NON_MEDIA");
+        displayCapabilities.setTemplatesAvailable(templates);
+        systemCapabilityManager.parseRAIResponse(raiResponse);
+        windowCapability = systemCapabilityManager.getDefaultMainWindowCapability();
+        assertTrue(windowCapability.getTemplatesAvailable().contains("NON-MEDIA"));
+    }
+
     @Test
     public void testListConversion() {
         SystemCapabilityManager systemCapabilityManager = createSampleManager();

android/sdl_android/libs/Taskmaster-0.6.jar

@@ -3319,7 +3319,7 @@ private TransportType getCompatPrimaryTransport() {
                         try {
                             List<TransportType> transportTypes = (List<TransportType>) obj;
                             if (transportTypes != null) {
-                                if (transportTypes.get(0) != null) {
+                                if (transportTypes.size() > 0 && transportTypes.get(0) != null) {
                                     return transportTypes.get(0);
                                 }
                             }

android/sdl_android/src/androidTest/java/com/smartdevicelink/managers/lifecycle/SystemCapabilityManagerTests.java

@@ -135,12 +135,15 @@ private List<DisplayCapability> createDisplayCapabilityList(DisplayCapabilities
 
         // HAX: Issue #1705, Ford Sync bug returning incorrect template name for "NON-MEDIA" (https://github.com/smartdevicelink/sdl_java_suite/issues/1705).
         List<String> templatesAvailable = display.getTemplatesAvailable();
-        for (int i = 0; i < templatesAvailable.size(); i++) {
-            if (templatesAvailable.get(i).equals("NON_MEDIA")) {
-                templatesAvailable.set(i, "NON-MEDIA");
-                break;
+        if (templatesAvailable != null) {
+            for (int i = 0; i < templatesAvailable.size(); i++) {
+                if ("NON_MEDIA".equals(templatesAvailable.get(i))) {
+                    templatesAvailable.set(i, "NON-MEDIA");
+                    break;
+                }
             }
         }
+
         // copy all available display capabilities
         defaultWindowCapability.setTemplatesAvailable(templatesAvailable);
         defaultWindowCapability.setNumCustomPresetsAvailable(display.getNumCustomPresetsAvailable());

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java

@@ -182,7 +182,7 @@ interface AlertSoftButtonClearListener {
 
 
     private Queue newTransactionQueue() {
-        Queue queue = internalInterface.getTaskmaster().createQueue("AlertManager", 6, false);
+        Queue queue = internalInterface.getTaskmaster().createQueue("AlertManager", 8, false);
         queue.pause();
         return queue;
     }

base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseSystemCapabilityManager.java

@@ -64,7 +64,7 @@ public AudioControlCapabilities(Hashtable<String, Object> hash) {
     /**
      * Constructs a newly allocated AudioControlCapabilities object
      *
-     * @param moduleName short friendly name of the light control module.
+     * @param moduleName short friendly name of the audio control module.
      */
     public AudioControlCapabilities(@NonNull String moduleName) {
         this();
@@ -74,7 +74,7 @@ public AudioControlCapabilities(@NonNull String moduleName) {
     /**
      * Sets the moduleName portion of the AudioControlCapabilities class
      *
-     * @param moduleName The short friendly name of the light control module. It should not be used to identify a module by mobile application.
+     * @param moduleName The short friendly name of the audio control module. It should not be used to identify a module by mobile application.
      */
     public AudioControlCapabilities setModuleName(@NonNull String moduleName) {
         setValue(KEY_MODULE_NAME, moduleName);
@@ -84,7 +84,7 @@ public AudioControlCapabilities setModuleName(@NonNull String moduleName) {
     /**
      * Gets the moduleName portion of the AudioControlCapabilities class
      *
-     * @return String - The short friendly name of the light control module. It should not be used to identify a module by mobile application.
+     * @return String - The short friendly name of the audio control module. It should not be used to identify a module by mobile application.
      */
     public String getModuleName() {
         return getString(KEY_MODULE_NAME);

base/src/main/java/com/smartdevicelink/managers/screen/BaseAlertManager.java

@@ -68,7 +68,7 @@ public RadioControlCapabilities(Hashtable<String, Object> hash) {
     /**
      * Constructs a new RadioControlCapabilities object
      *
-     * @param moduleName The short friendly name of the climate control module.
+     * @param moduleName The short friendly name of the radio control module.
      *                   It should not be used to identify a module by mobile application.
      */
     public RadioControlCapabilities(@NonNull String moduleName) {
@@ -79,7 +79,7 @@ public RadioControlCapabilities(@NonNull String moduleName) {
     /**
      * Sets the moduleName portion of the RadioControlCapabilities class
      *
-     * @param moduleName The short friendly name of the climate control module.
+     * @param moduleName The short friendly name of the radio control module.
      *                   It should not be used to identify a module by mobile application.
      */
     public RadioControlCapabilities setModuleName(@NonNull String moduleName) {
@@ -90,7 +90,7 @@ public RadioControlCapabilities setModuleName(@NonNull String moduleName) {
     /**
      * Gets the moduleName portion of the RadioControlCapabilities class
      *
-     * @return String - Short friendly name of the climate control module.
+     * @return String - Short friendly name of the radio control module.
      */
     public String getModuleName() {
         return getString(KEY_MODULE_NAME);

base/src/main/java/com/smartdevicelink/proxy/rpc/AudioControlCapabilities.java

@@ -75,7 +75,7 @@ public SeatControlCapabilities(Hashtable<String, Object> hash) {
     /**
      * Constructs a newly allocated SeatControlCapabilities object
      *
-     * @param moduleName short friendly name of the light control module.
+     * @param moduleName short friendly name of the seat control module.
      */
     public SeatControlCapabilities(@NonNull String moduleName) {
         this();
@@ -94,7 +94,7 @@ public String getModuleName() {
     /**
      * Sets the moduleName portion of the SeatControlCapabilities class
      *
-     * @param moduleName -  The short friendly name of the light control module. It should not be used to identify a module by mobile application.
+     * @param moduleName -  The short friendly name of the seat control module. It should not be used to identify a module by mobile application.
      */
     public SeatControlCapabilities setModuleName(@NonNull String moduleName) {
         setValue(KEY_MODULE_NAME, moduleName);