diff --git a/packages/socket.io-client/lib/url.ts b/packages/socket.io-client/lib/url.ts index c84bef16f..0a2b74e56 100644 --- a/packages/socket.io-client/lib/url.ts +++ b/packages/socket.io-client/lib/url.ts @@ -59,7 +59,7 @@ export function url( if (!/^(https?|wss?):\/\//.test(uri)) { debug("protocol-less url %s", uri); - if ("undefined" !== typeof loc) { + if (loc) { uri = loc.protocol + "//" + uri; } else { uri = "https://" + uri; diff --git a/packages/socket.io-client/test/url.ts b/packages/socket.io-client/test/url.ts index 03df463d4..565aefaf4 100644 --- a/packages/socket.io-client/test/url.ts +++ b/packages/socket.io-client/test/url.ts @@ -88,4 +88,15 @@ describe("url", () => { expect(parsed.id).to.be("https://woot.com:443/some-path"); expect(parsed.path).to.be("/some-namespace"); }); + + it("works with no protocol and no location (Node.js and React Native)", function () { + if (typeof location !== "undefined") { + return this.skip(); + } + const parsed = url("woot.com:3000"); + expect(parsed.protocol).to.be("https"); + expect(parsed.host).to.be("woot.com"); + expect(parsed.port).to.be("3000"); + expect(parsed.id).to.be("https://woot.com:3000"); + }); });