Permit moving some strings in

This reduces the number of allocations and copies required.

Author: willmmiles

src/ESPAsyncWebServer.h

@@ -90,7 +90,7 @@ class AsyncWebParameter {
 
   public:
 
-    AsyncWebParameter(const String& name, const String& value, bool form=false, bool file=false, size_t size=0): _name(name), _value(value), _size(size), _isForm(form), _isFile(file){}
+    AsyncWebParameter(String name, String value, bool form=false, bool file=false, size_t size=0): _name(std::move(name)), _value(std::move(value)), _size(size), _isForm(form), _isFile(file){}
     const String& name() const { return _name; }
     const String& value() const { return _value; }
     size_t size() const { return _size; }
@@ -108,7 +108,7 @@ class AsyncWebHeader {
     String _value;
 
   public:
-    AsyncWebHeader(const String& name, const String& value): _name(name), _value(value){}
+    AsyncWebHeader(String name, String value): _name(std::move(name)), _value(std::move(value)){}
     AsyncWebHeader(const String& data): _name(), _value(){
       if(!data) return;
       int index = data.indexOf(':');
@@ -231,10 +231,10 @@ class AsyncWebServerRequest {
     void setHandler(AsyncWebHandler *handler){ _handler = handler; }
     void addInterestingHeader(const String& name);
 
-    void redirect(const String& url);
+    void redirect(String url);
 
     void send(AsyncWebServerResponse *response);
-    void send(int code, const String& contentType=String(), const String& content=String());
+    void send(int code, String contentType=String(), String content=String());
     void send(FS &fs, const String& path, const String& contentType=String(), bool download=false, AwsTemplateProcessor callback=nullptr);
     void send(File content, const String& path, const String& contentType=String(), bool download=false, AwsTemplateProcessor callback=nullptr);
     void send(Stream &stream, const String& contentType, size_t len, AwsTemplateProcessor callback=nullptr);
@@ -243,7 +243,7 @@ class AsyncWebServerRequest {
     void send_P(int code, const String& contentType, const uint8_t * content, size_t len, AwsTemplateProcessor callback=nullptr);
     void send_P(int code, const String& contentType, PGM_P content, AwsTemplateProcessor callback=nullptr);
 
-    AsyncWebServerResponse *beginResponse(int code, const String& contentType=String(), const String& content=String());
+    AsyncWebServerResponse *beginResponse(int code, String contentType=String(), String content=String());
     AsyncWebServerResponse *beginResponse(FS &fs, const String& path, const String& contentType=String(), bool download=false, AwsTemplateProcessor callback=nullptr);
     AsyncWebServerResponse *beginResponse(File content, const String& path, const String& contentType=String(), bool download=false, AwsTemplateProcessor callback=nullptr);
     AsyncWebServerResponse *beginResponse(Stream &stream, const String& contentType, size_t len, AwsTemplateProcessor callback=nullptr);

src/WebRequest.cpp

@@ -738,8 +738,8 @@ void AsyncWebServerRequest::send(AsyncWebServerResponse *response){
   }
 }
 
-AsyncWebServerResponse * AsyncWebServerRequest::beginResponse(int code, const String& contentType, const String& content){
-  return new AsyncBasicResponse(code, contentType, content);
+AsyncWebServerResponse * AsyncWebServerRequest::beginResponse(int code, String contentType, String content){
+  return new AsyncBasicResponse(code, std::move(contentType), std::move(content));
 }
 
 AsyncWebServerResponse * AsyncWebServerRequest::beginResponse(FS &fs, const String& path, const String& contentType, bool download, AwsTemplateProcessor callback){
@@ -780,8 +780,8 @@ AsyncWebServerResponse * AsyncWebServerRequest::beginResponse_P(int code, const
   return beginResponse_P(code, contentType, (const uint8_t *)content, strlen_P(content), callback);
 }
 
-void AsyncWebServerRequest::send(int code, const String& contentType, const String& content){
-  send(beginResponse(code, contentType, content));
+void AsyncWebServerRequest::send(int code, String contentType, String content){
+  send(beginResponse(code, std::move(contentType), std::move(content)));
 }
 
 void AsyncWebServerRequest::send(FS &fs, const String& path, const String& contentType, bool download, AwsTemplateProcessor callback){
@@ -816,9 +816,9 @@ void AsyncWebServerRequest::send_P(int code, const String& contentType, PGM_P co
   send(beginResponse_P(code, contentType, content, callback));
 }
 
-void AsyncWebServerRequest::redirect(const String& url){
+void AsyncWebServerRequest::redirect(String url){
   AsyncWebServerResponse * response = beginResponse(302);
-  response->addHeader("Location",url);
+  response->addHeader(F("Location"), std::move(url));
   send(response);
 }
 

src/WebResponseImpl.h

@@ -33,7 +33,7 @@ class AsyncBasicResponse: public AsyncWebServerResponse {
   private:
     String _content;
   public:
-    AsyncBasicResponse(int code, const String& contentType=String(), const String& content=String());
+    AsyncBasicResponse(int code, String contentType=String(), String content=String());
     void _respond(AsyncWebServerRequest *request);
     size_t _ack(AsyncWebServerRequest *request, size_t len, uint32_t time);
     bool _sourceValid() const { return true; }

src/WebResponses.cpp

@@ -196,10 +196,10 @@ size_t AsyncWebServerResponse::_ack(AsyncWebServerRequest *request, size_t len,
 /*
  * String/Code Response
  * */
-AsyncBasicResponse::AsyncBasicResponse(int code, const String& contentType, const String& content){
+AsyncBasicResponse::AsyncBasicResponse(int code, String contentType, String content){
   _code = code;
-  _content = content;
-  _contentType = contentType;
+  _content = std::move(content);
+  _contentType = std::move(contentType);
   if(_content.length()){
     _contentLength = _content.length();
     if(!_contentType.length())