escape Location header with JSON.stringify

atilafassina · atilafassina · commit 808177e6108c · 2026-04-08T13:27:32.000+02:00
diff --git a/packages/start/src/server/handler.ts b/packages/start/src/server/handler.ts
@@ -213,7 +213,7 @@ function handleStreamCompleteRedirect(context: PageEvent) {
   return ({ write }: { write: (html: string) => void }) => {
     context.complete = true;
     const to = context.response && context.response.headers.get("Location");
-    to && write(`<script>window.location="${to}"</script>`);
+    to && write(`<script>window.location=${JSON.stringify(to)}</script>`);
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ function handleStreamCompleteRedirect(context: PageEvent) {`
`213`	`213`	`return ({ write }: { write: (html: string) => void }) => {`
`214`	`214`	`context.complete = true;`
`215`	`215`	`const to = context.response && context.response.headers.get("Location");`
`216`		- to && write(`<script>window.location="${to}"</script>`);
	`216`	+ to && write(`<script>window.location=${JSON.stringify(to)}</script>`);
`217`	`217`	`};`
`218`	`218`	`}`
`219`	`219`