Skip to content

Commit f22b723

Browse files
authored
Merge pull request #324 from r6e/master
Add missing semicolon
2 parents d9ea4ca + b2f0bed commit f22b723

4 files changed

Lines changed: 21 additions & 1 deletion

File tree

.github/workflows/sqlite3-ruby.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,13 @@ jobs:
6363
run: bundle exec rake compile:msys2
6464
- name: test
6565
run: bundle exec rake test
66+
67+
ubuntu:
68+
runs-on: ubuntu-latest
69+
container:
70+
image: ruby:2.7.5-buster # old enough to not support SQLITE_DBCONFIG_DQS_DDL
71+
steps:
72+
- uses: actions/checkout@v3
73+
- run: bundle install
74+
- run: bundle exec rake compile
75+
- run: bundle exec rake test

CHANGELOG.rdoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
=== 1.4.4 (unreleased)
2+
3+
* Fixes
4+
* Compilation no longer fails against SQLite3 versions < 3.29.0. This issue was introduced in v1.4.3. [#324] (Thank you, @r6e!)
5+
6+
17
=== 1.4.3 (2022-05-25)
28

39
* Enhancements

ext/sqlite3/database.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ static VALUE rb_sqlite3_disable_quirk_mode(VALUE self)
7979

8080
return Qtrue;
8181
#else
82-
return Qfalse
82+
return Qfalse;
8383
#endif
8484
}
8585

test/test_database.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,10 @@ def test_execute_with_named_bind_params
512512
end
513513

514514
def test_strict_mode
515+
unless Gem::Requirement.new(">= 3.29.0").satisfied_by?(Gem::Version.new(SQLite3::SQLITE_VERSION))
516+
skip("strict mode feature not available in #{SQLite3::SQLITE_VERSION}")
517+
end
518+
515519
db = SQLite3::Database.new(':memory:')
516520
db.execute('create table numbers (val int);')
517521
db.execute('create index index_numbers_nope ON numbers ("nope");') # nothing raised

0 commit comments

Comments
 (0)