fix(features): take an OCI Feature's id from its metadata

TS processFeatureIdentifier starts an OCI Feature as {id: <reference
id>, ...} and buildDependencyGraph spreads the Feature's metadata over
it - the manifest's dev.containers.metadata annotation, else the layer's
devcontainer-feature.json - so a published Feature whose metadata names
another id (a renamed one, such as ghcr.io/codspace/features/color:1,
now new-color) takes that id. Its consecutiveId, the folder its content
is staged in and the rename check of its install wrapper follow it.

Go kept the reference's id, so read-configuration reported
color_0 where TS reports new-color_0, and the build staged the Feature
under that name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: aledbf

docs/parity/parity-matrix.yaml

@@ -1273,6 +1273,18 @@ initial_cases:
     current_status: match
     notes: "An OCI Feature set as TS writes it: sourceInformation in tryGetOCIFeatureSet's order (type, manifest, manifestDigest, featureRef, userFeatureId, userFeatureIdWithoutVersion), the manifest as the registry served it (JSON.parse of its body), featureRef in getRef's order, then internalVersion before computedDigest (applyFeatureConfigToFeature). The Feature is the annotation's metadata spread over {id, included, value} and that over the layer's devcontainer-feature.json, so its options keep the published order. Go used to re-serialize the manifest and featureRef with sorted keys and write the Feature in the struct's order."
 
+  - id: read-configuration.features-configuration-oci-feature-pinned-success
+    lane: runtime
+    command: read-configuration
+    priority: p1
+    network_required: true
+    ts_cmd: "read-configuration --workspace-folder reference/src/test/container-features/configs/lockfile-frozen --include-features-configuration"
+    key_order: ["featuresConfiguration.featureSets.0.sourceInformation.featureRef", "featuresConfiguration.featureSets.0.features.0", "featuresConfiguration.featureSets.1.sourceInformation.featureRef"]
+    asserts: [exit_code, stdout_normalized]
+    class: output-shape
+    current_status: match
+    notes: "Both Features are pinned by the fixture's lockfile. featureRef is parsed from the reference as written (tryGetOCIFeatureSet), so it keeps tag and version 1 though the manifest is fetched by the lockfile's digest. color's published metadata names it new-color: the Feature's id, and so its consecutiveId and cachePath (new-color_0), are the metadata's (buildDependencyGraph spreads it over the Feature). Go used to report the pinned digest in featureRef, without the tag, and name the folder after the reference's id (color_0)."
+
   - id: read-configuration.features-configuration-oci-feature-digest-success
     lane: runtime
     command: read-configuration

internal/cli/feature_install.go

@@ -2,6 +2,7 @@ package cli
 
 import (
 	"archive/tar"
+	"cmp"
 	"compress/gzip"
 	"context"
 	"crypto/sha256"
@@ -419,8 +420,10 @@ func processInstallFeature(
 			jsonc.Unmarshal(metaData, &m)
 		}
 
+		// TS's Feature takes its id from the metadata it spreads over
+		// {id: <ref id>, ...}: the layer's here, the annotation's below.
 		feat := features.Feature{
-			ID:               ref.ID,
+			ID:               cmp.Or(m.ID, ref.ID),
 			Version:          m.Version,
 			Name:             m.Name,
 			Description:      m.Description,
@@ -498,6 +501,7 @@ func processInstallFeature(
 					// TS reads the dependencies from the annotation and
 					// spreads it over the Feature (buildDependencyGraph).
 					set.Features[0].Metadata = am.Metadata
+					set.Features[0].ID = cmp.Or(am.ID, ref.ID)
 				}
 			}
 		}

internal/cli/feature_install_held_test.go

@@ -961,3 +961,33 @@ func TestProcessInstallFeatureOCISetJSON(t *testing.T) {
 		t.Errorf("set JSON:\ngot  %s\nwant %s", got, want)
 	}
 }
+
+// An OCI Feature's id is its metadata's, as TS spreads the metadata over
+// {id: <reference id>, ...}: the annotation's when the manifest has one,
+// else the layer's, else the reference's. consecutiveId follows it.
+func TestProcessInstallFeatureOCIIDIsTheMetadatas(t *testing.T) {
+	const id = "ghcr.io/owner/coll/hello:1"
+	renamed, anonymous := `{"id":"new-hello"}`, `{"version":"1.0.0"}`
+	for name, tc := range map[string]struct {
+		layer      string
+		annotation *string
+		want       string
+	}{
+		"annotation":            {`{"id":"layer-hello"}`, &renamed, "new-hello"},
+		"annotation without id": {`{"id":"layer-hello"}`, &anonymous, "hello"},
+		"layer":                 {`{"id":"layer-hello"}`, nil, "layer-hello"},
+		"neither":               {`{"version":"1.0.0"}`, nil, "hello"},
+	} {
+		t.Run(name, func(t *testing.T) {
+			reg := newOCIFeatureRegistry()
+			reg.add(t, id, map[string]string{"devcontainer-feature.json": tc.layer}, tc.annotation)
+			set, err := installFeature(t, reg, id, nil, nil)
+			if err != nil {
+				t.Fatal(err)
+			}
+			if got := set.Features[0].ID; got != tc.want {
+				t.Errorf("id = %q, want %q", got, tc.want)
+			}
+		})
+	}
+}