Skip to content

Commit 8a301b0

Browse files
committed
Escaped doublequotes instead of singles in strings
1 parent f5020ea commit 8a301b0

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

lib/split/analytics.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def custom_variables
3434
return nil if session[:split].nil?
3535
arr = []
3636
session[:split].each_with_index do |h, i|
37-
arr << "_gaq.push(['_setCustomVar', #{i + 1}, '#{h[0]}', '#{h[1]}', 1]);"
37+
arr << "_gaq.push([\"_setCustomVar\", #{i + 1}, \"#{h[0]}\", \"#{h[1]}\", 1]);"
3838
end
3939
arr.reverse[0..4].reverse.join("\n")
4040
end
@@ -47,22 +47,22 @@ def insert_tracker_methods(tracker_methods)
4747
tracker_methods.each do |k, v|
4848
if v.class == String && v.empty?
4949
# No argument tracker method
50-
arr << "_gaq.push(['" + "_" + "#{k}']);"
50+
arr << "_gaq.push([\"" + "_" + "#{k}\"]);"
5151
else
5252
case v
5353
when String
5454
# String argument tracker method
55-
arr << "_gaq.push(['" + '_' + "#{k}', '#{v}']);"
55+
arr << "_gaq.push([\"" + '_' + "#{k}\", \"#{v}\"]);"
5656
when TrueClass
5757
# Boolean argument tracker method
58-
arr << "_gaq.push(['" + '_' + "#{k}', #{v}]);"
58+
arr << "_gaq.push([\"" + '_' + "#{k}\", #{v}]);"
5959
when FalseClass
6060
# Boolean argument tracker method
61-
arr << "_gaq.push(['" + '_' + "#{k}', #{v}]);"
61+
arr << "_gaq.push([\"" + '_' + "#{k}\", #{v}]);"
6262
when Array
6363
# Array argument tracker method
64-
values = v.map { |value| "'#{value}'" }.join(', ')
65-
arr << "_gaq.push(['" + '_' + "#{k}', #{values}]);"
64+
values = v.map { |value| "\"#{value}\"" }.join(', ')
65+
arr << "_gaq.push([\"" + '_' + "#{k}\", #{values}]);"
6666
end
6767
end
6868
end

0 commit comments

Comments
 (0)