Raise an exception on duplicated subagent names (#41)

Author: mateusz834

splunklib/ai/engines/langchain.py

@@ -155,8 +155,21 @@ async def create_agent(
         tools = [_create_langchain_tool(t) for t in agent.tools]
 
         if agent.agents:
-            tools.extend([_agent_as_tool(a) for a in agent.agents])
-            system_prompt = AGENT_AS_TOOLS_PROMPT + "\n" + system_prompt
+            seen_names: set[str] = set()
+            for subagent in agent.agents:
+                # Call _agent_as_tool first, such that the empty name exception is
+                # checked and raised first, before the duplicated name exception.
+                tool = _agent_as_tool(subagent)
+
+                if subagent.name in seen_names:
+                    raise AssertionError(
+                        f"Subagents share the same name: {subagent.name}"
+                    )
+
+                seen_names.add(subagent.name)
+                tools.append(tool)
+
+                system_prompt = AGENT_AS_TOOLS_PROMPT + "\n" + system_prompt
 
         middleware = []
         if agent.loop_stop_conditions:
@@ -219,8 +232,6 @@ def _agent_as_tool(agent: BaseAgent[OutputT]):
     if not agent.name:
         raise AssertionError("Agent must have a name to be used by other Agents")
 
-    # TODO: we should enforce uniqueness of subagent names.
-
     if agent.input_schema is None:
 
         async def _run(content: str) -> str:

tests/integration/ai/test_agent.py

@@ -402,3 +402,70 @@ async def test_agent_loop_stop_conditions_timeout(self):
                         )
                     ]
                 )
+
+    @pytest.mark.asyncio
+    async def test_duplicated_subagent_name(self) -> None:
+        pytest.importorskip("langchain_openai")
+
+        async with (
+            Agent(
+                model=(await self.model()),
+                system_prompt="",
+                service=self.service,
+                name="subagent_name",
+            ) as subagent1,
+            Agent(
+                model=(await self.model()),
+                system_prompt="",
+                service=self.service,
+                name="subagent_name",
+            ) as subagent2,
+            Agent(
+                model=(await self.model()),
+                system_prompt="",
+                service=self.service,
+                name="",
+            ) as subagent1_empty_name,
+            Agent(
+                model=(await self.model()),
+                system_prompt="",
+                service=self.service,
+                name="",
+            ) as subagent2_empty_name,
+        ):
+            with pytest.raises(
+                AssertionError, match="Subagents share the same name: subagent_name"
+            ):
+                async with Agent(
+                    model=(await self.model()),
+                    system_prompt="",
+                    service=self.service,
+                    agents=[subagent1, subagent2],
+                ):
+                    pass
+
+            # Also make sure, that because of this check we have, we will not
+            # mistakenely accept same subagent (since they also share the same name).
+            with pytest.raises(
+                AssertionError, match="Subagents share the same name: subagent_name"
+            ):
+                async with Agent(
+                    model=(await self.model()),
+                    system_prompt="",
+                    service=self.service,
+                    agents=[subagent1, subagent1],
+                ):
+                    pass
+
+            # Make sure that the subagent is validated before the name uniqueness check.
+            with pytest.raises(
+                AssertionError,
+                match="Agent must have a name to be used by other Agents",
+            ):
+                async with Agent(
+                    model=(await self.model()),
+                    system_prompt="",
+                    service=self.service,
+                    agents=[subagent1_empty_name, subagent2_empty_name],
+                ):
+                    pass