Enable 168 format roundtrip tests by adding missing Format support (#60)

Author: kyleconroy

internal/format/expressions.go

@@ -159,6 +159,17 @@ func formatTableIdentifier(sb *strings.Builder, t *ast.TableIdentifier) {
 // formatFunctionCall formats a function call.
 func formatFunctionCall(sb *strings.Builder, fn *ast.FunctionCall) {
 	sb.WriteString(fn.Name)
+	// Handle parametric functions like quantile(0.9)(x)
+	if len(fn.Parameters) > 0 {
+		sb.WriteString("(")
+		for i, p := range fn.Parameters {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			Expression(sb, p)
+		}
+		sb.WriteString(")")
+	}
 	sb.WriteString("(")
 	if fn.Distinct {
 		sb.WriteString("DISTINCT ")
@@ -170,8 +181,98 @@ func formatFunctionCall(sb *strings.Builder, fn *ast.FunctionCall) {
 		Expression(sb, arg)
 	}
 	sb.WriteString(")")
+	// Handle SETTINGS for table functions
+	if len(fn.Settings) > 0 {
+		sb.WriteString(" SETTINGS ")
+		for i, s := range fn.Settings {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			sb.WriteString(s.Name)
+			sb.WriteString(" = ")
+			Expression(sb, s.Value)
+		}
+	}
+	// Handle window functions (OVER clause)
+	if fn.Over != nil {
+		sb.WriteString(" OVER ")
+		formatWindowSpec(sb, fn.Over)
+	}
+	// Handle alias
+	if fn.Alias != "" {
+		sb.WriteString(" AS ")
+		sb.WriteString(fn.Alias)
+	}
 }
 
+// formatWindowSpec formats a window specification.
+func formatWindowSpec(sb *strings.Builder, w *ast.WindowSpec) {
+	if w.Name != "" {
+		sb.WriteString(w.Name)
+		return
+	}
+	sb.WriteString("(")
+	if len(w.PartitionBy) > 0 {
+		sb.WriteString("PARTITION BY ")
+		for i, expr := range w.PartitionBy {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			Expression(sb, expr)
+		}
+	}
+	if len(w.OrderBy) > 0 {
+		if len(w.PartitionBy) > 0 {
+			sb.WriteString(" ")
+		}
+		sb.WriteString("ORDER BY ")
+		for i, elem := range w.OrderBy {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			formatOrderByElement(sb, elem)
+		}
+	}
+	if w.Frame != nil {
+		sb.WriteString(" ")
+		formatWindowFrame(sb, w.Frame)
+	}
+	sb.WriteString(")")
+}
+
+// formatWindowFrame formats a window frame.
+func formatWindowFrame(sb *strings.Builder, f *ast.WindowFrame) {
+	sb.WriteString(string(f.Type))
+	sb.WriteString(" ")
+	if f.EndBound != nil {
+		sb.WriteString("BETWEEN ")
+		formatFrameBound(sb, f.StartBound)
+		sb.WriteString(" AND ")
+		formatFrameBound(sb, f.EndBound)
+	} else {
+		formatFrameBound(sb, f.StartBound)
+	}
+}
+
+// formatFrameBound formats a frame bound.
+func formatFrameBound(sb *strings.Builder, b *ast.FrameBound) {
+	switch b.Type {
+	case ast.BoundCurrentRow:
+		sb.WriteString("CURRENT ROW")
+	case ast.BoundUnboundedPre:
+		sb.WriteString("UNBOUNDED PRECEDING")
+	case ast.BoundUnboundedFol:
+		sb.WriteString("UNBOUNDED FOLLOWING")
+	case ast.BoundPreceding:
+		Expression(sb, b.Offset)
+		sb.WriteString(" PRECEDING")
+	case ast.BoundFollowing:
+		Expression(sb, b.Offset)
+		sb.WriteString(" FOLLOWING")
+	}
+}
+
+
 // formatBinaryExpr formats a binary expression.
 func formatBinaryExpr(sb *strings.Builder, expr *ast.BinaryExpr) {
 	Expression(sb, expr.Left)
@@ -194,6 +295,28 @@ func formatAsterisk(sb *strings.Builder, a *ast.Asterisk) {
 		sb.WriteString(".")
 	}
 	sb.WriteString("*")
+	if len(a.Except) > 0 {
+		sb.WriteString(" EXCEPT (")
+		for i, col := range a.Except {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			sb.WriteString(col)
+		}
+		sb.WriteString(")")
+	}
+	if len(a.Replace) > 0 {
+		sb.WriteString(" REPLACE (")
+		for i, r := range a.Replace {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			Expression(sb, r.Expr)
+			sb.WriteString(" AS ")
+			sb.WriteString(r.Name)
+		}
+		sb.WriteString(")")
+	}
 }
 
 // formatAliasedExpr formats an aliased expression.

internal/format/statements.go

@@ -48,6 +48,13 @@ func formatSelectQuery(sb *strings.Builder, q *ast.SelectQuery) {
 		sb.WriteString("DISTINCT ")
 	}
 
+	// Format TOP clause
+	if q.Top != nil {
+		sb.WriteString("TOP ")
+		Expression(sb, q.Top)
+		sb.WriteString(" ")
+	}
+
 	// Format columns
 	for i, col := range q.Columns {
 		if i > 0 {
@@ -105,6 +112,25 @@ func formatSelectQuery(sb *strings.Builder, q *ast.SelectQuery) {
 		Expression(sb, q.Having)
 	}
 
+	// Format QUALIFY clause
+	if q.Qualify != nil {
+		sb.WriteString(" QUALIFY ")
+		Expression(sb, q.Qualify)
+	}
+
+	// Format WINDOW clause
+	if len(q.Window) > 0 {
+		sb.WriteString(" WINDOW ")
+		for i, w := range q.Window {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			sb.WriteString(w.Name)
+			sb.WriteString(" AS ")
+			formatWindowSpec(sb, w.Spec)
+		}
+	}
+
 	// Format ORDER BY clause
 	if len(q.OrderBy) > 0 {
 		sb.WriteString(" ORDER BY ")
@@ -126,6 +152,17 @@ func formatSelectQuery(sb *strings.Builder, q *ast.SelectQuery) {
 		Expression(sb, q.Offset)
 	}
 
+	// Format LIMIT BY clause
+	if len(q.LimitBy) > 0 {
+		sb.WriteString(" BY ")
+		for i, expr := range q.LimitBy {
+			if i > 0 {
+				sb.WriteString(", ")
+			}
+			Expression(sb, expr)
+		}
+	}
+
 	// Format SETTINGS clause
 	if len(q.Settings) > 0 {
 		sb.WriteString(" SETTINGS ")
@@ -139,6 +176,16 @@ func formatSelectQuery(sb *strings.Builder, q *ast.SelectQuery) {
 		}
 	}
 
+	// Format INTO OUTFILE clause
+	if q.IntoOutfile != nil {
+		sb.WriteString(" INTO OUTFILE '")
+		sb.WriteString(q.IntoOutfile.Filename)
+		sb.WriteString("'")
+		if q.IntoOutfile.Truncate {
+			sb.WriteString(" TRUNCATE")
+		}
+	}
+
 	// Format FORMAT clause
 	if q.Format != nil {
 		sb.WriteString(" FORMAT ")

parser/testdata/00004_top_counters/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00007_uniq/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00009_array_join_subquery/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00010_big_array_join/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00018_distinct_in_subquery/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00019_shard_quantiles_totals_distributed/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00027_simple_argMinArray/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}

parser/testdata/00034_aggregate_key_fixed_string/metadata.json

@@ -1 +1 @@
-{"todo_format":true}
+{}