feat(sqlite): Promote SQLite support to beta (#1699)

kyleconroy · web-flow · commit 9cc7a6dc609e · 2022-06-25T16:43:25.000+08:00
* feat: Rename _lemon engine to sqlite
* Add documentation for the SQLite engine
diff --git a/docs/reference/language-support.rst b/docs/reference/language-support.rst
@@ -1,21 +1,16 @@
 Database and language support
 #############################
 
-========  ============  ============
-Language  MySQL         PostgreSQL
-========  ============  ============
-Go        Stable        Stable
-Kotlin    Beta          Beta
-Python    Beta          Beta
-========  ============  ============
+========  ============  ============  ===============
+Language  MySQL         PostgreSQL    SQLite
+========  ============  ============  ===============
+Go        Stable        Stable        Beta
+Kotlin    Beta          Beta          Not implemented
+Python    Beta          Beta          Not implemented
+========  ============  ============  ===============
 
 Future Language Support
 ************************
 
 - `C# <https://github.com/kyleconroy/sqlc/issues/373>`_
 - `TypeScript <https://github.com/kyleconroy/sqlc/issues/296>`_
-
-Future Database Support
-************************
-
-- `SQLite <https://github.com/kyleconroy/sqlc/issues/161>`_
diff --git a/examples/authors/sqlc.json b/examples/authors/sqlc.json
@@ -26,7 +26,7 @@
     {
       "schema": "sqlite/schema.sql",
       "queries": "sqlite/query.sql",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "gen": {
         "go": {
           "package": "authors",
diff --git a/examples/booktest/sqlc.json b/examples/booktest/sqlc.json
@@ -20,7 +20,7 @@
       "path": "sqlite",
       "schema": "sqlite/schema.sql",
       "queries": "sqlite/query.sql",
-      "engine": "_lemon"
+      "engine": "sqlite"
     }
   ]
 }
diff --git a/examples/ondeck/sqlc.json b/examples/ondeck/sqlc.json
@@ -26,7 +26,7 @@
       "name": "ondeck",
       "schema": "sqlite/schema",
       "queries": "sqlite/query",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "emit_json_tags": true,
       "emit_prepared_queries": true,
       "emit_interface": true
diff --git a/internal/codegen/golang/go_type.go b/internal/codegen/golang/go_type.go
@@ -63,7 +63,7 @@ func goInnerType(req *plugin.CodeGenRequest, col *plugin.Column) string {
 		return mysqlType(req, col)
 	case "postgresql":
 		return postgresType(req, col)
-	case "_lemon":
+	case "sqlite":
 		return sqliteType(req, col)
 	default:
 		return "interface{}"
diff --git a/internal/compiler/engine.go b/internal/compiler/engine.go
@@ -22,7 +22,7 @@ type Compiler struct {
 func NewCompiler(conf config.SQL, combo config.CombinedSettings) *Compiler {
 	c := &Compiler{conf: conf, combo: combo}
 	switch conf.Engine {
-	case config.EngineXLemon:
+	case config.EngineSQLite:
 		c.parser = sqlite.NewParser()
 		c.catalog = sqlite.NewCatalog()
 	case config.EngineMySQL:
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -67,9 +67,7 @@ func (p *Paths) UnmarshalYAML(unmarshal func(interface{}) error) error {
 const (
 	EngineMySQL      Engine = "mysql"
 	EnginePostgreSQL Engine = "postgresql"
-
-	// Experimental engines
-	EngineXLemon Engine = "_lemon"
+	EngineSQLite     Engine = "sqlite"
 )
 
 type Config struct {
diff --git a/internal/endtoend/testdata/alias/sqlite/sqlc.json b/internal/endtoend/testdata/alias/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/coalesce/sqlite/sqlc.json b/internal/endtoend/testdata/coalesce/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/coalesce_as/sqlite/sqlc.json b/internal/endtoend/testdata/coalesce_as/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/column_as/sqlite/sqlc.json b/internal/endtoend/testdata/column_as/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "query.sql",
diff --git a/internal/endtoend/testdata/comment_syntax/sqlite/sqlc.json b/internal/endtoend/testdata/comment_syntax/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/comparisons/sqlite/sqlc.json b/internal/endtoend/testdata/comparisons/sqlite/sqlc.json
@@ -4,7 +4,7 @@
     {
       "path": "go",
       "name": "querytest",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "schema": "query.sql",
       "queries": "query.sql"
     }
diff --git a/internal/endtoend/testdata/count_star/sqlite/sqlc.json b/internal/endtoend/testdata/count_star/sqlite/sqlc.json
@@ -4,7 +4,7 @@
     {
       "path": "go",
       "name": "querytest",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "schema": "schema.sql",
       "queries": "query.sql"
     }
diff --git a/internal/endtoend/testdata/create_view/sqlite/sqlc.json b/internal/endtoend/testdata/create_view/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "schema.sql",
diff --git a/internal/endtoend/testdata/data_type_boolean/sqlite/sqlc.json b/internal/endtoend/testdata/data_type_boolean/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "db",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "schema": "query.sql",
       "queries": "query.sql"
     }
diff --git a/internal/endtoend/testdata/datatype/sqlite/sqlc.json b/internal/endtoend/testdata/datatype/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "datatype",
       "schema": "sql/",
       "queries": "sql/"
diff --git a/internal/endtoend/testdata/ddl_alter_table_add_column/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_alter_table_add_column/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_alter_table_drop_column/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_alter_table_drop_column/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_alter_table_rename/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_alter_table_rename/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_alter_table_rename_column/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_alter_table_rename_column/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_create_table/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_create_table/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_create_table_without_rowid/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_create_table_without_rowid/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_create_trigger/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_create_trigger/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_drop_table/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_drop_table/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/ddl_drop_table_if_exists/sqlite/sqlc.json b/internal/endtoend/testdata/ddl_drop_table_if_exists/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/delete_from/sqlite/sqlc.json b/internal/endtoend/testdata/delete_from/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "schema.sql",
diff --git a/internal/endtoend/testdata/emit_db_and_json_tags/sqlite/sqlc.json b/internal/endtoend/testdata/emit_db_and_json_tags/sqlite/sqlc.json
@@ -6,7 +6,7 @@
       "path": "go",
       "schema": "schema.sql",
       "queries": "query.sql",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "emit_json_tags": true,
       "emit_db_tags": true
     }
diff --git a/internal/endtoend/testdata/emit_db_tags/sqlite/sqlc.json b/internal/endtoend/testdata/emit_db_tags/sqlite/sqlc.json
@@ -6,7 +6,7 @@
       "path": "go",
       "schema": "schema.sql",
       "queries": "query.sql",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "emit_db_tags": true
     }
   ]
diff --git a/internal/endtoend/testdata/emit_methods_with_db_argument/sqlite/sqlc.json b/internal/endtoend/testdata/emit_methods_with_db_argument/sqlite/sqlc.json
@@ -6,7 +6,7 @@
       "path": "go",
       "schema": "schema.sql",
       "queries": "query.sql",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "emit_methods_with_db_argument": true
     }
   ]
diff --git a/internal/endtoend/testdata/func_match_types/sqlite/sqlc.json b/internal/endtoend/testdata/func_match_types/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "schema.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/identical_tables/sqlite/sqlc.json b/internal/endtoend/testdata/identical_tables/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/inflection/sqlite/sqlc.json b/internal/endtoend/testdata/inflection/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "query.sql",
diff --git a/internal/endtoend/testdata/insert_select/sqlite/sqlc.json b/internal/endtoend/testdata/insert_select/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "query.sql",
diff --git a/internal/endtoend/testdata/insert_select_invalid/sqlite/sqlc.json b/internal/endtoend/testdata/insert_select_invalid/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "query.sql",
diff --git a/internal/endtoend/testdata/insert_values/sqlite/sqlc.json b/internal/endtoend/testdata/insert_values/sqlite/sqlc.json
@@ -2,7 +2,7 @@
   "version": "1",
   "packages": [
     {
-      "engine": "_lemon",
+      "engine": "sqlite",
       "path": "go",
       "name": "querytest",
       "schema": "query.sql",
diff --git a/internal/endtoend/testdata/invalid_group_by_reference/sqlite/sqlc.json b/internal/endtoend/testdata/invalid_group_by_reference/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/invalid_table_alias/sqlite/sqlc.json b/internal/endtoend/testdata/invalid_table_alias/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/join_alias/sqlite/sqlc.json b/internal/endtoend/testdata/join_alias/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/join_from/sqlite/sqlc.json b/internal/endtoend/testdata/join_from/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/join_left/sqlite/sqlc.json b/internal/endtoend/testdata/join_left/sqlite/sqlc.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "path": "go",
-      "engine": "_lemon",
+      "engine": "sqlite",
       "name": "querytest",
       "schema": "query.sql",
       "queries": "query.sql"
diff --git a/internal/endtoend/testdata/join_left_same_table/sqlite/sqlc.json b/internal/endtoend/testdata/join_left_same_table/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/join_table_name/sqlite/sqlc.json b/internal/endtoend/testdata/join_table_name/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/join_two_tables/sqlite/sqlc.json b/internal/endtoend/testdata/join_two_tables/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/join_where_clause/sqlite/sqlc.json b/internal/endtoend/testdata/join_where_clause/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/limit/sqlite/sqlc.json b/internal/endtoend/testdata/limit/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/select_limit/sqlite/sqlc.json b/internal/endtoend/testdata/select_limit/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/select_nested_count/sqlite/sqlc.json b/internal/endtoend/testdata/select_nested_count/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/select_star/sqlite/sqlc.json b/internal/endtoend/testdata/select_star/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/single_param_conflict/sqlite/sqlc.json b/internal/endtoend/testdata/single_param_conflict/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/update_set/sqlite/sqlc.json b/internal/endtoend/testdata/update_set/sqlite/sqlc.json
diff --git a/internal/endtoend/testdata/update_set_multiple/sqlite/sqlc.json b/internal/endtoend/testdata/update_set_multiple/sqlite/sqlc.json

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`{`
`27`	`27`	`"schema": "sqlite/schema.sql",`
`28`	`28`	`"queries": "sqlite/query.sql",`
`29`		`- "engine": "_lemon",`
	`29`	`+ "engine": "sqlite",`
`30`	`30`	`"gen": {`
`31`	`31`	`"go": {`
`32`	`32`	`"package": "authors",`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`"path": "sqlite",`
`21`	`21`	`"schema": "sqlite/schema.sql",`
`22`	`22`	`"queries": "sqlite/query.sql",`
`23`		`- "engine": "_lemon"`
	`23`	`+ "engine": "sqlite"`
`24`	`24`	`}`
`25`	`25`	`]`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"packages": [`
`4`	`4`	`{`
`5`	`5`	`"path": "go",`
`6`		`- "engine": "_lemon",`
	`6`	`+ "engine": "sqlite",`
`7`	`7`	`"name": "querytest",`
`8`	`8`	`"schema": "query.sql",`
`9`	`9`	`"queries": "query.sql"`