Merge pull request #310 from sqlkata/issue/305

ahmad-moussawi · web-flow · commit e435350849a5 · 2019-10-22T22:16:51.000+03:00
fix safe order (SELECT 0 FROM DUAL)
diff --git a/QueryBuilder/Compilers/OracleCompiler.cs b/QueryBuilder/Compilers/OracleCompiler.cs
@@ -48,9 +48,10 @@ public override string CompileLimit(SqlResult ctx)
             }
 
             var safeOrder = "";
+
             if (!ctx.Query.HasComponent("order"))
             {
-                safeOrder = "ORDER BY (SELECT 0) ";
+                safeOrder = "ORDER BY (SELECT 0 FROM DUAL) ";
             }
 
             if (limit == 0)
@@ -126,7 +127,7 @@ protected override string CompileBasicDateCondition(SqlResult ctx, BasicDateCond
                             valueFormat = $"TO_DATE({value}, 'HH24:MI')";
                         else // assume HH:MM:SS format
                             valueFormat = $"TO_DATE({value}, 'HH24:MI:SS')";
-                    } 
+                    }
                     sql = $"TO_CHAR({column}, 'HH24:MI:SS') {condition.Operator} TO_CHAR({valueFormat}, 'HH24:MI:SS')";
                     break;
                 case "year":

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,10 @@ public override string CompileLimit(SqlResult ctx)`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`var safeOrder = "";`
	`51`	`+`
`51`	`52`	`if (!ctx.Query.HasComponent("order"))`
`52`	`53`	`{`
`53`		`- safeOrder = "ORDER BY (SELECT 0) ";`
	`54`	`+ safeOrder = "ORDER BY (SELECT 0 FROM DUAL) ";`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`if (limit == 0)`
`@@ -126,7 +127,7 @@ protected override string CompileBasicDateCondition(SqlResult ctx, BasicDateCond`
`126`	`127`	`valueFormat = $"TO_DATE({value}, 'HH24:MI')";`
`127`	`128`	`else // assume HH:MM:SS format`
`128`	`129`	`valueFormat = $"TO_DATE({value}, 'HH24:MI:SS')";`
`129`		`- }`
	`130`	`+ }`
`130`	`131`	`sql = $"TO_CHAR({column}, 'HH24:MI:SS') {condition.Operator} TO_CHAR({valueFormat}, 'HH24:MI:SS')";`
`131`	`132`	`break;`
`132`	`133`	`case "year":`